Date:   Thu, 9 Mar 2023 16:47:25 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     "Radu Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: fix MII_BASIC_CONFIG_REV
 bit
Message-ID: <ZAn/jWfoR5jmiQnY@corigine.com>
References: <20230309100111.1246214-1-radu-nicolae.pirea@oss.nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230309100111.1246214-1-radu-nicolae.pirea@oss.nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0s4c+nyMuRCKXAe8hhDM6HKigRV3OopkLWwZUQZtr2/jE3k3wmuMFunHSbpv?=
 =?us-ascii?Q?MM5Whg8M0WC2UqN+LkDH4VmDu04aKl0XlhfLjlBi1cDXe0MZTPSQp+hupVLS?=
 =?us-ascii?Q?D4lvjnh7juqGCEORyhriBzBRz+YoyKJVan9Ib0T+iBwPntjeX7VrztgAyWUW?=
 =?us-ascii?Q?Dl3W/q9SQ33qTRSM9vKPEIcdwL4a03fkY+/EhYJ4/KPrukjurOGh5V5/gEor?=
 =?us-ascii?Q?Tl7vJCSVdfmwvp+r0/gHy1mw6wnWVuzX3LoPuvwkVJJwkRYAcaqnUi9cDSmk?=
 =?us-ascii?Q?Lc1wm0B4+uYknELBKJG5bhzOA99mqbdAPb7f2VIUKVrZum5aWH57mmHwwQHj?=
 =?us-ascii?Q?/dz2iodigZfhVPv9v9O1htElgHc9hG+EMlLb3CMAAgNZUPxCdGNwwsj2RZ3S?=
 =?us-ascii?Q?XqoUYwZrkdmrsVjrGp+uTu3yw4MdVhfxErz3rQ97+eonYiZrCSXj59hcOmKm?=
 =?us-ascii?Q?Sc8CLjQve8GK5l6RtSsNoNb+O9P3SbwctLExh6KbYrpvxzH1qCiqm5UwwmBL?=
 =?us-ascii?Q?AqH7kxDseuOsCbwfQqYoCK8MFVip57AqCwI0/MeJlyqCgbbAfqlFjuL/lle9?=
 =?us-ascii?Q?UntZrG5lErd9tzb6eRKzvrrYwy4dJJyJJxCD/d1rQNMiCUMTG+hkPWhgCF0K?=
 =?us-ascii?Q?7Y0Hb7hUGkHE9T2wzbluvfbuF0re837SaRHiikKUdoioFGYgZo+IDIsGxuFm?=
 =?us-ascii?Q?CRqqJSgOeAw1ZzzvBiQT+eDk3w03yqulEoqyESZEPgZasG6SyfM2srzif1nl?=
 =?us-ascii?Q?tZm+/nD2OBqhxJC5tpNEH2oHx7xqVeqYGd+Xb9sCSMFxVYXx9txUOpyr8Jey?=
 =?us-ascii?Q?xlDNdcXNPMqafWU+Nlqs3rwr7J/i5kEO+giIoanBfcip6Kt6vj3gvrnYQF4y?=
 =?us-ascii?Q?yTk0ieWeJ9cSiOKmYwHuG7j6UeHdAD/fuFgXTGRTYVpCy329o0qrwuj43qSJ?=
 =?us-ascii?Q?46tyhT8oZZ6NruoZfKoD+4l8eg1tzxL9LGS/dm0eEHgYCvTIf9juetz6OT1B?=
 =?us-ascii?Q?VLacXdjDUjHjzaLHdr3NsdbANRuCPdAj7nqVy1kdvmFo8+Rzhmn7RgA9XAXP?=
 =?us-ascii?Q?Yte2e7LeNzYHp/sp6HHwL6BwqY47XwN/V0d5IWvmGLvTWABTk5vHqElVIT5D?=
 =?us-ascii?Q?hwaeWFXsBf0tWZmnm/fq+Urx8MBciX69tya072ikOnn82ZCcBR7HkoH0af/6?=
 =?us-ascii?Q?pDOS4+oiW8yO9juF1wiqhQCc2mMEG162fRRRvLvNigNHRUy3DsWNj3RZQiuW?=
 =?us-ascii?Q?Eb4kn3JGg9KFfeKU28MW38JvikeP1tDymRnlCTnojTKKw4g0xA5EV6SIPurk?=
 =?us-ascii?Q?PIjgPT4YEk/tAW3Tg0bnHozF7yJkw5Ngu+GvYR/PBNx+HKpI3jYLPC6MGdBy?=
 =?us-ascii?Q?wcb1t9QsOqd6p5RXup5kwcq9cgtGzXib4vYUX/uMNTNChzHb86xtkD/lVdWz?=
 =?us-ascii?Q?SVv1nnXGdcf3fo0/GXNc+ro2/LulvWZaQqkxtVjzLXOfmktLQ3VaKfCzF3Zb?=
 =?us-ascii?Q?PtQTMue7mGZEqHx5QlJ88dIYmyd/P2nyB2dZh1iilwunwrTTVXAWo5+iQLv/?=
 =?us-ascii?Q?32XgZIS42pySAmi+pjJJa15zNmpEQ67EvQ2dBCLD3Sb8TA/VX+DYpKAYnFzM?=
 =?us-ascii?Q?FCKFyVYyCeFac9ik8DyTDFdqExrmkCZM3SzshkeDl7Goqi1p7F1E4HSwt7WO?=
 =?us-ascii?Q?/VoptA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 659ab332-5977-477a-17d9-08db20b598c3
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 15:47:32.9961
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4NWLVzMQ65NvE8E3O2JOrxqyqJHGvlHrn1afBw4oY9fJvOmEygOKh4dipkHmJi9VnPCVrOUvWsVunZdB2EppjmitZR7aT6F7LXJfFS3B7r4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5310
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 09, 2023 at 12:01:11PM +0200, Radu Pirea (OSS) wrote:
> According to the TJA1103 user manual, the bit for the reversed role in MII
> or RMII modes is bit 4.
> 
> Cc: <stable@vger.kernel.org> # 5.15+

I think this should include:

Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103")

> Signed-off-by: Radu Pirea (OSS) <radu-nicolae.pirea@oss.nxp.com>
> ---
>  drivers/net/phy/nxp-c45-tja11xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
> index 047c581457e3..5813b07242ce 100644
> --- a/drivers/net/phy/nxp-c45-tja11xx.c
> +++ b/drivers/net/phy/nxp-c45-tja11xx.c
> @@ -79,7 +79,7 @@
>  #define SGMII_ABILITY			BIT(0)
>  
>  #define VEND1_MII_BASIC_CONFIG		0xAFC6
> -#define MII_BASIC_CONFIG_REV		BIT(8)
> +#define MII_BASIC_CONFIG_REV		BIT(4)
>  #define MII_BASIC_CONFIG_SGMII		0x9
>  #define MII_BASIC_CONFIG_RGMII		0x7
>  #define MII_BASIC_CONFIG_RMII		0x5
> -- 
> 2.34.1
>