Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Thu, 9 Mar 2023 08:13:18 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Jani Nikula <jani.nikula@intel.com>
Cc:     linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
        linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: constify struct hwmon_chip_info info member harder
Message-ID: <2f0a6217-3747-4493-90e6-8fb129cb6a34@roeck-us.net>
References: <20230309082841.400118-1-jani.nikula@intel.com>
 <e0579cbe-cbd6-46cf-b425-234cfed4ff00@roeck-us.net>
 <87h6uu9nxn.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87h6uu9nxn.fsf@intel.com>
Precedence: bulk

On Thu, Mar 09, 2023 at 01:14:28PM +0200, Jani Nikula wrote:
> On Thu, 09 Mar 2023, Guenter Roeck <linux@roeck-us.net> wrote:
> > On Thu, Mar 09, 2023 at 10:28:41AM +0200, Jani Nikula wrote:
> >> Let the struct hwmon_chip_info info member be a pointer to a const array
> >> of const pointers, rather than mutable array of const pointers.
> >> 
> >> Cc: Jean Delvare <jdelvare@suse.com>
> >> Cc: Guenter Roeck <linux@roeck-us.net>
> >> Cc: linux-hwmon@vger.kernel.org
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >>  include/linux/hwmon.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
> >> index c1b62384b6ee..492dd27a5dd8 100644
> >> --- a/include/linux/hwmon.h
> >> +++ b/include/linux/hwmon.h
> >> @@ -430,7 +430,7 @@ struct hwmon_channel_info {
> >>   */
> >>  struct hwmon_chip_info {
> >>  	const struct hwmon_ops *ops;
> >> -	const struct hwmon_channel_info **info;
> >> +	const struct hwmon_channel_info * const *info;
> >
> > As pointed out by 0-day, you's also have to change each
> > instance where this is is assigned to another variable.
> 
> Ah, sorry, I had THERMAL_OF=n.
> 

You also didn't test compile drivers/hwmon/hwmon.c.
I had wondered about that, and 0-day now confirmed it.

Guenter

> BR,
> Jani.
> 
> 
> >
> > Guenter
> >
> >>  };
> >>  
> >>  /* hwmon_device_register() is deprecated */
> >> -- 
> >> 2.39.1
> >> 
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center