Date:   Thu, 9 Mar 2023 17:15:42 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Nick Alcock <nick.alcock@oracle.com>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH 10/17] tty: remove MODULE_LICENSE in non-modules
Message-ID: <ZAoGLhRpTr5f7AD/@kroah.com>
References: <20230302211759.30135-1-nick.alcock@oracle.com>
 <20230302211759.30135-11-nick.alcock@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230302211759.30135-11-nick.alcock@oracle.com>
Precedence: bulk

On Thu, Mar 02, 2023 at 09:17:52PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> ---
>  drivers/tty/n_null.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/n_null.c b/drivers/tty/n_null.c
> index f913b665af725..c24f75942c49d 100644
> --- a/drivers/tty/n_null.c
> +++ b/drivers/tty/n_null.c
> @@ -63,7 +63,6 @@ static void __exit n_null_exit(void)
>  module_init(n_null_init);
>  module_exit(n_null_exit);
>  
> -MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Alan Cox");
>  MODULE_ALIAS_LDISC(N_NULL);
>  MODULE_DESCRIPTION("Null ldisc driver");
> -- 
> 2.39.1.268.g9de2f9a303
> 

Nope, sorry, this is not good to do, please fix kbuild instead of
forcing a tree-wide change like this.

thanks,

greg k-h