Date:   Thu, 9 Mar 2023 19:10:25 +0300
From:   Fedor Pchelkin <pchelkin@ispras.ru>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Minsuk Kang <linuxlovemin@yonsei.ac.kr>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org,
        syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com
Subject: Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly
Message-ID: <20230309161025.bfezdhoazzirykbr@fpc>
References: <20230306214838.237801-1-pchelkin@ispras.ru>
 <ZAdcGkqnfRDwJq5y@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZAdcGkqnfRDwJq5y@corigine.com>
Precedence: bulk

On Tue, Mar 07, 2023 at 04:45:30PM +0100, Simon Horman wrote:
> 
> nit: This doesn't follow reverse xmas tree ordering - longest to shortest line.
>      It's probably not worth respinning, but I expect the preferred
>      approach is (*completely untested!*)
> 
> 	...
> 	struct pn533_out_arg arg;
> 	...
> 
> 	arg.phy = phy;
> 

That is much prettier, thanks for advice!

BTW, is reverse xmas tree ordering considered to be a general
recommendation for all new kernel patches?