Message-ID: <feee2aad-6834-da69-a154-c1e0e21d12b7@intel.com>
Date:   Thu, 9 Mar 2023 17:30:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] xsk: Add missing overflow check in xdp_umem_reg
Content-Language: en-US
To:     Kal Cutter Conley <kal.conley@dectris.com>
CC:     =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230307172306.786657-1-kal.conley@dectris.com>
 <20230308105130.1113833-1-kal.conley@dectris.com>
 <4ddd3fe4-ed3c-495e-077c-1ac737488084@intel.com>
 <CAHApi-=C3ym23bBQ2h8BOyOfUtYXs9eZNG0Z8G2zfPeaEQWeRg@mail.gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <CAHApi-=C3ym23bBQ2h8BOyOfUtYXs9eZNG0Z8G2zfPeaEQWeRg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkRjL3FWeXRNNDBZK25uSUgxOXFkbGo3WXZrOTExN3Q1RHlwZEtONVRTbkxj?=
 =?utf-8?B?NkFFSzVoVExBNFV1SlJQeTg3UG1hTmltSGhxQitFU1ZLTkhRZ2NIdzgxcXNE?=
 =?utf-8?B?RmdzRW15dDBGK3lRUVhva3ZVZ3MzRXFjV2ROMlVtaEZGeElNQ3o1VVFVUFBR?=
 =?utf-8?B?WHhzNXpQMVcyNVRQd0VFSG45K0h4RnZ1dGt5Z1RaTUNWQkZ6ZWpKclIrQWdO?=
 =?utf-8?B?dzBIaFZOTUE3OWg0ai90N3VzWWVQeTZQZDVJSkoxaWpPRnlWVDR3dzJTQ09y?=
 =?utf-8?B?UUlXNFNhSGZxOHg3M2E4SS9zS3FzSlJHTktVa2FGczZ0YVg1cWE0KzVFK3c5?=
 =?utf-8?B?RUdEQ0huTkpYSWIzSThDTmh2Z0FZYmQzaTUyQUZwazBZRElpdGxoc3pnMkFW?=
 =?utf-8?B?cjZxSUZLVUprY0xrakIwUVE4WWF5cE9tb0lGWHQvdXl4TXJ5cjZWcW5mQ2lq?=
 =?utf-8?B?RlB6dHNyWDI2aUJoWUZFTzVIL1hobi94RXV0REliRGJibnNBZWNEYkF0UnMv?=
 =?utf-8?B?b0REYjVYdzY1UGtSanhuZk80R2E4ZXIvZWwycVBKQU1nYzJ4VUVsOWxtK0N2?=
 =?utf-8?B?MjNaeGQxTnJOK0lZY1I2MUdOL2kxcDM1NEViKzVRZ245VENwbUlpV25OV1Vv?=
 =?utf-8?B?Q2U0K0drZzd3R3hZSm53RlB1dDJLeVJ6VUZuZ1ZLQjNMZEY0U1lRK1dHZE1q?=
 =?utf-8?B?UzBZYUhRWE16ejF0N3NIaXMvK0VYd0JlblFZU29iTXhLWWUwNUcrczM5YXl2?=
 =?utf-8?B?Z3FUTjBCUTRwTFhjSUJlYzBNUzJDU2NCMFpIK1FxQzhFQndZMHg2U2d0Q2VC?=
 =?utf-8?B?djhBNFV6dHY1dmhaYXczMXRnaWMvOXhjQWZxejJTZmQzNmRZRjVGMW52OGRk?=
 =?utf-8?B?c1RQY3V5YUd5V1kvSFVwaDRJVHBtL0lMeWFpWDVjeElDWDZuSzlCZExmMG5J?=
 =?utf-8?B?RjNFbWxHVlFzMlBROXpYb2JKVmVjMDFWaTRJNG1RTlZiR3JCREIwMkU2YTY2?=
 =?utf-8?B?WUhOSDQ3WGtlaHlyNmhWU2ZBSWJGSHVVcGkxY0gxRFJIOGxuYVBCZDJrQkha?=
 =?utf-8?B?MW11RGRxRDVCbWVyZUZrS2F6V3ZPM1NHRDRjTUJ2Y1oyTmh0K1NGWFJyc1JK?=
 =?utf-8?B?OTg1WHJmUFBaZU5paGUzRUtWZ2tqOE9LSmc0SDE0UEJHdGdNc25IU3RJa0px?=
 =?utf-8?B?NjN6KzhDRUJZOTEwYWxiT1lramVDa0oxMno3MHlKUjc5M2NCbFp1M09MckRS?=
 =?utf-8?B?L2tGUFpqVVVEc2JxV0hzaCtuL2Rvb1RHQ3J4Wk8yeUNSZEZGOVNWSytvbHJt?=
 =?utf-8?B?dzNqUGtoY1Z2a2xLWUtPN0FxV3FKdmNBYkMrcXp0eGJ0TU1IcVRQcU5jcE1U?=
 =?utf-8?B?SXdKMFlDQVpkWlJTMHN0bEtkZUtuellLUlFMKzdzY3cxNm1lQzNXcjZPOVJp?=
 =?utf-8?B?MEdOYWJYelRoWXJZMEZ0Zk5pZi9NVUxwUGVkV2NMc1c2VkZzRkM1Y2JFTjRa?=
 =?utf-8?B?VU5haStDS1VoZ00ySTJ0T2Yyb3dKa2xXU0pVNC9VUDFGNEJNL1drZmRJazJT?=
 =?utf-8?B?S1lmSS92aEF4V3pTVSt0dzduVjJ3Z1VudWgvQXlyMVpCeW45cDdKTkRnNWJu?=
 =?utf-8?B?L1N3ckI2VXJEbmppRnZ5eHpwRWlYREtjN2lBTkk5RVVNdy9VVWtmemVseWJr?=
 =?utf-8?B?eVcvVUk5aXRENWFVRFlPbEdtcnRJdzRoYldEaGJ0bHl6b2FtRzNQdGpXN0py?=
 =?utf-8?B?aGwrNXZRZjE5akRMa3FrY0FSZk0rMW1HUzJ2Unkwc2RoQVFHQlBYa2hZY3Vo?=
 =?utf-8?B?dUpSWG82UXUzUThzeFFJdWJFZXNXR1RIRlFhRXBUMk95dkRRWGgydUptZitR?=
 =?utf-8?B?WGpBY1N5bm5GQkZnT0d6VFA2T2ZydHd4Ykl0R3Y5SkNRdXUxVjlKYzZXY09M?=
 =?utf-8?B?R1lHVy8vNHFYeE4vZVJwWEVEZHF0TGxXSG0yWHNoa21uKy9HUHIyVEY5d0FL?=
 =?utf-8?B?Mlo5b0VJSjh3ajYxM3ZUanpKNGtSUTIyYnBXeWVtS0djNG5Wai9qc1kxMTlR?=
 =?utf-8?B?MGJQUVVPL3dGS2FreE0xRUFSWEZ0V3dWeXVVbFU5NmIva3VFN0J0SDlLZGpZ?=
 =?utf-8?B?QStqNVE2VSt1cjIzUFJwVXVicCtncHE2OVJtTTdKNStVVGloZ0N1eEp3VU41?=
 =?utf-8?Q?v+fbhqbpSzGc8EHz+npH3EY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f6b59850-fe04-4c8a-5914-08db20bbc6f5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 16:31:47.4654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9fSJvM81Xo0D7UX3dXIv8yt/YBIkTaSITrZRwfXdZUJgXPLA0G73GaM9A2ZXU3EIiA5RRNzjcLa1bmwKGkr2qKoZcvrXxUrna3ylHOuHY2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7205
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Kal Conley <kal.conley@dectris.com>
Date: Wed, 8 Mar 2023 19:49:29 +0100

>> The code is fine to me.
>> Please resubmit with the fixed subject and expanded commit message.
>> I'd also prefer that you sent v3 as a separate mail, *not* as a reply to
>> this thread.
> 
> Done. I used "bpf" in the subject as you suggested, however I am a bit
> confused by this. Should changes under net/xdp generally use "bpf" in
> the subject?

"bpf" when it's a fix (better to have some real repro, otherwise purely
hypothetical fix can be considered a bpf-next material), "bpf-next" when
it's an improvement / new stuff etc.

Also please don't forget to manually add all the folks who reviewed your
previous versions / were participating in the threads for previous
versions, otherwise they can miss the fact that you posted a new revision.

> 
> Thanks,
> Kal

Thanks,
Olek