Message-ID: <e9996b21-c33c-d5af-32c1-abf6dc89b04b@intel.com>
Date:   Thu, 9 Mar 2023 17:33:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH RESEND net-next v4 0/4] net/mlx5e: Add GBP VxLAN HW
 offload support
Content-Language: en-US
To:     Simon Horman <simon.horman@corigine.com>
CC:     Gavin Li <gavinl@nvidia.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <roopa@nvidia.com>, <eng.alaamohamedsoliman.am@gmail.com>,
        <bigeasy@linutronix.de>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <gavi@nvidia.com>,
        <roid@nvidia.com>, <maord@nvidia.com>, <saeedm@nvidia.com>
References: <20230306030302.224414-1-gavinl@nvidia.com>
 <d086da44-5027-4b43-bd04-29e030e7eac7@intel.com>
 <1abaf06a-83fb-8865-4a6e-c6a806cce421@nvidia.com>
 <7612377e-1dd0-1350-feb3-3a737710c261@intel.com>
 <3ed82f97-3f92-8f61-d297-8162aaf823c6@nvidia.com>
 <531bac44-23ba-d4f3-f350-8146b6fb063a@intel.com>
 <ZAjsa538mpnEQ/QI@corigine.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ZAjsa538mpnEQ/QI@corigine.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alNOYXJBSmhiaWc4b1NZaWtOZ284dDZoQmYvSEFaR3VZbTh0S2RkSGZteGdp?=
 =?utf-8?B?cWNvL0ZZd2lNbE1iRnJzTStPTmJZM0RzNWk3dTR5RlBFR1ZGOVBOZ2EvNE1V?=
 =?utf-8?B?UWZqSGxsenJIbVdwRm9lRXp2bms2UlVUOW1TVDZ2T0NwTk5uYUhpMGhtUnhh?=
 =?utf-8?B?Y0xQMEl0VVhXVXJKU0JEeFlNcGFocmdaekR1K0pzbHVFSGpJWS9NTTBmTkNF?=
 =?utf-8?B?UmJrK0x0MEJFSUxSZmdVbWNtTG82Q0tGZkxRYnE1MnIyeUY5WGN6c3NLZ2hE?=
 =?utf-8?B?STYvQjEwekx5SWpwYTQwOGtqWmJsNjQ4UjZuV0svWEtqNDdZV2E4TWZXcUVq?=
 =?utf-8?B?VkV1UTk5a1czc1EwK2RDYklLbjFkNDNzYWh2blQyTXlmbTJvU09MRy9IM25Y?=
 =?utf-8?B?aS8wMy8rajA4cStJOVlSK09ZdHo0SFBlNWVWODlRU3lzdnRsdDdYNjF1dklm?=
 =?utf-8?B?ZHp3bVBHRG5KL0Y1d0dFa1NxTjE0dkdBNkEyMURDeTdES1VJbmNkWWlHa09X?=
 =?utf-8?B?LzNtem1jUjhacmQ1ZWRtLzZTVEdmc0Vkd0Z5UHlwcEdRTU5qUTB5cHFsbkZK?=
 =?utf-8?B?ZEVMNldDc1A1RWkrUHFkQnYwZENiTDNNR0xwbHhNR2ZkNTB1eFFFUVN3VmRU?=
 =?utf-8?B?ZU93VGZVbDJDbXFHQm5FWmFBQzFscWo2WVFFWUdFMkRrdXhpSytyTEU1WXln?=
 =?utf-8?B?MTE2Zy9ZVit2bkpsUmRwZG92L0dCVHFJUGYyL2llMlM1UmNvaURLN21yNXNT?=
 =?utf-8?B?MmJrZE5wTnRCbG5XT0N2SDZIaUNVQkh0NW1Hek4xanRKek84ZEpmaU5SV0VR?=
 =?utf-8?B?L2FOTVJyZzlLQTdRYzU0dXZqWTN2QXIrd09na1dMVm1sUyt5V2FLNmkvdk9v?=
 =?utf-8?B?czJ6cnlLSy9ycGZxRk1vTm0vWnVrT1g2NTJwaHh6c1VFZmtoOTcwblpJTlNJ?=
 =?utf-8?B?RVh6ZWp0ZGVVb1padHJhTTJVRzQ2emRMV2hvUWlKOXRKWUFJQjQzRVoybTBI?=
 =?utf-8?B?emVZYXJCREh0RzVRV2s2VUszUkdUYkdPUUNKNWZkbWoweVh1bkFFNGYyMEpY?=
 =?utf-8?B?c1JRWnZTTGRwSTF6cFQ5QTBWbEh4c2ovNGd0czhPWTVla0huWEtEejgwUXVh?=
 =?utf-8?B?anh2dHNHWVBTV2xOMXNTWmUrTVk0Uyt5MCtpZWlNUjdKSFlLTWdBMy9UTzV6?=
 =?utf-8?B?dE13YlBkZFpBcU9aUnlCeWJGWjAxMW1uM3l6ZG9uQUxUUDQzUHhLVUpMZ1BN?=
 =?utf-8?B?WkRHYW5aOHJ1dnpMcGZXU1pBZSt1VHZrWGZqNlRkR2VXc3ZqaFNEUi9OQmZG?=
 =?utf-8?B?bzZyL3JGTXFTUGFnaVJjRGNZak9kWGFBelZHTzh4ZmtHclNidWUvU29IRUVX?=
 =?utf-8?B?VHh2M3hqNy9iZGllbG9TWHI2YTBobnFsVVQxZDUvZWpwaFhYeGc5TzVpMzVj?=
 =?utf-8?B?d0JGMXNnWEMvZ0FZYzkraWlZaDg5ODR2ZktkNUxRTmRreTZwMkwwQWJ1bkU2?=
 =?utf-8?B?SDNWMWhBUXM3QXA4dUVWcHRRMlNBT1lVUUJVL3BJTTRNK0granZ2MVFsa3U3?=
 =?utf-8?B?YU9tR0pSb1ZmWkVFNlAzTW5lVlVpUndGWlY5V0RWNVN6bklsZHBuVW1wU1ZY?=
 =?utf-8?B?UTZUL2lTdVF1cHduaSt5SXBLKzZUczJTMnB0MTU0akY5a05zdmMwSVhGK0xt?=
 =?utf-8?B?T1NPcWRwUjcxd2JoejgwK1RzVUFTbnFXWUJOdmJLaU5WL3NmT0dETDFPKzda?=
 =?utf-8?B?YWUvZ0pSQzJUMStGejFJOFpEOUovQ2JVYmgwNHdGeWdrd2tFSDdwZjNTZ0FI?=
 =?utf-8?B?UWlzYmVUTFJuVW5xS0IrdWVRd09yTmNxbGlvQy8ydXlkSHBGN0ZYNGFiWHAr?=
 =?utf-8?B?eVRGeXpDcDc4RWlYK3V4UnB6YUxHMkRuQ3k5SmR5STBHOEc3SkVzbWg0aytF?=
 =?utf-8?B?VTNCMkZHMldLVVBWSFdHaDl3dWt5dFE5b0xFa1J2dWovSEkrdXY4Q2xFM0Yw?=
 =?utf-8?B?SU5ET082THlLTkdrUithaks3andxaGtIVWk0K0FsSXBpZElCU2VueG5hamVn?=
 =?utf-8?B?SnpQRjJjRitxMWdBWUo4TWNoejFRTXduM09XMXVQMUxCQ3NLaDkxeG5iRGhK?=
 =?utf-8?B?ZlJNSWt0SHlUTUVDUGFnb2RxWTlsSk1pSXFUdUFZOGc1emlkTWJmWkhsM3pE?=
 =?utf-8?Q?kgheo2Jc1DUMDzdEe57TsXw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 83cccec7-bc26-45ad-481a-08db20bc1a80
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 16:34:07.6580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6FWjFGOV3DaLttRDCygETt1YgbADvYvTBODZXJshhMy1/oj4ntYgohuoD5gpu+RV3r0z3mkcn84BSfYg44ZotipTeU0M8KZYJeu/QPqreBw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6853
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Simon.horman@corigine.com <simon.horman@corigine.com>
Date: Wed, 8 Mar 2023 21:13:31 +0100

> On Wed, Mar 08, 2023 at 02:34:28PM +0100, Alexander Lobakin wrote:
>> From: Gavin Li <gavinl@nvidia.com>
>> Date: Wed, 8 Mar 2023 10:22:36 +0800

[...]

>>> Any comments, Simon?
>>>
>>> If both or you are OK with option #1, I'll follow.
> 
> I'd like suggest moving on from the who said what aspect of this conversation.
> Clearly there has been some misunderstanding. Let's move on.
> 
> Regarding the more technical topic of constness.
> Unless I am mistaken function in question looks like this:
> 
> static inline void *ip_tunnel_info_opts(const struct ip_tunnel_info *info)
> {
>      return info + 1;
> }
> 
> My view is that if the input is const, the output should be const;
> conversely, if the output is non-const then the input should be non-const.
> 
> It does seem to me that container_of_const has this property.
> And from that perspective may be the basis of a good solution.
> 
> This is my opinion. I do understand that others may have different opinions.

Mine is basically the very same :)

Thanks,
Olek