Date:   Thu, 9 Mar 2023 17:41:28 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Fedor Pchelkin <pchelkin@ispras.ru>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Minsuk Kang <linuxlovemin@yonsei.ac.kr>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org,
        syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com
Subject: Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly
Message-ID: <ZAoMOJFi9uXhEveK@corigine.com>
References: <20230306214838.237801-1-pchelkin@ispras.ru>
 <ZAdcGkqnfRDwJq5y@corigine.com>
 <20230309161025.bfezdhoazzirykbr@fpc>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230309161025.bfezdhoazzirykbr@fpc>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OAFXEG2/dXAB/5IlH24sNpWxDVv04OZ6C3ZfsmZfZwF9RTq9JF2Cu2+MR5h8?=
 =?us-ascii?Q?QsBB3EyAAi5fqdIKrHhpnTOO66/v9BpgDGosbpCwW/eX7c8VyZPc8zn8u27Z?=
 =?us-ascii?Q?9+itKS8AE6tcd4tXtcLnwNcR5RtbVSr1kNUxAJ005A0IAyQofCpUFYO0RpfU?=
 =?us-ascii?Q?K4VSB+W037PFoRmSgxCLKHQ1J8ZYUygTwvcYeQVVAqIdZgRBFvylb4JhQsKv?=
 =?us-ascii?Q?PewVOPMn5DqdULQgRFX52nxzf3yurnsgOjt9i7hzxaPtvPHHjAId7N9O1mQx?=
 =?us-ascii?Q?jPTQQghF3/njNSddaScjuFD1oxEyBlej6n2CKPSmPmjyzJGpcI/UgwIiGbL0?=
 =?us-ascii?Q?Rwu1nPDxVaDdzZ1o8VFF1cA06Av3ffMUmGy+yL1Q0dobQbAx/L9NBJJmNk2t?=
 =?us-ascii?Q?NRuLgpIBi7nVEoocnXhS6H5GoaaA9l2FBoN4apvz0cpJ0PLg0rg+WsRdCdn3?=
 =?us-ascii?Q?qzwzgYlKGPSFBnA4PnU23ky1xhbtrvmSPXu8lMQo/xhX9+/6d/s9ih/IdSem?=
 =?us-ascii?Q?IpDX3EmvbP17EzU56Fy5Deg9ZUrJBVhv3clmfCLd/1/1hHpIcLseYjWFAFLB?=
 =?us-ascii?Q?oRgY9F4nc26P6Zlpxrzd2stcRRM3iLVtzDGqRrEiwR7AUSEY4q6RQX2706S8?=
 =?us-ascii?Q?W6GVGGODklMmLkPqSp6FlhqfRFznNODBkYDcIRJAjBverZFEypU6djduO+0Q?=
 =?us-ascii?Q?t+OBXNqh/jCijD9hPLiJ5dOS6EY3pIQYkFxkAtaVPl/MezKXmg5xAKElwnhH?=
 =?us-ascii?Q?gG1MQcNINm0Eo6spIwMvrawg5NbcSqBFHBT29smJ1DwgMUgg7yYxRybteppZ?=
 =?us-ascii?Q?4x33RAViLTNINWClRLpXOCZoRU+n3dxa+BXtdKNS4cF7/6EYCIyw88eLeqf3?=
 =?us-ascii?Q?PJbCyBDihYiMca4CmAMyS9JQhCwNzzZ597+bXcUbjGdgQdI6cLHbsQJpv9Gu?=
 =?us-ascii?Q?fDaNsf21mTC2rt0/oYkL4dOtZDohQaeWN6aApD3n0Ro8vjugS5jEcV5arG/H?=
 =?us-ascii?Q?GGP1ugwX4HFBMHqFXMhUUJMaJmEFqeuLEy9kDB3xdasfSs6bZZy30vccvRPe?=
 =?us-ascii?Q?iriHmJA/jKdk5WL27Zsh9nIIeh3dHPUqxjUVHjPPzygBkCP5LlmcpNXD4FXw?=
 =?us-ascii?Q?kGflZYGXa6bDtdfV3WB3NCfXLyj0/qosPi2zRdvjC3J4eNL4VtBm8L567H/E?=
 =?us-ascii?Q?GrU1ZffbxOyY0LOYRaVDuq3Ue75gWbMXCfGzue6r8i9551r3ZT0/yoQGTwlT?=
 =?us-ascii?Q?BezBXTeyFzUK99zrN/fosxjoDHEhQSqz0pkFWsXdFUIE9u3O39eWzFHTz6hG?=
 =?us-ascii?Q?MinRz4iVpBPvGMtREc/YlfsTwmi5HEwFd+hgG3tXnGkQ3p4cST1Yp4+vVwH5?=
 =?us-ascii?Q?2yd3Kpa1yXmUiDrQ/UUsWc3opiJyKb0Zd6VN1S670VCEEz9RxoI6QoO2Qucm?=
 =?us-ascii?Q?KDY3gxaVJS7FPsdq7GnlHRBjaIDpN7qcr97ZLNHENxrqHjTHUR9GuxOFGX6z?=
 =?us-ascii?Q?5LBYK9qir1fKJMVw4Xy/Mu2s9l7Aer4/ECtxqujqJy+JcHuOJH7T4kD6lG97?=
 =?us-ascii?Q?CTIXv6y6h4/lor+7QgtFMQ1vDihW3MJteSrNvXYnDjyiROLoLhr3oJnCfqcZ?=
 =?us-ascii?Q?f++4ibSWYReICTOGFfHe3J+8ccqCOq4ysu4+QFpmZgTPgwZUr4v13mRVVSJz?=
 =?us-ascii?Q?H0zPBQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6e8ed7a-94de-4274-3fd7-08db20bd25fd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 16:41:36.2881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZEEPoCIAZO4epbQgH0ZifEIwtb1weFeZm1Fp8L4pmzwsH4yrp83M4LdRl/Pet45DH4swBPJSgsf6bDLdy7musfoptLeD8FmPHifjEp1H/lc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB5188
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 09, 2023 at 07:10:25PM +0300, Fedor Pchelkin wrote:
> On Tue, Mar 07, 2023 at 04:45:30PM +0100, Simon Horman wrote:
> > 
> > nit: This doesn't follow reverse xmas tree ordering - longest to shortest line.
> >      It's probably not worth respinning, but I expect the preferred
> >      approach is (*completely untested!*)
> > 
> > 	...
> > 	struct pn533_out_arg arg;
> > 	...
> > 
> > 	arg.phy = phy;
> > 
> 
> That is much prettier, thanks for advice!
> 
> BTW, is reverse xmas tree ordering considered to be a general
> recommendation for all new kernel patches?

I think that the situation is that some subsystem maintainers require it,
while other's do not. So no.