Message-ID: <5b34408d-8589-d735-9a77-a651ea661e01@suse.com>
Date:   Thu, 9 Mar 2023 18:30:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v4 2/5] gpio: Add support for Intel LJCA USB GPIO driver
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Oliver Neukum <oneukum@suse.com>
Cc:     Ye Xiang <xiang.ye@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org,
        srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        sakari.ailus@linux.intel.com, zhifeng.wang@intel.com,
        wentong.wu@intel.com, lixu.zhang@intel.com
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-3-xiang.ye@intel.com>
 <2865f3d0-428b-0df1-fc50-f6af3cb9dac3@suse.com>
 <ZAnku01goVDCuNM+@smile.fi.intel.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <ZAnku01goVDCuNM+@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2pVVDc3cFMxcDVycUswTVBmNXMwTWJ5dlpUQlNzU0FaQUJiRkdUS3kxVW1y?=
 =?utf-8?B?S3ViUVh0OWtwbWNJMTRUKzNUbElxd201cFg3azNHeVhQTUxlYUdKZFpiUWpF?=
 =?utf-8?B?ejZzUXFabVpZWW41SmxwN2F2QjJDdW91TTArR3Z3blFBN0k1ZzM4N2VVcUsv?=
 =?utf-8?B?OXkvcWRnS1ZDLzNvZzR1bW43UnEwRmJ3VWJodGdxbmZ5TDZ5Rk8rSnZzdGVy?=
 =?utf-8?B?UGlib2NtQzdyeE40RG5IRSsyN3NPTjRZK0xTZnVhMjNWRWltWjlCL251RlRN?=
 =?utf-8?B?M3NrSjdlK2diaUZ6eXpEaXl3dVhVSWpvcjF5cGFmd3VHQ005Yk93M01Ydzhw?=
 =?utf-8?B?Q3FlV3JuczlOYjk4cHowOEdhQ1B2SkxKTk9mNEw0QjdEMWx4RWR5dHhLbW9l?=
 =?utf-8?B?U3QzYU9vZlFNMmtLcE14QnB5dnR0RFd4SVYzcFZTbHVVU1BrSUNlbENjdU5I?=
 =?utf-8?B?cy9WQ2VHT2tkTEpTSTE2dktleUFiY0M3am94NWdJYzZvYWpRUVhaWW1GRlNW?=
 =?utf-8?B?RmxJMmJ5YjRZMmkrSnd2cXZZUWJxL1lMZzVJVnA1YWRjcjFpNjcrdmoyT29P?=
 =?utf-8?B?SWxmbTREcWRPL3RqR1VUblEyRkl1bHFObFoyMFZrcENjNExicGVKa2hTbmZS?=
 =?utf-8?B?bk9MR1F6aUtkQVJORnA3OHJrSy8vazYrSnBCNitqYlVzbGt0TUFmcnQzdGsx?=
 =?utf-8?B?dFQvUkN3d1YrVXVjS05xd01ZTEJsd0dVcEVBaWtLVkhPUFVkQ09Obk9OWmho?=
 =?utf-8?B?U0xTSlBpZzFRRmR4UDFENGpURk1Vb0pBendjWEszM2RHMlljS01TWHNuNjNU?=
 =?utf-8?B?S2YzcTFZQkNQaVJ3U09JVGtCbHZXdnd6M0ZrcTlJMGJLNzJIMVVKN0RPeVFG?=
 =?utf-8?B?dkVSYnFsa3dZS0Z2S0QvY0NsVmFYc2JmMzVHa1Zxb0NsdXpIUUdQOWRBTTNF?=
 =?utf-8?B?UUNWQkE5UEttT1gzYWtONzZjblBXQVVHc0srUnVDWnRFUHQxbzBNemFkeklv?=
 =?utf-8?B?eGNoTTQ5dHRXMWpkNFRkNG1yVGhEYVBxcytjenRMU2hPejBNOUl6MnRldmNP?=
 =?utf-8?B?L0N6a3NlTjg0KzFtaVVVU0tWTXB2SSthK1dtazhvWU1xZ3gxN04yY3hwTWo2?=
 =?utf-8?B?cmJIaUlsVjU2aUJoYmN3bkw5UHJtcWdrNDUrTjBlZHFWZXBXTzA4aGdGUGs4?=
 =?utf-8?B?dy9YS3A1Sm56OXRhSmxiZjN6R2NETEJib1NDbXNBUXFhYVRCaDVya01SdGVL?=
 =?utf-8?B?WFFaUS9UTk9IN2c5by9ENGxhM291cUhnNDFyU01UR3VxYXBEVk1mRFpKV2Q3?=
 =?utf-8?B?MUk0ZWQ3VjJ1NUovaGJTTTl3SjdtcVBsWFNlTWM1b1hKSnRJZUZ2bU5ML2Za?=
 =?utf-8?B?U0txc2s3VUZ4NGJJVEphWWVBYXQzOGJDdXpBSjRobHZIa3lTMHJ3V2pYc2gx?=
 =?utf-8?B?bmh2aGZid1NmalFCWWYrTWw1aXpSQWFGaXRvdHoyNHNNR21sN0RuOG1pTHZP?=
 =?utf-8?B?d0s2bllGV1dVRG93RTRMdlBSeWw4Y0RHdDBXWGZHY2VaRmF0YndCT1ByeTRq?=
 =?utf-8?B?MTQwNmdjbi9Ma2R3UnRiWHZ1RWRuVnd0aThSSnpKQXl1T0VNaVdEVjZYTURD?=
 =?utf-8?B?UCtQVTk5aVpBU0xzZzdWOWtzSWZwN25OZi9aYkROLzU0amdRTkM2WWIxZVpN?=
 =?utf-8?B?U01UMnRuRGZNeDVKUENVTXk5Q1QvUCt5MGN6N1NGRmtPZjlKaE1vQnNNOEhY?=
 =?utf-8?B?VlN5MTAxbCs5eEs2ZXpDVFhqQU9IS2hvdDFQUkUxVWxMNkh1Z2dmUStmTmN3?=
 =?utf-8?B?RUZJSTkrZ24wY1VsK3l6RTJTMVlrSWI4a2p4OWJvWjFzSTlGb1o4Q09OV2FQ?=
 =?utf-8?B?Si9ldWdkTEo0ZUJTSW1HVEt6c3BEVm4vNGlvS1cyS0hBeWs4eW12M2Z2ZkRY?=
 =?utf-8?B?TnVkVHFYQ3NqY2JSV3RySUM3eHRlOVprMHI4ZkxsL2xHcmREZ2JhcVJnM2cy?=
 =?utf-8?B?Zk9Bd09kUjBVR2ZkcFR3ZExnZnJNVHVwbjByOEorWXpIUjFJWkdoa3Nhdi9M?=
 =?utf-8?B?ZjBkY2V5UTB1dEtnZDZEN3E3am9pblJrNFNIdU1UYWQ5UHBwdFJnZ1NpbjZv?=
 =?utf-8?B?anQrRUFQZXI2STdQT2hzSzVmaWwyYndsdG1GWWJYQUU3b1RSa0tFMDZwL0No?=
 =?utf-8?Q?kW/p9+wUy0r4GtV+gvauYKJTvA6l1ViSwY6Ykp2aVjvP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea57979-9092-4d7c-75f7-08db20c40a68
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 17:30:56.6322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Me18N8AWNBa5PmzHR+TeBKtoV3i5dpWSlVlwM9wECiA3TO6hyVLTACmdwJ4SRN6GAZoq83ZvqCbK8HVJeIJo4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7993
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 09.03.23 14:52, Andy Shevchenko wrote:
> On Thu, Mar 09, 2023 at 02:40:10PM +0100, Oliver Neukum wrote:
>> On 09.03.23 08:10, Ye Xiang wrote:

>>> +	u8 obuf[LJCA_GPIO_BUF_SIZE];
>>> +	u8 ibuf[LJCA_GPIO_BUF_SIZE];
>>
>> And here we have a violation of DMA coherency rules.
>> Basically you cannot embed buffers into other data structures
>> if they can be subject to DMA.
> 
> Huh?!
> 
> The problem here is alignment. But other than that I can't see the issue with
> embedding into structures the instances of which will be allocated on the heap.


Hi,

These constraints are documented in dma-api-howto, but perhaps this
is inconvenient to read through.
  
Let me explain for the input case. On certain CPUs DMA does not
update CPU caches. Hence when you want to read data generated by DMA
you must read from RAM. Hence you invalidate the cache line with dma_map_*
operations.
Those cache lines must stay invalidated. If you wish to guarantee that,
you cannot access a data structure that shares a cache line with a buffer,
until you are sure that DMA is finished.

On the affected architectures kmalloc() makes sure that no allocation straddles
cache lines.

	Regards
		Oliver