Message-ID: <e75a1c0f-886e-fd89-0876-dc883f75c809@gmail.com>
Date:   Thu, 9 Mar 2023 11:07:03 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] serial: 8250_bcm7271: Fix arbitration handling
Content-Language: en-US
To:     Doug Berger <opendmb@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Al Cooper <alcooperx@gmail.com>
Cc:     Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230309190224.687380-1-opendmb@gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20230309190224.687380-1-opendmb@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/9/23 11:02, Doug Berger wrote:
> The arbitration of the UART DMA is mishandled for a few
> exceptional cases when probing and releasing the driver.
> 
> It is possible that the DMA register spaces are not defined in
> device tree for an instance of the driver, so attempts to access
> the registers in brcmuart_arbitration() would use NULL pointers.
> 
> It is also possible for the probe function to return an error
> while still holding the UART DMA. This would prevent the UART
> DMA from being claimed by an instance that could use it.
> 
> These errors are addressed by only releasing the UART DMA if it
> is held by this instance (i.e. priv->dma_enabled == 1) and
> directing early error paths in probe to this common release_dma
> handling.
> 
> Fixes: 41a469482de2 ("serial: 8250: Add new 8250-core based Broadcom STB driver")
> Signed-off-by: Doug Berger <opendmb@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian