Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 230C5C64EC4 for ; Thu, 9 Mar 2023 19:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbjCITOq (ORCPT ); Thu, 9 Mar 2023 14:14:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjCITOm (ORCPT ); Thu, 9 Mar 2023 14:14:42 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B16625CC35; Thu, 9 Mar 2023 11:14:40 -0800 (PST) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 329IQrD8029534; Thu, 9 Mar 2023 19:14:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=rI+P1BFFHZ8WHlaD0B4eoL0bauETBN0QF8emFVhth0M=; b=i99+IgE7wjS576YtStFzLcLDOcYm9iAedkU3ifBfYfMdRaOTh/TwHZ3hHT30TaBsr8si EpNK/Up5CPzkJ1DW5CBYTCbJUOjSA9nzLy0WUNVlOJA/GYAM1/eDPdtFbfdT7EZC0Mdm 90b5V/VTx1TqDnxltrFH4XVcAUip0xZxcqTs82xyOc4ka8tGmzeGUktR7Vymd+ByGuk9 0xqFJcqQuHIyQDxvEGoWi45UGRxf1LgdlkzL9SjHwjCoinpxz32usBgqU6an9zd+CVV1 WLsQHzmck742IbkK8NbZH3ccbZk2GoitzzeItNGR894lu5bb+J//aJSs4yxDQdK8Iccj 7A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3p6t3c3s65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Mar 2023 19:14:39 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 329In5ko021919; Thu, 9 Mar 2023 19:14:39 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3p6t3c3s60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Mar 2023 19:14:39 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 329I0JFb023609; Thu, 9 Mar 2023 19:14:38 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([9.208.130.98]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3p6fnwnk2p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Mar 2023 19:14:38 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 329JEauX12976752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Mar 2023 19:14:37 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C5A15805B; Thu, 9 Mar 2023 19:14:36 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8575858058; Thu, 9 Mar 2023 19:14:35 +0000 (GMT) Received: from [9.160.169.251] (unknown [9.160.169.251]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 9 Mar 2023 19:14:35 +0000 (GMT) Message-ID: <0eb3ed4d-24cc-a09d-b4e4-87764c949bef@linux.ibm.com> Date: Thu, 9 Mar 2023 14:14:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 3/4] s390/pci: remove redundant pci_bus_add_devices() on new bus Content-Language: en-US To: Niklas Schnelle , Bjorn Helgaas , Lukas Wunner Cc: Gerd Bayer , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20230306151014.60913-1-schnelle@linux.ibm.com> <20230306151014.60913-4-schnelle@linux.ibm.com> From: Matthew Rosato In-Reply-To: <20230306151014.60913-4-schnelle@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: E_kGx7VtsTE4uV7Gby1Nsbx2wbq35MAo X-Proofpoint-ORIG-GUID: 6iBS4zGxBqGjLHkOK1sSfxQ-1qsvwcaM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-09_10,2023-03-09_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303090153 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/6/23 10:10 AM, Niklas Schnelle wrote: > The pci_bus_add_devices() call in zpci_bus_create_pci_bus() is without > function since at this point no device could have been added to the > freshly created PCI bus. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Niklas Schnelle Reviewed-by: Matthew Rosato