Date:   Fri, 10 Mar 2023 03:58:22 +0800
From:   kernel test robot <lkp@intel.com>
To:     Huacai Chen <chenhuacai@loongson.cn>,
        Ard Biesheuvel <ardb@kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>
Cc:     oe-kbuild-all@lists.linux.dev, linux-efi@vger.kernel.org,
        loongarch@lists.linux.dev, Xuefeng Li <lixuefeng@loongson.cn>,
        Xuerui Wang <kernel@xen0n.name>, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH] efi/libstub: Call setup_graphics() before
 handle_kernel_image()
Message-ID: <202303100324.OOW0550T-lkp@intel.com>
References: <20230309060012.4189412-1-chenhuacai@loongson.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230309060012.4189412-1-chenhuacai@loongson.cn>
Precedence: bulk

Hi Huacai,

I love your patch! Perhaps something to improve:

[auto build test WARNING on efi/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/efi-libstub-Call-setup_graphics-before-handle_kernel_image/20230309-140124
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
patch link:    https://lore.kernel.org/r/20230309060012.4189412-1-chenhuacai%40loongson.cn
patch subject: [PATCH] efi/libstub: Call setup_graphics() before handle_kernel_image()
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230310/202303100324.OOW0550T-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/dcee55720c64cc096ee2f52200a6e72c9b968ce1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Huacai-Chen/efi-libstub-Call-setup_graphics-before-handle_kernel_image/20230309-140124
        git checkout dcee55720c64cc096ee2f52200a6e72c9b968ce1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/firmware/efi/libstub/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303100324.OOW0550T-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/efi/libstub/efi-stub-entry.c:8:21: warning: no previous prototype for 'setup_graphics' [-Wmissing-prototypes]
       8 | struct screen_info *setup_graphics(void)
         |                     ^~~~~~~~~~~~~~


vim +/setup_graphics +8 drivers/firmware/efi/libstub/efi-stub-entry.c

     7	
   > 8	struct screen_info *setup_graphics(void)
     9	{
    10		unsigned long size;
    11		efi_status_t status;
    12		efi_guid_t gop_proto = EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID;
    13		void **gop_handle = NULL;
    14		struct screen_info *si = NULL;
    15	
    16		size = 0;
    17		status = efi_bs_call(locate_handle, EFI_LOCATE_BY_PROTOCOL,
    18				     &gop_proto, NULL, &size, gop_handle);
    19		if (status == EFI_BUFFER_TOO_SMALL) {
    20			si = alloc_screen_info();
    21			if (!si)
    22				return NULL;
    23			status = efi_setup_gop(si, &gop_proto, size);
    24			if (status != EFI_SUCCESS) {
    25				free_screen_info(si);
    26				return NULL;
    27			}
    28		}
    29		return si;
    30	}
    31	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests