MIME-Version: 1.0
References: <20230209020916.6475-1-steev@kali.org> <20230209020916.6475-5-steev@kali.org>
 <ZAoWdR7mppnWclFr@hovoldconsulting.com>
In-Reply-To: <ZAoWdR7mppnWclFr@hovoldconsulting.com>
From:   Steev Klimaszewski <steev@kali.org>
Date:   Thu, 9 Mar 2023 14:07:58 -0600
Message-ID: <CAKXuJqgAbdALaRdcoSV+sXbGzwm6h54hZtG2rBobcGA9vyu50g@mail.gmail.com>
Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: thinkpad-x13s: Add bluetooth
To:     Johan Hovold <johan@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Sven Peter <sven@svenpeter.dev>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        Mark Pearson <markpearson@lenovo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 9, 2023 at 11:24=E2=80=AFAM Johan Hovold <johan@kernel.org> wro=
te:
>
> On Wed, Feb 08, 2023 at 08:09:16PM -0600, Steev Klimaszewski wrote:
> > The Lenovo Thinkpad X13s has a WCN6855 Bluetooth controller on uart2,
> > add this.
> >
> > Signed-off-by: Steev Klimaszewski <steev@kali.org>
> > Link: https://lore.kernel.org/r/20230207052829.3996-5-steev@kali.org
>
> This link should not be needed.
>
> Also, please update the patch Subject to use the following prefix:
>
>         arm64: dts: qcom: sc8280xp-x13s: ...
>

Yeah, that was me screwing up my  patch, will make those changes for v6

> > ---
> > Changes since v4:
> >  * Address Konrad's review comments.
> >
> > Changes since v3:
> >  * Add vreg_s1c
> >  * Add regulators and not dead code
> >  * Fix commit message changelog
> >
> > Changes since v2:
> >  * Remove dead code and add TODO comment
> >  * Make dtbs_check happy with the pin definitions
> >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 76 +++++++++++++++++++
> >  1 file changed, 76 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts=
 b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > index f936b020a71d..ad20cfb3a830 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > @@ -24,6 +24,8 @@ / {
> >       aliases {
> >               i2c4 =3D &i2c4;
> >               i2c21 =3D &i2c21;
> > +             serial0 =3D &uart17;
>
> This is an unrelated change that does not belong in this patch.
>
> > +             serial1 =3D &uart2;
> >       };
> >
> >       wcd938x: audio-codec {
> > @@ -297,6 +299,15 @@ pmc8280c-rpmh-regulators {
> >               qcom,pmic-id =3D "c";
> >               vdd-bob-supply =3D <&vreg_vph_pwr>;
> >
> > +             vreg_s1c: smps1 {
> > +                     regulator-name =3D "vreg_s1c";
> > +                     regulator-min-microvolt =3D <1880000>;
> > +                     regulator-max-microvolt =3D <1900000>;
> > +                     regulator-allowed-modes =3D <RPMH_REGULATOR_MODE_=
AUTO>,
> > +                                               <RPMH_REGULATOR_MODE_RE=
T>;
> > +                     regulator-allow-set-load;
>
> Don't you need to specify initial-mode as well?
>
> > +             };
> > +
> >               vreg_l1c: ldo1 {
> >                       regulator-name =3D "vreg_l1c";
> >                       regulator-min-microvolt =3D <1800000>;
> > @@ -712,6 +723,32 @@ &qup0 {
> >       status =3D "okay";
> >  };
> >
> > +&uart2 {
> > +     pinctrl-0 =3D <&uart2_state>;
> > +     pinctrl-names =3D "default";
> > +
> > +     status =3D "okay";
> > +
> > +     bluetooth {
> > +             compatible =3D "qcom,wcn6855-bt";
> > +
> > +             vddio-supply =3D <&vreg_s10b>;
> > +             vddbtcxmx-supply =3D <&vreg_s12b>;
> > +             vddrfacmn-supply =3D <&vreg_s12b>;
> > +             vddrfa0p8-supply =3D <&vreg_s12b>;
> > +             vddrfa1p2-supply =3D <&vreg_s11b>;
> > +             vddrfa1p7-supply =3D <&vreg_s1c>;
> > +
> > +             max-speed =3D <3200000>;
> > +
> > +             enable-gpios =3D <&tlmm 133 GPIO_ACTIVE_HIGH>;
> > +             swctrl-gpios =3D <&tlmm 132 GPIO_ACTIVE_HIGH>;
> > +
> > +             pinctrl-0 =3D <&bt_en>;
> > +             pinctrl-names =3D "default";
> > +     };
> > +};
> > +
> >  &qup1 {
> >       status =3D "okay";
> >  };
> > @@ -720,6 +757,11 @@ &qup2 {
> >       status =3D "okay";
> >  };
> >
> > +&uart17 {
> > +     compatible =3D "qcom,geni-debug-uart";
> > +     status =3D "okay";
> > +};
>
> This bit does not belong here either. We don't have any means of
> accessing the debug uart on the X13s so we should probably just leave it
> disabled.
>

Will drop it (and the above one as well)

> > +
> >  &remoteproc_adsp {
> >       firmware-name =3D "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
> >
> > @@ -980,6 +1022,19 @@ hastings_reg_en: hastings-reg-en-state {
> >  &tlmm {
> >       gpio-reserved-ranges =3D <70 2>, <74 6>, <83 4>, <125 2>, <128 2>=
, <154 7>;
> >
> > +     bt_en: bt-en-state {
>
> As you are configuring more than one pin, please rename this as:
>
>         bt_default: bt-default-state
>
> > +             hstp-sw-ctrl-pins {
> > +                     pins =3D "gpio132";
> > +                     function =3D "gpio";
>
> You should define the bias configuration as well. I guess we need to
> keep the default pull-down enabled.
>
> > +             };
> > +
> > +             hstp-bt-en-pins {
> > +                     pins =3D "gpio133";
> > +                     function =3D "gpio";
> > +                     drive-strength =3D <16>;
>
> bias-disable?
>
> > +             };
> > +     };
> > +
> >       edp_reg_en: edp-reg-en-state {
> >               pins =3D "gpio25";
> >               function =3D "gpio";
> > @@ -1001,6 +1056,27 @@ i2c4_default: i2c4-default-state {
> >               bias-disable;
> >       };
> >
> > +     uart2_state: uart2-state {
>
> Rename this one too:
>
>         uart2_default: uart2-default-state
>
> > +             cts-pins {
> > +                     pins =3D "gpio122";
>
> This should be gpio121 (gpio122 is rts).
>

You are right that it should be... however... if I actually set it to
be 121.... bluetooth doesn't actually come up/work?

> > +                     function =3D "qup2";
> > +                     bias-disable;
>
> Don't we need a pull-down on this one to avoid a floating input when the
> module is powered down?
>
Maybe?  I don't have access to the schematics or anything so I was
going with the best guess based on what worked by poking and prodding.
Will try this.


> > +             };
> > +
> > +             rts-tx-pins {
>
> Please split this in two nodes.
>
> > +                     pins =3D "gpio122", "gpio123";
> > +                     function =3D "qup2";
> > +                     drive-strength =3D <2>;
> > +                     bias-disable;
> > +             };
> > +
> > +             rx-pins {
> > +                     pins =3D "gpio124";
> > +                     function =3D "qup2";
> > +                     bias-pull-up;
> > +             };
> > +     };
> > +
> >       i2c21_default: i2c21-default-state {
> >               pins =3D "gpio81", "gpio82";
> >               function =3D "qup21";
>
> Johan