Message-ID: <59919b84-d07a-4c62-3f34-febd85176375@amd.com>
Date:   Thu, 9 Mar 2023 12:30:16 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:110.0)
 Gecko/20100101 Thunderbird/110.0
Subject: Re: [PATCH v4 1/5] mailbox: zynqmp: fix counts of child nodes
To:     Michal Simek <michal.simek@amd.com>, andersson@kernel.org,
        mathieu.poirier@linaro.org, jaswinder.singh@linaro.org,
        ben.levinsky@amd.com, shubhrajyoti.datta@amd.com
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-remoteproc@vger.kernel.org
References: <20230228210216.447373-1-tanmay.shah@amd.com>
 <20230228210216.447373-2-tanmay.shah@amd.com>
 <d410d181-a94b-40e3-5c3c-50625fbb0196@amd.com>
Content-Language: en-US
From:   Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <d410d181-a94b-40e3-5c3c-50625fbb0196@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vk1DSXBIc0Y4VSthVitkT0VLbnFUMjBUalQ5ZjVqNFFDU1ZQWnpOeWV1YTA4?=
 =?utf-8?B?cVhmdHpFRFBGUk5TZDk3SHI2dG9FY2x0azFZTGpraFMzbmlXR2J4NmlacjdK?=
 =?utf-8?B?ejEvVGRxajNIZytWWDNadFZoandTVUplWWJ1UmlIc2tHY2NBa2VxYkhVUEdO?=
 =?utf-8?B?K0hod3h5OWJxaU5CSmtoMUVqL0FYQzArcDBYY1ZoU2U3dkRORk8ybitWQko5?=
 =?utf-8?B?Mmh1RHlpeVUzY29RaW1EeFpSempaRVJIUGpvVEZlcjg1enFRTUZYNlNJYlpp?=
 =?utf-8?B?WDRIaUxQNkRKMUczWlpEczlwc1RzbkF1Mnd2czkyWEpnQ3Z2V0VlbkQyWEVo?=
 =?utf-8?B?UVZwYzFvTVdJWkJwNE9rUTE1dm91SVlLMVNKU2JSMnJOY2FybnJNaGZLVVRj?=
 =?utf-8?B?SlZudHdDdzlQVk93TC9hMEpqa0VKRmZqUzRxNnBNSHBpdVJzZjRieDgrQWdk?=
 =?utf-8?B?N3dobEhBTzc1MGZ5d0o3VTdkcjd4bVprM0xTSDRKMmhpakJYVld5SlFSY2Ra?=
 =?utf-8?B?cUtlT3M4ZTRFVmg0eWpmU3NOYUtEUEw5cEt1UjB6M2s0Q3ZtWkJvdlV3ZE94?=
 =?utf-8?B?eWdYZWx2bnNFVmp2c1dRVXFQeXMzQi9jM0FtMFdQWjBvZHlHRmxkUUs2QjlQ?=
 =?utf-8?B?bm4zZmsrU3lBbHNBUlpoRnBEeTRxTVpvYUZzOG00b2tOWkFtWnZUL3pXOHZ0?=
 =?utf-8?B?K1Urc04zZmZtSC9iWlhGUVdteE1wWXg2VkErVkRNdXF5bU15b1R4ZGxNT29W?=
 =?utf-8?B?allJMlpxRXpHMGZCWEdMelBycGsydVczNDZvZ0tMUWZLdzlkR21ObGxDR2J2?=
 =?utf-8?B?bCszbTBNaGFSRG8wTUxBNldXUGhBaDRFc2JPQTM0ZnpadVA4NG80TDRIMy9S?=
 =?utf-8?B?OGVIeWhreEFUdWFPY2dUcVJncWxRdXZvcnhDY3IraXE2dzd1Z3Zqdzh3VVA3?=
 =?utf-8?B?QlpiQmpaaGd1QmVuWDNmK2lpZU95RWQ3ZWh5RHNBeTlqTnI0TURwV3Z6UklR?=
 =?utf-8?B?UnF3WE00VGE2ZEE4NUUyRURMc05qYjF2dmNYRVVJdTRCcnZaZjF5K0pOZ3Yy?=
 =?utf-8?B?dlEyZjdjUUxpZ0EvOEFhb29TYklwSVRISGpXODVpSTgwaVlNV2xFZER5LzZm?=
 =?utf-8?B?MTU2RVZsR3VmcDR3aTc4U0k1MkRpbEowcVFvenI4TXJ2M1E3c3dQa1ZTdXVI?=
 =?utf-8?B?eFplZGRoNlBoL0NpSmZUMVExM0tLTWRNNi9SOW9MUFA0NjREdUFCN1JNU3Fq?=
 =?utf-8?B?T0ZDdWxDOEF5RHFNeWpGYW85Ni9jYUs5ZWM4aHJYWWlSL092RGp2Q0RqR1ZB?=
 =?utf-8?B?WXZtbFg3T3BVSUdMQWVKYXZiMlBCcWcyNXdtUVNGZjZaQ0F6VXVDU25Tc0tl?=
 =?utf-8?B?eE9oNlpEa3pkVzMvTHJIczFyUFZmQ1lZcTdRbDI5dGlLQjVIUXZRTFFmN2tW?=
 =?utf-8?B?LzRSVDRvNmVsRmJSbENHRng3bFpHYTQyZmlaV1dXUDQ5OFZZTmRmdzB4eFZy?=
 =?utf-8?B?cDdPL1ZNTk1XN09RSEJFUkN6UC9TU3BhK0NHSFBIcEtNMlp1T3NOajVmN3M3?=
 =?utf-8?B?TkIyZ3BBc0dsbkJWMmwva1FKbHowR1owTkZQeXR4R2NPWjZsc3ZDTSs1WlFp?=
 =?utf-8?B?TzhYL2s0UGtsdXJPV1l2VG5zdzlSK2ZSVVdRK3BtOEI4eE5IZkM4cytkWTdj?=
 =?utf-8?B?UzQrMW0wVkZRSnpjNmg0ZldoYmJ3YkpsSjdpQlJWeGJGRk9MaStnaklWZ285?=
 =?utf-8?B?L3NmM21FSHVHbWJnenhrRTJHb1lIekQ5NXBkLzkrZmxlS3RYeEdEY2xwWGpE?=
 =?utf-8?B?Y3FPRUsrbFNXenMxdVFvS0Z3YVY3dGdnQnU2aXdxemcxR1lwcWIyNzNRVHcw?=
 =?utf-8?B?NHBUUDgyUlc1aHZOc2FsbVhHdU9FMm9ZVER3SFdXUGdTS3c2dU1YUTQxbklR?=
 =?utf-8?B?b0hxUnpTWEtjdm9YcXY5Yk0vRVdIRmdhMVZBdUV6Y1NYZmovYWJtSG9KZ1lt?=
 =?utf-8?B?dU5jZDRhOWxZQXNsbkY3ZmI3SUxrODdrcm1PV3hJL1hwTmJyelJUbGtIM3Iz?=
 =?utf-8?B?SndLR3ZBL2pRL2dHREhBQUlvT01sY0QrRTFLazA1enpXUmFvc1h6YWFybWNJ?=
 =?utf-8?Q?HoLJ6iY90O1c6e4yOVTmjiNbf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2cd3e79-8dcf-454e-85cb-08db20dd18db
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3683.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 20:30:18.2614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p+lx+WtLs5Hh7gOXe1RHOk1JNceGlYv9O57VRWwb4ugMx6vQN+tnN4brkm1EqToP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5444
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/8/23 5:53 AM, Michal Simek wrote:
>
>
> On 2/28/23 22:02, Tanmay Shah wrote:
>> If child mailbox node status is disabled it causes
>> crash in interrupt handler. Fix this by assigning
>> only available child node during driver probe.
>>
>> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>> ---
>>   drivers/mailbox/zynqmp-ipi-mailbox.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c 
>> b/drivers/mailbox/zynqmp-ipi-mailbox.c
>> index 12e004ff1a14..e287ed7a92ce 100644
>> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>> @@ -634,7 +634,7 @@ static int zynqmp_ipi_probe(struct 
>> platform_device *pdev)
>>       struct zynqmp_ipi_mbox *mbox;
>>       int num_mboxes, ret = -EINVAL;
>>   -    num_mboxes = of_get_child_count(np);
>> +    num_mboxes = of_get_available_child_count(np);
>>       pdata = devm_kzalloc(dev, sizeof(*pdata) + (num_mboxes * 
>> sizeof(*mbox)),
>>                    GFP_KERNEL);
>>       if (!pdata)
>
> I think it will be good to also check that num_mboxes is != 0.

Ack, I will fix this in next revision.


>
> M