Date:   Thu, 9 Mar 2023 22:11:24 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: dev: Fix bus callback return values
Message-ID: <ZApLfPnPdJkCIQYt@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <03a8cd13af352c4d990bc70b72df4915b9fa2874.1678347776.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Dpj+1m9Hb2Yj+lH9"
Content-Disposition: inline
In-Reply-To: <03a8cd13af352c4d990bc70b72df4915b9fa2874.1678347776.git.geert+renesas@glider.be>
Precedence: bulk


--Dpj+1m9Hb2Yj+lH9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 09, 2023 at 08:45:46AM +0100, Geert Uytterhoeven wrote:
> The i2cdev_{at,de}tach_adapter() callbacks are used for two purposes:
>   1. As notifier callbacks, when (un)registering I2C adapters created or
>      destroyed after i2c_dev_init(),
>   2. As bus iterator callbacks, for registering already existing
>      adapters from i2c_dev_init(), and for cleanup.
>=20
> Unfortunately both use cases expect different return values: the former
> expects NOTIFY_* return codes, while the latter expects zero or error
> codes, and aborts in case of error.
>=20
> Hence in case 2, as soon as i2cdev_{at,de}tach_adapter() returns
> (non-zero) NOTIFY_OK, the bus iterator aborts.  This causes (a) only the
> first already existing adapter to be registered, leading to missing
> /dev/i2c-* entries, and (b) a failure to unregister all but the first
> I2C adapter during cleanup.
>=20
> Fix this by introducing separate callbacks for the bus iterator,
> wrapping the notifier functions, and always returning succes.
> Any errors inside these callback functions are unlikely to happen, and
> are fatal anyway.
>=20
> Fixes: cddf70d0bce71c2a ("i2c: dev: fix notifier return values")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied to for-current, thanks!


--Dpj+1m9Hb2Yj+lH9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmQKS3gACgkQFA3kzBSg
KbaEIw/8Di3Rnwk9g5nCq/XtZ1EpQ5ZmJKofFSVI5+Ye7N65+W881Eq5XisTv+x5
cG7LPYn5XN+/vzDsmc80h9gERx/yQH3Rjkry+2doE1SRdYGdMsN2qBtaZXzZDr7V
oY2A4PC7FYKTjhUh1PRK0LahWDxeofsNBA4jfp0sinAAeirSGbrSuN0PvAFSvrMs
duRJTN/nlPvCPiYZQqMqhST2fXueCjqpsEgQ4keRhwntVhNIvhRz4JomZntSbLyP
Co5QR0YNZcWpdC3qT1fLnN+5o2dEda2w5JXYvP8NrxA1dCb9ZiyChQrr8RfejYQQ
Rf3CHnJSUHl9H5yuzzMZ3NUpQFxmv3i48lHV08myDW9UNdcvdWRIu7zMZhBzi0uX
WouSPsqEBJwQW3YmqWh3Hxo5pxVbmHk4rAanq6tdQU8y0jhQ/OsOKgM6g5I6UUAe
FrQD3cnTN4qkL6jpTC3SXMzHxhOvNHjIDIMYCx8ZXlTHGjMR8DgV+eVyv1R0Dit3
hfFZ6it52H/st7Z5HBxuEc5jTbunrvLbz9gwF1eAgNOAywxddgLa12IjsaMowWl9
NjkdAZrlTiSks9i1PpkRrxUsaHWYfR3WikaFdqIwSLno38B0vSPCbwBhbth032jP
csdsfO2ZdXnmL7MiGZhEecffCJPdpdM7+0dDvpuMQE89iZ1dfT0=
=6t5G
-----END PGP SIGNATURE-----

--Dpj+1m9Hb2Yj+lH9--