Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760401AbXIOEtl (ORCPT ); Sat, 15 Sep 2007 00:49:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751217AbXIOEte (ORCPT ); Sat, 15 Sep 2007 00:49:34 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:36105 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbXIOEtd (ORCPT ); Sat, 15 Sep 2007 00:49:33 -0400 Message-ID: <46EB645B.6000302@us.ibm.com> Date: Fri, 14 Sep 2007 21:49:31 -0700 From: David Wilder User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Sam Ravnborg CC: linux-kernel@vger.kernel.org, SystemTAP , akpm@linux-foundation.org Subject: Re: [PATCH 1/2] Trace code and documentation References: <46E9CB14.7060000@us.ibm.com> <20070914175027.GA3642@uranus.ravnborg.org> In-Reply-To: <20070914175027.GA3642@uranus.ravnborg.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 610 Lines: 21 Sam Ravnborg wrote: > Hi David. > > A random comment to the code. > Several of the struct file_operations are not declared static as > they should be. > > Btw. it looks good from a coding style point-of-view. > > About the name what about ktrace?? > > Sam > > Thanks for the comment. I sure don't want to change the name a forth time, can we live with "trace"? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/