Date:   Thu, 9 Mar 2023 13:55:53 -0800
From:   Bjorn Andersson <andersson@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Brian Masney <bmasney@redhat.com>
Cc:     quic_shazhuss@quicinc.com, agross@kernel.org,
        konrad.dybcio@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of
 remoteproc_nsp0 firmware
Message-ID: <20230309215553.pe523cmw6nc4pmnw@ripper>
References: <20230307232340.2370476-1-bmasney@redhat.com>
 <1a915c33-ef32-852c-a856-10c8d35be151@linaro.org>
 <ZAh6O9TbX/pnOnxp@x1>
 <8f7bddf8-84de-27b5-26a3-d80b2e2f0097@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8f7bddf8-84de-27b5-26a3-d80b2e2f0097@linaro.org>
Precedence: bulk

On Wed, Mar 08, 2023 at 01:36:52PM +0100, Krzysztof Kozlowski wrote:
> On 08/03/2023 13:06, Brian Masney wrote:
> > On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote:
> >> On 08/03/2023 00:23, Brian Masney wrote:
> >>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
> >>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
> >>> correct the name to match what's in Qualcomm's deliverable.
> >>
> >> I don't think vendor deliverables matter. linux-firmware is here more
> >> important. The file will be cdsp.mbn in the firmware, won't it?
> > 
> > cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I
> > far as I know there's no plan for someone to submit those since QC would
> > need to approve that. I can ask though since the DTS for these two bits
> > has been submitted upstream.
> 
> If they are never going to be submitted, vendor is allowed to rename
> them all the time in their "deliverables". Are you going to rename the
> file every time Qualcomm decides to rename them? There is no single
> guarantee the names would be fixed, because vendor is allowed to do
> absolutely anything.
> 

cdsp0.mbn and cdsp1.mbn are better names, so let's use this patch to
define that if/when they are pushed to linux-firmware it should follow
this scheme.

> Sorry, but any argument in upstream DTS that "someone downstream does
> something" is deemed to fail in many cases.
> 

That is indeed an insufficient argument, in many cases.

Regards,
Bjorn