Date:   Thu, 9 Mar 2023 18:43:11 -0600
From:   Nishanth Menon <nm@ti.com>
To:     Linus Walleij <linus.walleij@linaro.org>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] dt-bindings: pinctrl: k3: Introduce debounce select mux
 macros
Message-ID: <20230310004311.5e5ekv7edpbahjap@groggily>
References: <20230308084309.396192-1-nm@ti.com>
 <CACRpkdbBWeFupRin=JuMCGDWkzbsR18N+4ZEbQOPJq=p3w0yLw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CACRpkdbBWeFupRin=JuMCGDWkzbsR18N+4ZEbQOPJq=p3w0yLw@mail.gmail.com>
Precedence: bulk

On 15:03-20230309, Linus Walleij wrote:
> On Wed, Mar 8, 2023 at 9:43 AM Nishanth Menon <nm@ti.com> wrote:
> 
> > Introduce the debounce select mux macros to allow folks to setup
> > debounce configuration for pins. Each configuration selected maps
> > to a specific timing register as documented in appropriate Technical
> > Reference Manual (example:[1]).
> >
> > [1] AM625x TRM (section 6.1.2.2): https://www.ti.com/lit/pdf/spruiv7
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> 
> Patch applied.
> 
> Consider doing what Krzysztof recommends: move thes <dt-bindings/*.h>
> down to the arch where you're using it and have them as .dtsi files instead
> or something.

Yep, that sounds like a better idea. If you are ok to drop this
patch, then lets do the cleanup first and move the pinctrl to something like
arch/arm64/boot/dts/ti/k3-pinctrl.h

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D