To:     Lee Duncan <lduncan@suse.com>
Cc:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        Lee Duncan <leeman.duncan@gmail.com>,
        Linux regressions mailing list <regressions@lists.linux.dev>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Martin Wilck <mwilck@suse.com>, Hannes Reinecke <hare@suse.de>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1o7p170tc.fsf@ca-mkp.ca.oracle.com>
References: <20220928181350.9948-1-leeman.duncan@gmail.com>
        <88927435-ae58-c24b-e7b7-b675985de433@leemhuis.info>
        <86D685F2-D411-460B-A09B-6BE942372F0A@gmail.com>
        <yq1zg8pl1nq.fsf@ca-mkp.ca.oracle.com>
        <f8c5619f-1e1a-f759-6ab6-ea84bba3d635@suse.com>
        <yq1edq0jg2h.fsf@ca-mkp.ca.oracle.com>
        <a4ecf9eb-509a-84a6-8a9f-a3f5ea54ecac@suse.com>
Date:   Thu, 09 Mar 2023 22:17:06 -0500
In-Reply-To: <a4ecf9eb-509a-84a6-8a9f-a3f5ea54ecac@suse.com> (Lee Duncan's
        message of "Wed, 8 Mar 2023 10:41:51 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O796x2VhAJbmhUiT/zo3zjBwj+7Tsz+eYCZDt9K4zlwzSDJFRBlcB6fSfbZ+?=
 =?us-ascii?Q?8ESZQR0znSzHrQdqOML/boO3fwJM3K7Ki6BwEk8XhI31jiLROW+qTD8g/9Ms?=
 =?us-ascii?Q?Qkah9y1Vp/qSfaO8RcTQsEMBpe8WldMDNgPl20+TwAIKUB+nxTyNZ9KmS3J0?=
 =?us-ascii?Q?6+cwxeF62K4v/EKGToz0C0lsAcz8jixJLcUWcziUHsDiChJMHiw4t60bWCXk?=
 =?us-ascii?Q?aaOAwg9Z2jBoSDNqV5gK6UPblJlqyBCFdgZ5kbfeNsZNSO7eP8sbztTOT1rw?=
 =?us-ascii?Q?5gNWZht8tg0QSxXiVKYXVH7MUMb0M75SqDb12wXk4MLSvse+A7PyRhtvBJMn?=
 =?us-ascii?Q?SgGK7luZCPi2VlSJaW7BQGcZCORKjLwaVV0lnwUFSD5tDdk1ZfO1OYbsJTr1?=
 =?us-ascii?Q?Whfk6dmByONIFKkiKJWtuKrwwFyztDl8W8VMnBbpO48TQvIXSHhauXjHvZux?=
 =?us-ascii?Q?WUEroVWaRwj3oKbmFbVsHRw8ZUzN2I1r3bkzAxSn06fW+ZZwgM45MhkcR2Fj?=
 =?us-ascii?Q?8SKLjm1CDZkGUJH+Fb3xQNSi06oWNXRkr1gex1Vb7aVjRsju3Lks4q0IqU/z?=
 =?us-ascii?Q?mtLrLUq9oOsNXJ4dEnpKyLAUjct8XxbqUN/1QjR2ED+FFvNy8TXdmsXC5GUq?=
 =?us-ascii?Q?mJj8xkiJ59OMklu4tv4JLiDFtyAiG2azM0G3cGEcK8uzV2VE9okGDvKuUwc0?=
 =?us-ascii?Q?9Gsv3R6+8CQAH6zGpjTf76jIkQ6gvxj9QjKW8DwsiQmyCpNAw6pLbPTwq5Bf?=
 =?us-ascii?Q?jDPG9BK0fwC2jNDeIOxW8AoNNyJ0F2ZMWFlw0MkhMDuVqxXL8jHvYOyrF8FX?=
 =?us-ascii?Q?CnOFEQAoIee5Fq6fH1KxK2DgYwXskKZfQFK300ImRoB9Bq8xQInXuMtm16ai?=
 =?us-ascii?Q?LICAm64IUZ7O2+pmsf26/Fkwz+LrzGBDI96ApVk6xwmOEN5sTeWoR96+SVy/?=
 =?us-ascii?Q?MS8CwdNJsawEDIs239N6DptUQU9MIS5UhFXcAwMjNZHckAXSq+tBgg3BN1RE?=
 =?us-ascii?Q?NW0re45wE9EcvO39RU2swZgF2IE2iBRkpmBnjawLP/KIZE5uivxZ1cbXCCBG?=
 =?us-ascii?Q?NxlJMfWdVOhtL2XGawoaZTh82GcrWOjMG+nLT/24tLlvXIsCaWv60yeGBvts?=
 =?us-ascii?Q?SdpJcmoXPeTfB2xcv1beXGaWLVZLeVTFXY1ognSA8lBcLEjoJvVtr5PzYWxx?=
 =?us-ascii?Q?gtC9qfxrkLDviKLhQUS6kclusXOd5vAfdOCgW3IxQgenO3qGVz3VlROsE+zf?=
 =?us-ascii?Q?LOpAdgz7AS7k/AA4t18v7WNtRs4UA3HhqzBKSd4koN+91n1qc52GfKmvul3c?=
 =?us-ascii?Q?taMtzBtZwG4s6hqfj850XT+NcCzFF6vfCIaoTNQGTdE8yJUXdQ4Z9i2fanlG?=
 =?us-ascii?Q?CMQvqSaNwH92Xtc1IMz3fvobVqQhiRCI1uQgk017kPYMy28Eaz04gAGTadyQ?=
 =?us-ascii?Q?l6uBhhAWpgs/Bb43UgCYRYvMsSylzCOeSk32w5eJFoe18yILmLmyfPABwvnS?=
 =?us-ascii?Q?gZdIR6r8tw1RLOY2Zz3AOzooqE/WAfUzLYYnV2RPA3HXUvD8lEQvH6HDNIsq?=
 =?us-ascii?Q?X6/FVMSeaHvkEvXfVMGM++56wx8hQnE8S9ar23KfBmHB+ObOT1eXzgefLIgV?=
 =?us-ascii?Q?+Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?SG2H9zt94eShoSLTprwOjrXElKneMK4zh84lHdZoMVU6iSfC91ITclJ6rMSw?=
 =?us-ascii?Q?RFEtkMbpqnKi05mHHq9/hijFoheD3AJ8ugnyFveWuYlMUjyosq3EARqnH8Mi?=
 =?us-ascii?Q?K5bBaUBYYyeImnotAZa1sGvUFSBDc/9W9m6gUscZynfzci3b+cU04dg6U/XG?=
 =?us-ascii?Q?wKKh5UvWMD9NzGtSdJcQs84tCYA3CaKJ3SMF9pasqj3NUSHV5Z4SBVA0mvBG?=
 =?us-ascii?Q?9ore6AMQBVvPV9yCCtmsnSGbgcMONcizH/NfOoNRYzCuzFkeezN5RX9Bf7fP?=
 =?us-ascii?Q?W3SuThIWoxFtZ85GXMt3SdoLV2vCFlQeYregppeHu581Hc8EVG35p3tAOBy8?=
 =?us-ascii?Q?wCtc+OGbn9pq4a/SqpOgHZ3TTSjV3CDClnTir2aEJOEdGzcoWjQHKv7FHbij?=
 =?us-ascii?Q?Jqi6NqnOG/9JF3TqCcp9/zNI5kELbC4cm4aGDb4Ay4/ICcK9OvnL4imkmZDf?=
 =?us-ascii?Q?+b/spgtkb0SmFHVLzYFUsO3FKtE5QConLP8sAlORouQ41lbzl3Tv0GTOtsCI?=
 =?us-ascii?Q?RvkLevQdGWU2UqYvyXrjCR47uByOH2pJt3voipfMFRPmVvY6SX84BlDrHAkU?=
 =?us-ascii?Q?Ojn5TyTiCWC6Dwkk60G134OHwhAXlJnXFegcFE4COrkYQUQ6T+OcczDXMuct?=
 =?us-ascii?Q?S3yDegw8fOeCdxzXDZuSnFNiKv6n2reIkiax4IBtl+99z722CeXoMUudOjKr?=
 =?us-ascii?Q?CGDF8qeKrq6YiSNZI6pP2sbGaocqRbgE5eZwMHcccdKQ+zQorQ3eUi4pPJJW?=
 =?us-ascii?Q?g2cw3ki8V5cHZDw+ESMda96Kxhma2MWWgvSL6Lpv6lStmw37TODlfY4gx5iM?=
 =?us-ascii?Q?5Ckx275lq5rS8IdbUyifrapn3+9Jxul1PSjvMr7GSqUxVYruPwcTcC6kjdTY?=
 =?us-ascii?Q?WabcGWumSFKTfNmQLzVDg20PwCveEVzAvuGrJnzzaA3s+7OyENCFfxGClu3B?=
 =?us-ascii?Q?0XFCt+6gk9qH+D6Jpfj9Mw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5b6a188-20ae-41e2-b27e-08db2115f2a4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 03:17:15.8059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tOHifdTruKdl7DUYClSXVc4fmXpUv3NU1btBW8HwuNyn9wB5lgp88OgvjiJmMztrS4CHuKCUUApWTc8u0OrGeXuquf7C0KMs1yZC6pF4tUk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5978
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-09_14,2023-03-09_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 bulkscore=0
 suspectscore=0 mlxlogscore=891 phishscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2303100023
X-Proofpoint-ORIG-GUID: 5DlUnYmB5DWQAPm4mV9Bfa55G_do6U86
X-Proofpoint-GUID: 5DlUnYmB5DWQAPm4mV9Bfa55G_do6U86
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Lee,

>> In the scsi_get_vpd_buf() case we will allocate a 255 byte buffer
>> since that's what scsi_get_vpd_size() returns for a VDASD.  And in
>> the scsi_get_vpd_page() case, where a buffer already exists, we clamp
>> the INQUIRY size to the minimum of scsi_get_vpd_size() and the buffer
>> length provided by the caller.
>> 
>
> Please add my Reviewed-by tag then.

Applied to 6.3/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering