Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A5BBC6FD1F for ; Fri, 10 Mar 2023 03:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbjCJDst (ORCPT ); Thu, 9 Mar 2023 22:48:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbjCJDsf (ORCPT ); Thu, 9 Mar 2023 22:48:35 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DE34144AD; Thu, 9 Mar 2023 19:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=C1CBGLBwvaGa3mgx0DmiI5qj4lO1PYLdZhzQTypCtXI=; b=REnKRcvd4eO3mi3I4E1kyq51h8 DA6HL6l+BmP4swUeeE0kopQpwx7zWQk7WwhRWcouMWtv9CbB02/DLxJWuorWYmYYlvWuJv0XsprPB f+DZosqbO+MKgSZiCcNdANsrYmv/fhdtzoZ/HdqbWIS6WG1SaFtvX3zYauOt1agLy7RxSHpGVzpO7 TbbYJ6OGDcg/0aB5f1g/wlqr5LV6i/PrA1BrM1Di7mOi7TBi/6xuhTYHR5FlBf6FFQISnnS4jurOP YQ7MTM5QgtUfviCa9k5itrvMWnYOEdJ4tADeHhnXJcUfhs+XCjg28gS71dc6C03XkLgXgTlYbfd7S AVj9JovA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1paTk0-00FClY-36; Fri, 10 Mar 2023 03:48:25 +0000 Date: Fri, 10 Mar 2023 03:48:24 +0000 From: Al Viro To: Christian Brauner Cc: Jiapeng Chong , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] splice: Remove redundant assignment to ret Message-ID: <20230310034824.GK3390869@ZenIV> References: <20230307084918.28632-1-jiapeng.chong@linux.alibaba.com> <167835324320.766837.2963092716601467524.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167835324320.766837.2963092716601467524.b4-ty@kernel.org> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 09, 2023 at 10:15:46AM +0100, Christian Brauner wrote: > From: Christian Brauner (Microsoft) > > > On Tue, 07 Mar 2023 16:49:18 +0800, Jiapeng Chong wrote: > > The variable ret belongs to redundant assignment and can be deleted. > > > > fs/splice.c:940:2: warning: Value stored to 'ret' is never read. > > > > > > Thanks for the cleanup. Seems ok to do so I picked this up, > > [1/1] splice: Remove redundant assignment to ret > commit: c3a4aec055ec275c9f860e88d37e97248927d898 Which branch?