Message-ID: <b2ac2d1f-3e9b-f96d-3724-020f7140b05f@axis.com>
Date:   Fri, 10 Mar 2023 11:48:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] dt-bindings: power: supply: bq256xx: Add ts-ignore
 property
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Davis <afd@ti.com>
CC:     <kernel@axis.com>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230309023926.38682-1-chenhuiz@axis.com>
 <49e67fb3-4ef9-5d50-c3e8-3c7857145bbc@linaro.org>
From:   Hermes Zhang <chenhuiz@axis.com>
In-Reply-To: <49e67fb3-4ef9-5d50-c3e8-3c7857145bbc@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1FtakQ4Yk8waHoxSkVXc1d6OFFVUWlKTG9ibTNzSzllNGpzSlRMSXVYMUtV?=
 =?utf-8?B?Q2sxNFdDMTZ4aGxuMTVpbnJKa1BGcW9oNTl4RCtGM3Qxang3cWErKzNUeGF1?=
 =?utf-8?B?SU02RWgrZkV0Q001SmEyb2IzMkZOUk1BQ0NNME5ic3FzRXc4cmphZnNPc0Js?=
 =?utf-8?B?THdMRDFQanJxOVU2Z1g2NTVBTHhsZ3hpbzUzUnNZeW1BeXM1YXBZbVd2dlJV?=
 =?utf-8?B?TFAyU29hNXJIdE0rYjk4M2ZlUTBpVEZFbTNZbVlXNHpkSFdWekdhMzgzOUcx?=
 =?utf-8?B?MVptQ3EveHVRN2NJOWJzR0RjamlCZlpFZnpsZlBBd2EybDYwK1d3dWh1VXNF?=
 =?utf-8?B?UnFHajFGMThHT21DNWt2Und1NmZLZVI1UkFRbmdvdVFXdUFtMGs4cXNsWk5D?=
 =?utf-8?B?VjV3OW5Jdi9EcDMzak9xbExkNEhTT3VQNzliTHg2MWdMLzkxeFRPSGlUYVNG?=
 =?utf-8?B?RWdqMkRpU3lQLzByL1kxU2VMU1g4M29ESmUybVFUekpuNWJlSmtPZjJRSm5s?=
 =?utf-8?B?NUlZb2NZb2RGNlJVOG5sZGNvV1JPN2FxWWoveUFVV0I5YW5sZHdQc0MwcUM4?=
 =?utf-8?B?bG1QcUVORnhOejhSZ1hlaEN4UFVVeU1kNUU5VDlkS1o0RzVNL1pydTdTU1lE?=
 =?utf-8?B?aG44ZW5BcmtvYzRnRkJCc2MxYkVlQ1piN1lZcGtacTlKUmhlYlZuRjZhUFdp?=
 =?utf-8?B?WU1VWWVXTGJKbjBEbml5YVpTUnpBNTlOMTBoeWFRbHVOUU1BbkxQbzc1TzZR?=
 =?utf-8?B?ZDNkWnlaeENQSGV6aGtISHpxZmozandjZ0dYVDgrK2FzT2pIQmNGMGFQSlNS?=
 =?utf-8?B?QjFNRFExM1VLRDl2NmlFUHRvb2FDbjJSWFZKNmZCSmVpcDRmODIzYkZNNEpH?=
 =?utf-8?B?UVRXWVZndEtNd3lFQXMrVHRETEtlaENxcXQ3QW5DUWFyMEU0MjdiallYRUxp?=
 =?utf-8?B?VEVWdmZzdzczU0lyTnpWMGExbG9TUEJ0OWhmRG5aSmJiUlFWYmFqTS8zTHlt?=
 =?utf-8?B?eVlvMTBjTmRkdlJUbUFhczJzdjdGYjhJZTd0dTk3UUlwRGQ4cFdRc2pJSnpy?=
 =?utf-8?B?NFdHSnZnc0NYb0kyczNaU05zTEFXV2w5cU5rbG9NVC9jdHJ1UlozeWJkRU1J?=
 =?utf-8?B?YjM5WlFGWWFqOGRMV0RJczNkWEpWZjNaeVp5SDRyaGlFNy9DSi81Y2lEbDlR?=
 =?utf-8?B?U2VTNURKYUV6VkZGMks4WTJPeXg3cmx6U0tNQ29qYXBZbzJVaVJZRE9jZU01?=
 =?utf-8?B?NFJrVjVBeFhNelpERWNOYWFFRHdsVTZORW94bEFxREhEem9BWlJPMGVDK3o3?=
 =?utf-8?B?Wmk0SDdQaU5qWHlTakpEYnhPUjl6RU9mbCtKU2Z0cnNxT2dYc24xRlVHaVRF?=
 =?utf-8?B?b2FyZit0dnR2bTkvdnd1TVFwMWZCbEU0d1ZjY1hnWkpCQzN1cmRPVldkRHhJ?=
 =?utf-8?B?Tk80bHpGS1o5WHVHNkI0TitqK1orYUp6aU9tcVorSUhaTTEySkEwV0VaRVNj?=
 =?utf-8?B?cUV0SU5KSjc0ZUVHZGJHS2hHOTdMY2tKdU5FNzZESDdGaUpoSHplY2JBd1RQ?=
 =?utf-8?B?VmF0cmJPQlc5TkxkNWpKQmlwa2Z5d0YzNzNsMkRpVG9LcXNzeEtqM2xLN1gz?=
 =?utf-8?B?UG9zMFh4U3dSRSs5WEN6elZJY0NUZGU2K05QazhVR3hiSlFsK3R6aDFyNC9K?=
 =?utf-8?B?M1o2UnZIWHZhTTlPNy9lVmladGExMG1EN0ZpeXRKSk8zRUVzYjNROVk3b1h5?=
 =?utf-8?B?ZFN6YlZhTzYwb2NSYjdld3FvUElZREMyNkxCRFM1OXJqU2hZZ1g3L09SdXNa?=
 =?utf-8?B?dEFUazNWaGMvcE5KTmVEbmhIbVlqclhXN2FIbnMybHNlRlduMis4Nm8yaU5u?=
 =?utf-8?B?MG5PYWdPN3Y3VlVmQThLdzRmMlRONHg2a1c2YjNNeHlLb1lMcnF6ZWU3WmlC?=
 =?utf-8?B?b01MYVdQTk81UFJFaGFlSExxYkZjMzcreXFBTDRPSjhrNldMZndzeGJvQ0kz?=
 =?utf-8?B?bUlDWDZ6bjBCcmVRUWwxemExVzFRR2p4VjkwZVdHY05EcEZPVmgvbVp6WEk0?=
 =?utf-8?B?cUp2cTZpYnBtdXVBZnU1bTJMWURIaW5ybnJabTdxYVB0SktxdlkxUDg1WTBj?=
 =?utf-8?Q?qdNVMi83H5snVRnsMe3teweY4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8893479f-2993-4eec-0357-08db211a5f44
X-MS-Exchange-CrossTenant-AuthSource: DB6PR0201MB2440.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 03:48:55.7966
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lFlGFB64pn5fhP1mot9DayTheN4e1tzuEcWvo0i4hA1qd5Fp8DV3lLNqAnpsPd+/DgsVMHaWM2Go5+14xb7ACQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR02MB8741
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023/3/9 18:12, Krzysztof Kozlowski wrote:
> On 09/03/2023 03:39, Hermes Zhang wrote:
>> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
>> in chip. Ignore TS pin will allow user to control the charging
>> parameters instead of the default JEITA profile in chip.
> You miss users of it.
Could you give some more info about what I missed?
> @@ -68,6 +68,12 @@ properties:
>         Interrupt sends an active low, 256 μs pulse to host to report the charger
>         device status and faults.
>   
> +  ts-ignore:
> Missing vendor prefix... is this generic property? ts-ignore is very
> cryptic. You should describe here rather desired system characteristic.
> Why anyone would need to use it per-board level?

OK, I will fix it. Will "ti,ignore-ts-pin" be better? Yes, it's a 
generic. To disable the TS pin, actually we also could do it from HW, 
but from software, it could be more flexble. But if HW already disable 
it, then you don't need to do it again from dts.

BTW, I find I may miss some information here: the ts-ignore feature is 
not support by all the chips list here, I will add some comment for 
which chip support it.


Best Regards,

Hermes