Message-ID: <9f692bd9-94e4-ee60-2174-561685b9b39a@amd.com>
Date:   Fri, 10 Mar 2023 12:10:28 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC/PATCHSET 0/9] perf record: Implement BPF sample filter (v4)
To:     Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Song Liu <song@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Leo Yan <leo.yan@linaro.org>,
        James Clark <james.clark@arm.com>, Hao Luo <haoluo@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230307233309.3546160-1-namhyung@kernel.org>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20230307233309.3546160-1-namhyung@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW1kblhWNkdCOGxhVDVZVXlvaHluVVlUczc1bTJmL2p3amgxUE9mN05Xbi9F?=
 =?utf-8?B?VkxDcUJ1V2lQMktLd2puaFlwQ0ZMdnFYcjhKTkNqMjhPUVNQS1V6UzJFQ0N2?=
 =?utf-8?B?NTlLOFpXZ0Z3WlF3Q2tvYWprVnhHeWV5UXcvYlB1WTdBVjg0SmhaM0R1TkVt?=
 =?utf-8?B?cldsSWZlOUtEUHBDRmd3eUppRmpYc2ppbnE0VklNRUwvdFJMcHFsL2lDWjBQ?=
 =?utf-8?B?QmpTbHlCdlBIdE9hTTd2d1JoMlZ5amozOHdHNDR3eXZMcjAwQVNjYS9KUS80?=
 =?utf-8?B?TmEwbzluSUdJbUx5V0lWTjFITmFPZEU4bnNMYVkxVC9XR3BJdGZTUlB4blFY?=
 =?utf-8?B?b0pVQ0hKbFk0R2U0cVJhMVVTYzRrT0JtbkxhZ1lVT0x6T2xtaW9QOFRtRmFY?=
 =?utf-8?B?T1gxek9BTVA3cG1BY3NtQS9BTnFuZE1CUzJKL042N1NlNFNwemJ1YnZ4c0s4?=
 =?utf-8?B?Q01mN0Q4bk9vWHNIbU5MZTNTT0pXNlJ0NkVvV2xDZHd6UUNja0x5TElmdG1N?=
 =?utf-8?B?RHJJRFg2aFV3cTNhSnltamxVRWx0bXZGSlZocGh1S05iZlpxUXNsckhqZEYw?=
 =?utf-8?B?Q0l3eVBRNDBLVnVnWU5GZkZTUmVuQjlKaVZIL0cwOHJDOXpmT2t5eWZMYWp3?=
 =?utf-8?B?T0I3azc1VkdNcjkyZGNvM1IvenZHdE5pTDIxZ085bzB1ZURaNUxScndkMVYr?=
 =?utf-8?B?ZUgvRC9GWDZIUWV4VUtHd3l2aTY0S1ZNYlNpbEYxdnVhMGdSRXQxbUJnRVlh?=
 =?utf-8?B?clYyRm9xR1ZHM0NMUnNYMnV1N3dxU05CYlN4V3BxUlIwQWc0WWZrN1FYL1A3?=
 =?utf-8?B?a3R4SmhzdklRN2FFTG02N3Bpa0VFcU5IbW5HZTl2ZVRrY0FLR0k2UjhkcFNW?=
 =?utf-8?B?RzRLa3doaHBJRnJVZHhMWjV4SzVPQkR4VDhRWjVjRGZnWkxESDlqUkJpcUFQ?=
 =?utf-8?B?UnVQRVd6aE5nNm9saUcwTFdJQ1VUeGltdUF4V2E5aU10Y0VaYnIwZkJtZUJB?=
 =?utf-8?B?Ty9BYjRFN1pxRU16UVpUMzBCekJXUHU3bFRxMWhYcm1Qa2xNeHo3dWpHQm1K?=
 =?utf-8?B?MWRmSnNRVWIwZktyb1hwOTc0eC9LMDE3TEZUN2t0UkRqcWxRdVlKMnFyQUhm?=
 =?utf-8?B?Y2FBZWNZSUNva3JjUlZXZkRsM0tNYm4zU280YXRsNkdWMTJvRXBpWHlLbzM2?=
 =?utf-8?B?aW9yS1V2OHRZWEpGSVQwVVJHWEhzc2VOdS8rT1c2ckVzTlZTejFXL3ZyMEs0?=
 =?utf-8?B?Nm9odFRaN0s3Q0ZNa0plWGpGdlM0SWhNb3ZnMnY1SUtPcTRha1c0dGZoY2Vo?=
 =?utf-8?B?SEtYaWZKdXh6WjRubm1MLy9MU0thc1VnYTUrdTFETVFiOHdRN0dvd0tmTnpK?=
 =?utf-8?B?cCtZNUNMOXRodld6QmF5V0QySmhKMVhrOHBUNk5DZjNaSVRMdnNVOHU1NHRp?=
 =?utf-8?B?aXU5bkhnejZtMzlpdFFHT3RmSzI3aEc2ZnF0L3BQQUlTOU5wU05mNldBU3hU?=
 =?utf-8?B?dTlQNGVmUXUxRS8zVVNFODdQU2U3RjRZWktZaFpKVTRSdjhtQ1ZVc1pid0Ey?=
 =?utf-8?B?azByV084TXFKRFNHdldJai9Xc3JxcVZmZzVSNEVoTUdJa3I1SU9ZRFNyVVFv?=
 =?utf-8?B?YkRlTGlBdTBhaFR0UnVncXMxcm5MbXpLU1IwQTdHKzlrUjVRRjhUQS93VkNY?=
 =?utf-8?B?SkthcTNRemdYb0VMSStuZGJQendMSjY4N1BDc0k3VzNaZlZTaEdLcndPREFG?=
 =?utf-8?B?NUxzWXhuMUhGOFNPalQ1QTBJS3BBTjVLdE0yaHdQZGRHeHI3RFJQNWJYcnYz?=
 =?utf-8?B?VUdCaGF6ME01aXAyVUw4TlFsNWpaTmVRaWhlaWZvallXQi83QTluQVJDTE9z?=
 =?utf-8?B?ZzRZQThwSFdrY2FWbTlySktlN25xTVR2bFJHYjVSSWhlci9RWFp2YVRkYmxR?=
 =?utf-8?B?cFJWelptU0ZSSEROSXdmQjlvUGwvQ2UxbkpPU1JNci9xcjlGcmxucklGTDFP?=
 =?utf-8?B?b1dUZjVQT2VKQU00Q1kyUDBHeXEwNlVURFVWcFBjUTBnWVRqRmFzYkFDZlk3?=
 =?utf-8?B?V2psdzEwbzhSbWkwWkhLUkM2QWhmeFFvVS96Q3BYQUNobFFaakNMeDc2VDVa?=
 =?utf-8?Q?yxNERrIL+dPL5PgsLA644jmuW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e3bc9eb-2307-4778-da4b-08db21325ed8
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 06:40:43.0782
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eQA6LivAtNmMw844aPUv+84WQVUM3hBleJipt8NrhPiNbiaMNkcphaOHjWugL/2tl/GO6WUflhGm5+1KmqoGzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8659
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Namhyung,

Sorry, I should have tried earlier prototypes but missed it.

> Maybe more useful example is when it deals with precise memory events.
> On AMD processors with IBS, you can filter only memory load with L1
> dTLB is missed like below.
> 
>   $ sudo ./perf record -ad -e ibs_op//p \
>   > --filter 'mem_op == load, mem_dtlb > l1_hit' sleep 1
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 1.338 MB perf.data (15 samples) ]

On my zen4 machine:

  $ sudo ./perf record -d -e ibs_op//p --filter 'mem_op == load' -c 100000 ~/test
  [ perf record: Woken up 6 times to write data ]
  [ perf record: Captured and wrote 1.436 MB perf.data (30966 samples) ]

  $ sudo ./perf mem report -F sample,mem --stdio
  #      Samples  Memory access
  # ............  ........................
           30325  L1 hit
             477  Local RAM hit
              89  L2 hit
              75  L3 hit

This looks good because IBS hw can't filter specific type of instruction
and thus unfiltered data will contain "NA" types of memory accesses, which
is absent here. So mem_op == load filter seems to be working.

However, if I add "mem_lvl == l1" (or l2 / ram) in the filter, I see mostly
all samples are getting lost:

  $ sudo ./perf record -d -e ibs_op//p --filter 'mem_op == load, mem_lvl == l1' -c 100000 ~/test
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.019 MB perf.data ]

  $ sudo ./perf report --stat | grep SAMPLE
    LOST_SAMPLES events:          1  ( 0.8%)
    LOST_SAMPLES events:     136332

What am I missing?

2nd observation, invalid expressions like 'mem_op == load, mem_dtlb == l1'
are not failing, instead recording misleading data:

  $ sudo ./perf record -d -e ibs_op//p --filter 'mem_op == load, mem_dtlb == l1' -c 100000 ~/test
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.047 MB perf.data (614 samples) ]

  $ sudo ./perf script -F data_src | grep "TLB N/A" | wc -l
  614

Thanks,
Ravi