Date:   Fri, 10 Mar 2023 15:39:07 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Oliver Neukum <oneukum@suse.com>, Arnd Bergmann <arnd@arndb.de>,
        "Matthias Kaehlcke" <mka@chromium.org>, Lee Jones <lee@kernel.org>,
        Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>, <linux-usb@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-spi@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <srinivas.pandruvada@intel.com>, <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v4 2/5] gpio: Add support for Intel LJCA USB GPIO driver
Message-ID: <ZArem5MwWrgOY2nJ@ye-NUC7i7DNHE>
References: <20230309071100.2856899-1-xiang.ye@intel.com>
 <20230309071100.2856899-3-xiang.ye@intel.com>
 <2865f3d0-428b-0df1-fc50-f6af3cb9dac3@suse.com>
 <ZAqyhXt9nNIE9Ej7@ye-NUC7i7DNHE>
 <ZArYCD0r6n0sJ7LI@kroah.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZArYCD0r6n0sJ7LI@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hMrsn4JEx5kpVZqPXVdWMMxXYsijFzTESriEzkvYqTSvfinEMxh3aut04ZCb?=
 =?us-ascii?Q?W3Eb8RWXIB0DEXbLujURDM1PGkkSwWjkMARv/MOKBag8JurHhBsSVm0Ae3pA?=
 =?us-ascii?Q?MiaEYySK8/XAxCPLAKiFIKwAPRQcP0rPgTjRI7po/aZ1mqEFvgIlzIxB7Xzs?=
 =?us-ascii?Q?Mbxeb7/SmvyHR2B/p+5o9g+O4eQpo2+Vuur7HzMRcEyQc1+vq2zJMfDhnOD1?=
 =?us-ascii?Q?Ie4peHlrBRue5uodFNr0IewTN94Fhjr5kC3VDthuAM/fMTFm+HIXgrIBoPS7?=
 =?us-ascii?Q?0qiijvcvzZK/1zV9nB7cogwp96ldso8Mk2jIfCVPJgENwMOxNTVlAVeR/Fwj?=
 =?us-ascii?Q?1IBNKFg3ol5bn6hMlSs+OqLftnKajuolgvqTL+mNc490bEQHfpnrCDLPQtKy?=
 =?us-ascii?Q?xHKWDlIbKowVFT0BAH8l/YQMBu+mqIiHMwRyvBgEbvJV2/biK8VnMImb/Szv?=
 =?us-ascii?Q?4v9sJNHevNXhEHDEiQ692jk4ugGArBDcIxDosPsSrGEJWA0KqhoVe9LYIyYw?=
 =?us-ascii?Q?JTxrDvSxBvJNmV/27WXjg1Vg6AAGrhKcUTA55Qowak+D2G1zAd8V2d018rQX?=
 =?us-ascii?Q?VoR5z1hUdO6unAxdejDaXXsJVRqfV7higFvydsmQO2GoJjIgiW5/bdcHtaIN?=
 =?us-ascii?Q?/PyjhPEO96rUC6AR2vdJSxLB5Z03xAi2XD+TT7XT7jpkjM1aKlvk7FdBtAVU?=
 =?us-ascii?Q?OclflRyJ3KY1tSiZ88CI4mVSxDSzjRpjAOlmqxLGVgy0CRTo0PpmIbbjA1k3?=
 =?us-ascii?Q?rIvIb1Xx6fLv6xgoGnefWSQxz9ujooaj368hL+Aggndb7iLaBV2CPhvApj7B?=
 =?us-ascii?Q?+U6o6p0BWk8ncpDOa4bLcTlxMAQ1Mjn8MIbKTkV8sSaeA+469ycIa4JJSasR?=
 =?us-ascii?Q?CvZaj5TySwlda1CC7RA9IuqffmFyh68Mtw61GGRFWLFBtD8XmnZKNO5n+0qK?=
 =?us-ascii?Q?XbTIKU70NzYEoRWCgopYQn8zpRvtBF3iv/fQQyX0Yg591uWsAm2VJRhF9sRX?=
 =?us-ascii?Q?BW+O9KlQsPKjSYSgCCV2opftt6kBqwABNfAC4Fq8p5F4SBQO2LkqrSwDXdjp?=
 =?us-ascii?Q?xbh8lbHdM2EwRg0Y6MwVHJdrC3Ma2Br2TXF4nApV8T+op0RdFdYbqhDuWrAZ?=
 =?us-ascii?Q?89mDgTb/7BdPUe+A+4/rRgtnLBVhExyif79G0TfALLcF2Ccuud4fD1XONlzl?=
 =?us-ascii?Q?fKQMO0rU/iltTZp47nKAoP4ElAeQwGqHdZpieb5gGY5+CA80jPP/PBeNsK12?=
 =?us-ascii?Q?wRhYz8wsNUNJuabKTugdGIxT6vT0DFBgFsG1obIUhkoIsO3h3AQuPqialgmw?=
 =?us-ascii?Q?xArML6IR9lzgke9ErZoxtEcejZqMohNqcdITVz9x+svapj+0Snf08pTiIEJX?=
 =?us-ascii?Q?A6GwfnV7E3nRMUJwd78UxNtyNaKfTKeF50KJv965pNEjnVkpwqGE6C8DM9Th?=
 =?us-ascii?Q?SlLZybCeFVenGFe8oZoRBHoAM5iysYDL8z6Lglm0d2nhxH43jf/VNJK5YfER?=
 =?us-ascii?Q?1ZN9buxTRqZmKi/FAnrRb5CMANzETdpJla5fHXTVFT1ILl6cZdnNwo8gH1gc?=
 =?us-ascii?Q?DqOmFeARhkiCUJT0GIhDEOzt3W/ESMEfK5xeKmcY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 04f44f82-216e-4259-e50c-08db213a8b65
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 07:39:13.7962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PmTGWETAyuLmTxn+iiGZm8dM4wDnU7bdN4AGgIxFS8y/r3ZIXXFUzSoBgGltiaJUA1opzKnxsffH+iBpViuimQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6044
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 08:11:04AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 10, 2023 at 01:01:11PM +0800, Ye, Xiang wrote:
> > On Thu, Mar 09, 2023 at 02:40:10PM +0100, Oliver Neukum wrote:
> > > 
> > > 
> > > On 09.03.23 08:10, Ye Xiang wrote:
> > > 
> > > > +#define LJCA_GPIO_BUF_SIZE 60
> > > > +struct ljca_gpio_dev {
> > > > +	struct platform_device *pdev;
> > > > +	struct gpio_chip gc;
> > > > +	struct ljca_gpio_info *gpio_info;
> > > > +	DECLARE_BITMAP(unmasked_irqs, LJCA_MAX_GPIO_NUM);
> > > > +	DECLARE_BITMAP(enabled_irqs, LJCA_MAX_GPIO_NUM);
> > > > +	DECLARE_BITMAP(reenable_irqs, LJCA_MAX_GPIO_NUM);
> > > > +	u8 *connect_mode;
> > > > +	/* mutex to protect irq bus */
> > > > +	struct mutex irq_lock;
> > > > +	struct work_struct work;
> > > > +	/* lock to protect package transfer to Hardware */
> > > > +	struct mutex trans_lock;
> > > > +
> > > > +	u8 obuf[LJCA_GPIO_BUF_SIZE];
> > > > +	u8 ibuf[LJCA_GPIO_BUF_SIZE];
> > > 
> > > And here we have a violation of DMA coherency rules.
> > > Basically you cannot embed buffers into other data structures
> > > if they can be subject to DMA.
> > But obuf and ibuf does not used to do DMA transfer here.
> > It is actually copied from or to ljca buffer to do URB transfer.
> 
> urb transfers _ARE_ DMA transfers.
> 
> > Should it still need to follow the DMA coherency rules?
> 
> Yes, all buffers for USB urbs are required to follow those rules.
But these two buffers are not used to do USB urb transfer directly.
For the "u8 obuf[LJCA_GPIO_BUF_SIZE]",  it will be copied to ljca buffer
("header->data" as below code [1] showed) first. Then the "header" is used
to do the actual urb transfer.

And the "header" is allocated by using kmalloc. It should has met the DMA
coherency rules.

[1] """
struct ljca_msg *header;
...
header = kmalloc(msg_len, GFP_KERNEL);
if (!header)
	return -ENOMEM;

...
if (obuf)
	memcpy(header->data, obuf, obuf_len);
"""

--
Thanks
Ye Xiang