Message-ID: <a1290791-7589-32dc-fc96-af857d10aa61@linaro.org>
Date:   Fri, 10 Mar 2023 09:06:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] dt-bindings: power: supply: bq256xx: Add ts-ignore
 property
Content-Language: en-US
To:     Hermes Zhang <chenhuiz@axis.com>,
        Sebastian Reichel <sre@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Davis <afd@ti.com>
Cc:     kernel@axis.com, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230309023926.38682-1-chenhuiz@axis.com>
 <49e67fb3-4ef9-5d50-c3e8-3c7857145bbc@linaro.org>
 <b2ac2d1f-3e9b-f96d-3724-020f7140b05f@axis.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <b2ac2d1f-3e9b-f96d-3724-020f7140b05f@axis.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/03/2023 04:48, Hermes Zhang wrote:
> On 2023/3/9 18:12, Krzysztof Kozlowski wrote:
>> On 09/03/2023 03:39, Hermes Zhang wrote:
>>> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
>>> in chip. Ignore TS pin will allow user to control the charging
>>> parameters instead of the default JEITA profile in chip.
>> You miss users of it.
> Could you give some more info about what I missed?

Users. DTS and driver code.

>> @@ -68,6 +68,12 @@ properties:
>>         Interrupt sends an active low, 256 μs pulse to host to report the charger
>>         device status and faults.
>>   
>> +  ts-ignore:
>> Missing vendor prefix... is this generic property? ts-ignore is very
>> cryptic. You should describe here rather desired system characteristic.
>> Why anyone would need to use it per-board level?
> 
> OK, I will fix it. Will "ti,ignore-ts-pin" be better? 

No, because does not describe system characteristic. Read again my last
two sentences.

> Yes, it's a 
> generic. To disable the TS pin, actually we also could do it from HW, 
> but from software, it could be more flexble. But if HW already disable 
> it, then you don't need to do it again from dts.

If this is configurable from HW, why this should be in DT?


Best regards,
Krzysztof