Date:   Fri, 10 Mar 2023 09:14:15 +0100
From:   Tommaso Merciai <tomm.merciai@gmail.com>
To:     Frank Sae <Frank.Sae@motor-comm.com>
Cc:     Peter Geis <pgwipeout@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        yanhong.wang@starfivetech.com, xiaogang.fan@motor-comm.com,
        fei.zhang@motor-comm.com, hua.sun@motor-comm.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v5 0/5] add dts for yt8521 and yt8531s, add
 driver for yt8531
Message-ID: <ZArm11JCCD5ymspR@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
References: <20230202030037.9075-1-Frank.Sae@motor-comm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230202030037.9075-1-Frank.Sae@motor-comm.com>
Precedence: bulk

Hello Frank,

On Thu, Feb 02, 2023 at 11:00:32AM +0800, Frank Sae wrote:
>  Add dts for yt8521 and yt8531s, add driver for yt8531.
>  These patches have been verified on our AM335x platform (motherboard)
>  which has one integrated yt8521 and one RGMII interface.
>  It can connect to daughter boards like yt8531s or yt8531 board.

Thanks for this series.
I test on my jh7110-starfive-visionfive-2-v1.3b
Great job!

Tested-by: Tommaso Merciai <tomm.merciai@gmail.com>

Regards,
Tommaso

> 
>  v5:
>  - change the compatible of yaml
>  - change the maintainers of yaml from "frank sae" to "Frank Sae"
> 
>  v4:
>  - change default tx delay from 150ps to 1950ps
>  - add compatible for yaml
> 
>  v3:
>  - change default rx delay from 1900ps to 1950ps
>  - moved ytphy_rgmii_clk_delay_config_with_lock from yt8521's patch to yt8531's patch
>  - removed unnecessary checks of phydev->attached_dev->dev_addr
> 
>  v2:
>  - split BIT macro as one patch
>  - split "dts for yt8521/yt8531s ... " patch as two patches
>  - use standard rx-internal-delay-ps and tx-internal-delay-ps, removed motorcomm,sds-tx-amplitude
>  - removed ytphy_parse_dt, ytphy_probe_helper and ytphy_config_init_helper
>  - not store dts arg to yt8521_priv 
> 
> Frank Sae (5):
>   dt-bindings: net: Add Motorcomm yt8xxx ethernet phy
>   net: phy: Add BIT macro for Motorcomm yt8521/yt8531 gigabit ethernet
>     phy
>   net: phy: Add dts support for Motorcomm yt8521 gigabit ethernet phy
>   net: phy: Add dts support for Motorcomm yt8531s gigabit ethernet phy
>   net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy
> 
>  .../bindings/net/motorcomm,yt8xxx.yaml        | 117 ++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  MAINTAINERS                                   |   1 +
>  drivers/net/phy/Kconfig                       |   2 +-
>  drivers/net/phy/motorcomm.c                   | 553 +++++++++++++++---
>  5 files changed, 597 insertions(+), 78 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
> 
> -- 
> 2.34.1
>