From:   "Chen, Guchun" <Guchun.Chen@amd.com>
To:     Zhenneng Li <lizhenneng@kylinos.cn>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>
CC:     David Airlie <airlied@linux.ie>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        "Koenig, Christian" <Christian.Koenig@amd.com>
Subject: RE: [PATCH] drm/amdgpu: resove reboot exception for si oland
Thread-Topic: [PATCH] drm/amdgpu: resove reboot exception for si oland
Thread-Index: AQHZUyayYDVcB0qNSkOAgOVEzBYkza7zqzhg
Date:   Fri, 10 Mar 2023 08:18:49 +0000
Message-ID: <DM5PR12MB2469FEB1E81CA99C51E7DAF0F1BA9@DM5PR12MB2469.namprd12.prod.outlook.com>
References: <20230310074000.2078124-1-lizhenneng@kylinos.cn>
In-Reply-To: <20230310074000.2078124-1-lizhenneng@kylinos.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xuPXGEmIoozo3Wo8ExPkOO1N0SjIf3M8hXQMMT6US7ZS5nMZNhAvZAXPPk+B?=
 =?us-ascii?Q?KtobGowm1XXpEJyZxhPkD1PaqQnLPkINXUuco9gbMtlHe/MCLfnVmJsVk+AW?=
 =?us-ascii?Q?P+LHFmQQatCOfePrjSt8PAB/TbbydG1ZTW6x5hinyoVTb09bVKeAjJTais8J?=
 =?us-ascii?Q?ZJJNhShagjZ83xRG7Rr7nyJSmTe/oV0TylWkYBQ8JJWUb3MrU6rjUuqSdB8j?=
 =?us-ascii?Q?T9EVuvr/335XlKUEvbjSgAA5G13vYm9vzM4CRc//Baod6damGGpz5Ck12oq+?=
 =?us-ascii?Q?TkkkCpDlQANxNFgXpaD3iATbirARRCx+YwjAx2++C1izicjEXKJqqsZk7t7U?=
 =?us-ascii?Q?HzRxbo8SvaUWIXzGxqr/jo0jxG+BshPzrW9SWtip2qxlhorss10KwIZEZNO1?=
 =?us-ascii?Q?YzU0ez4sVj9Ul9DRSyIymDJrgGLMoJIKiMOs/8+AMB571lQe2jW8PeskvzDJ?=
 =?us-ascii?Q?qr/zNpbIzbdOUAu/gSGmTGpQwBsgViUEPa455OgNj+6ac9VZEE1NkA790pLA?=
 =?us-ascii?Q?/sOL8y2zlpQbbcO86ako+G3/s8ecT31cb8qs3WHn5mfiKK2XbY8WSpHdTq38?=
 =?us-ascii?Q?ig646zQgZW/8FFjYE2DdmESGl2jUOwwErpVh7tMUEF0dTcmFG1yXVKB618ZC?=
 =?us-ascii?Q?lC/xQtVGjy/vw7YSyoPI3sHxhv6S8YRcyXeNE7HptPOL3cllDHAjGNYWF/R6?=
 =?us-ascii?Q?jqRufD2ubUUq/sveKsM4ToZcYrCM6AjtozMgrWQ5xrKrg1dr176uoWyzb/5L?=
 =?us-ascii?Q?aAZFJ4xuYPgWgM326XEZnMNegnG+m3SXHV8umPojzTWNYqPnrK6CiWa+E4jK?=
 =?us-ascii?Q?082HcDHfpVAQO0ZMlrN3iuOqc5MV4mBVb5U7GL0sOpLh5TszHzuvbQqQgKsm?=
 =?us-ascii?Q?xqWtgk09VPcitYA23NIETSb76/GwUMXDWq22QKYrty+54fsvpBT/jvZ9UIxn?=
 =?us-ascii?Q?WcyykUXt+YrY6TSMFRE8qG/JQYyJEecaPye95rEqVHxpSzA1fbmuH70WmxUZ?=
 =?us-ascii?Q?kuH1zaa6idZ8FGVmByQ3XSGqI7oQhWvuO5+COJ0sIvlt42woJazg2o8XUfF+?=
 =?us-ascii?Q?WHKYMUy7HRlt/IZEb/f5acZ41T1kZP31YcgziR6TKwNcT5Lwfa9SQgqtZ/u+?=
 =?us-ascii?Q?1HSplYcVXPWhbN2J/6NljtqMItmG4RQkmyrw+I/iCYNq+jojr/A2zNxw5DYY?=
 =?us-ascii?Q?rysD/B3+6Dif6dLkMhTVew5655cw/Sk8EkBLIUGHTxXAvVlPY8VrNNLtIih1?=
 =?us-ascii?Q?N3HZWagdeqn5NNbQFRlQgoLIIvQcAfuPvrHN9ajt7X34GZK5WS7j3+pmoAKe?=
 =?us-ascii?Q?29yXVpyfHr/XTx5Nfu9v/K3jiEDC979/R4c5AwMhpxT23NJIN6vC1/8UhMTt?=
 =?us-ascii?Q?xeAQD9bWQv26Saf6c9ds7+euK8My8Rw2Iu9wuacjlvCoFi9hg/WbMDHvzJry?=
 =?us-ascii?Q?vLg+bXr69OLBUSF0ersSmdhBgeyg06vyqcozQD8HSTaI5sQLHs06XO7wT4vb?=
 =?us-ascii?Q?zqIYfer8u7VgBAPAWVskR9qOF3x/By4pOT7uzXxwhYDnrGL6CdaqyJvKyo0Z?=
 =?us-ascii?Q?j8u9vui1Vz/ZiODgWIzZ3mFsUJVXLF2B5i3EoSsl?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2469.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07966422-176d-4ba4-94ae-08db2140139c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2023 08:18:49.3084
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uuli/hJnEcypzGjD8LWXOSlr3jFkF/VWsFrtIIu+BYuHMOT2wnCBoaKBWZeQf7PMZvbiNIO7hE0kdNDYu8mxqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5762
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Zhenneng Li
> Sent: Friday, March 10, 2023 3:40 PM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>
> Cc: David Airlie <airlied@linux.ie>; Pan, Xinhui <Xinhui.Pan@amd.com>;
> linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Zhenneng L=
i
> <lizhenneng@kylinos.cn>; amd-gfx@lists.freedesktop.org; Daniel Vetter
> <daniel@ffwll.ch>; Koenig, Christian <Christian.Koenig@amd.com>
> Subject: [PATCH] drm/amdgpu: resove reboot exception for si oland
>=20
> During reboot test on arm64 platform, it may failure on boot.
>=20
> The error message are as follows:
> [    6.996395][ 7] [  T295] [drm:amdgpu_device_ip_late_init [amdgpu]]
> *ERROR*
> 			    late_init of IP block <si_dpm> failed -22
> [    7.006919][ 7] [  T295] amdgpu 0000:04:00.0: amdgpu_device_ip_late_in=
it
> failed
> [    7.014224][ 7] [  T295] amdgpu 0000:04:00.0: Fatal error during GPU i=
nit
> ---
>  drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> index d6d9e3b1b2c0..dee51c757ac0 100644
> --- a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c
> @@ -7632,9 +7632,6 @@ static int si_dpm_late_init(void *handle)
>  	if (!adev->pm.dpm_enabled)
>  		return 0;
>=20
> -	ret =3D si_set_temperature_range(adev);
> -	if (ret)
> -		return ret;

si_set_temperature_range should be platform agnostic. Can you please elabor=
ate more?

Regards,
Guchun

>  #if 0 //TODO ?
>  	si_dpm_powergate_uvd(adev, true);
>  #endif
> --
> 2.25.1