Date:   Fri, 10 Mar 2023 09:36:55 +0100
From:   Christian Brauner <brauner@kernel.org>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] splice: Remove redundant assignment to ret
Message-ID: <20230310083655.w7s4svfoge4cxpnb@wittgenstein>
References: <20230307084918.28632-1-jiapeng.chong@linux.alibaba.com>
 <167835324320.766837.2963092716601467524.b4-ty@kernel.org>
 <20230310034824.GK3390869@ZenIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230310034824.GK3390869@ZenIV>
Precedence: bulk

On Fri, Mar 10, 2023 at 03:48:24AM +0000, Al Viro wrote:
> On Thu, Mar 09, 2023 at 10:15:46AM +0100, Christian Brauner wrote:
> > From: Christian Brauner (Microsoft) <brauner@kernel.org>
> > 
> > 
> > On Tue, 07 Mar 2023 16:49:18 +0800, Jiapeng Chong wrote:
> > > The variable ret belongs to redundant assignment and can be deleted.
> > > 
> > > fs/splice.c:940:2: warning: Value stored to 'ret' is never read.
> > > 
> > > 
> > 
> > Thanks for the cleanup. Seems ok to do so I picked this up,
> > 
> > [1/1] splice: Remove redundant assignment to ret
> >       commit: c3a4aec055ec275c9f860e88d37e97248927d898
> 
> Which branch?

Currently still under

https://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git/ fs.misc

I planned on sending a tag to Linus on Saturday.