Date:   Fri, 10 Mar 2023 09:59:02 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFm?= =?UTF-8?B?YcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH V3] dt-bindings: nvmem: convert base example to use
 "nvmem-layout" node
Message-ID: <20230310095902.33b1d314@xps-13>
In-Reply-To: <20230310075145.3996-2-zajec5@gmail.com>
References: <20230310075145.3996-1-zajec5@gmail.com>
        <20230310075145.3996-2-zajec5@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rafa=C5=82,

zajec5@gmail.com wrote on Fri, 10 Mar 2023 08:51:45 +0100:

> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>=20
> With support for "fixed-layout" binding we can use now "nvmem-layout"
> even for fixed NVMEM cells. Use that in the base example as it should be
> preferred over placing cells directly in the device node.
>=20
> New and other bindings should follow as old binding will get deprecated
> at some point.
>=20
> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
> ---
>  .../devicetree/bindings/nvmem/nvmem.yaml      | 42 +++++++++++--------
>  1 file changed, 24 insertions(+), 18 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documen=
tation/devicetree/bindings/nvmem/nvmem.yaml
> index 732162e9d13e..c77be1c20e47 100644
> --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> @@ -67,24 +67,30 @@ examples:
> =20
>            /* ... */
> =20
> -          /* Data cells */
> -          tsens_calibration: calib@404 {
> -              reg =3D <0x404 0x10>;
> -          };
> -
> -          tsens_calibration_bckp: calib_bckp@504 {
> -              reg =3D <0x504 0x11>;
> -              bits =3D <6 128>;
> -          };
> -
> -          pvs_version: pvs-version@6 {
> -              reg =3D <0x6 0x2>;
> -              bits =3D <7 2>;
> -          };
> -
> -          speed_bin: speed-bin@c{
> -              reg =3D <0xc 0x1>;
> -              bits =3D <2 3>;
> +          nvmem-layout {

I believe we should not introduce "intermediate state" bindings when
this is not strictly required, in order to avoid confusion with what is
backward and what is transitory. So I would expect this to only apply
after the switch to:

	nvmem-layout@xxx {
		reg =3D <xxx>;

I don't care who will take care of it, but I think it would be better
to have everything in one series.

Other than the "order" problematic which I think is important here, I
agree with this series.

> +              compatible =3D "fixed-layout";
> +              #address-cells =3D <1>;
> +              #size-cells =3D <1>;
> +
> +              /* Data cells */
> +              tsens_calibration: calib@404 {
> +                  reg =3D <0x404 0x10>;
> +              };
> +
> +              tsens_calibration_bckp: calib_bckp@504 {
> +                  reg =3D <0x504 0x11>;
> +                  bits =3D <6 128>;
> +              };
> +
> +              pvs_version: pvs-version@6 {
> +                  reg =3D <0x6 0x2>;
> +                  bits =3D <7 2>;
> +              };
> +
> +              speed_bin: speed-bin@c{
> +                  reg =3D <0xc 0x1>;
> +                  bits =3D <2 3>;
> +              };
>            };
>        };
> =20


Thanks,
Miqu=C3=A8l