Message-ID: <49106943-450a-11c0-99ce-159d40471bf2@linaro.org>
Date:   Fri, 10 Mar 2023 10:08:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to
 json-schema
Content-Language: en-US
To:     Aakarsh Jain <aakarsh.jain@samsung.com>,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc:     m.szyprowski@samsung.com, andrzej.hajda@intel.com,
        mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
        ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com,
        benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org,
        stanimir.varbanov@linaro.org, dillon.minfei@gmail.com,
        david.plowman@raspberrypi.com, mark.rutland@arm.com,
        robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org,
        alim.akhtar@samsung.com, aswani.reddy@samsung.com,
        pankaj.dubey@samsung.com
References: <CGME20230301035153epcas5p40f576188a9a69835c1050135219a3720@epcas5p4.samsung.com>
 <20230301035144.8645-1-aakarsh.jain@samsung.com>
 <8b5bea40-6f7b-1d00-ac23-83a28c7dacbc@linaro.org>
 <046b01d94d1a$418146a0$c483d3e0$@samsung.com>
 <9b93849d-d4a4-67ba-e8a0-ee6c7209bd65@linaro.org>
 <000701d95257$e97ebd50$bc7c37f0$@samsung.com>
 <81e78cf6-b8b3-0cab-d190-aa22abbc5c2d@linaro.org>
 <001901d95263$eac4b460$c04e1d20$@samsung.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <001901d95263$eac4b460$c04e1d20$@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/03/2023 09:48, Aakarsh Jain wrote:
>>> won't fit here.
>>> Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone
>> will also break the bindings. Thanks why suggested
>>>          iommus:
>>>            minItems: 1
>>>            maxItems: 2
>>
>> Are you sure you are putting this in correct place? This is if:then for
>> Exynos3250, isn't it?
>>
> Its not only for Exynos3250, its along with Exynos4 since their clock properties are same
> allOf:
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - samsung,mfc-v5        #Exynos4
>               - samsung,exynos3250-mfc
>     then:
>       properties:
>         clocks:
>           maxItems: 2
>         clock-names:
>           items:
>             - const: mfc
>             - const: sclk_mfc
>         iommus:
>           minItems: 1
>           maxItems: 2
> 
> or do I keep different if:then condition for both Exynos3250 and Exynos4 for IOMMUs property ?

Yes, they should be split into two if-then.


Best regards,
Krzysztof