Date:   Fri, 10 Mar 2023 11:30:47 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] asm-generic/io.h: suppress endianness warnings for
 readq() and writeq()
Message-ID: <20230310093047.dneojlst5x4qqgwg@skbuf>
References: <20230109131153.991322-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230109131153.991322-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?trvstMQdkKEjeDl2ZE2QUeYdpTKSdcB04lWkPKmTFBS+7M49oYdS1Q2Jn51P?=
 =?us-ascii?Q?djztIeyj5+79gx+/apcfmq5ev2rDbm6JPb0wb77QWumIr0M0bG4nEuA+1loq?=
 =?us-ascii?Q?s08S5Tpdr1XPnyCSan7C/Sl6hTjOOm5J/j6jp4ut42fc5P/G2nBaLwqhXgZU?=
 =?us-ascii?Q?+7/w7oR2HHC3LN4AdCaHuT1WphUOnEXs3KOzDpkkYrzHrn96gFj2OkW9J6rW?=
 =?us-ascii?Q?OM3oYk1eQDZF7Sl7tUCYqL8olI3w0B2ay/HSs4jjMiEEWY+MP6wyPKd1wPdm?=
 =?us-ascii?Q?u18WZu8NHGCXjCDamhpOWFfhYHK3JmO/rQaB8rsPS+I04TAo50SI8n7wJVyU?=
 =?us-ascii?Q?AuL6/cEQmCHH932IEvKWhrWnerzi1Jkiz75JbEJMGXNa5Ewia+kfqn3CRFFF?=
 =?us-ascii?Q?L91hJtzNMpR3loihj3x8bl3iFTlLwUTmi2bKt2a+GIQN+5dMRJ5zDba7YIpk?=
 =?us-ascii?Q?ULWfUVA29JA1fa9lK95vCVgEpK3vuDoYAXiHjeTU+/AUknEwAol8Y8XsKWP6?=
 =?us-ascii?Q?yfryIU6JhelkKYdh4YTX8YptMyTifzF3msq5eHHivpXiEsRmiL1qsGcW0v9b?=
 =?us-ascii?Q?0Cm9d/n/WyOrtDuyV9P5dS2b1lPmOIemwfND4sCy+t4jmte5o9CIrnb15Sgt?=
 =?us-ascii?Q?F957J7nhkZiWUCygXzmZF2Ma9+SdNF5gAk/xR1r8UoR9Ve7kE52DsN0iBH1z?=
 =?us-ascii?Q?KYhtpGCXEQICTqq9d8Qti2puaUywyv4NG7CPgriuRe1T+Ubk1Hn5ccAEetjN?=
 =?us-ascii?Q?HakCUihrPV3nmbnDjcmjxh4BSMiyzPmVQTz70I0hHGGqsHII3u+CHzi3pfWo?=
 =?us-ascii?Q?uILk9iCcl0w5800V6M1ElRAgA8Gk6wgPpKun6xqdh+J/9KA9c2laoRNeSTHQ?=
 =?us-ascii?Q?UY7dXIhZCS+FJIv8WvGAdqd3vpNapJOkwgDUrvGlC8g8xBlq0+6MVuB1r937?=
 =?us-ascii?Q?JWzlVf3VFiHD2kRDIrIZ39ai6pt3Rx6YNmmyi4m7OcH2SoyEptN9ltxir0yi?=
 =?us-ascii?Q?YLutJPYSLFQFdteTTc7CACSf6XIxTEfqcdFdhczcA+DIswbNNM+Ur2DbL5dH?=
 =?us-ascii?Q?GqUxxd+okXc+vVhPHUigVcg1ROF7KCA6Y2JOxtrB+6O1h3TzwTyNsVP49hfc?=
 =?us-ascii?Q?4ibWtoqlMQgFhYvVKFQmGYLywavrMmALK4y1job3n6L6lTpWN1d6sl74zPZz?=
 =?us-ascii?Q?KtA8hemIjCMoyaSqQx3wyk1IM8KpEnCau8ErAMZkZFnKklq1aRvwO8twcrUV?=
 =?us-ascii?Q?Q6mXiRbgGfmzsKewrFso0+5hJgkHE/SLzOaHXoqLpHBhSZWtyQ+5ecXeyJyW?=
 =?us-ascii?Q?lPiNQiNtADj8pbr3BwbsJU/1oeOk0ahrKb7UIaBrz4zkegOs004zZ1K5zxTc?=
 =?us-ascii?Q?e/BMHdY3U9lAXS3S7Mkd+iKp4y1h7r71EC3yfywJkyPknOTzzBOOi0jpqpaZ?=
 =?us-ascii?Q?Hyv+QhsBrVechDRakOLIK3ROVV8/QxrcUMjPnpT4LaPxFnkHw4BpakuQozHd?=
 =?us-ascii?Q?jN+pCsYUhqI7SgiK+aKYx5rEeB0PF8Sdf4V0VOgzHMlKSjpvQT5nzLnFxttw?=
 =?us-ascii?Q?zLv4VoKyjrag8wgTXpMkqee2gnLltsk8oAQMYYWG9HmZMJJQNc/HMwLu8Ino?=
 =?us-ascii?Q?wg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bae571f3-7878-4628-ab40-08db214a234f
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 09:30:51.0839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3LctyhgtjZFD8npFpBwr/G4m8NGqDpq7k3eTRDyMo209NPnhlJ6q8bc1mkegPpk5JZahW7tG3tuiHParzzaAYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8338
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On Mon, Jan 09, 2023 at 03:11:52PM +0200, Vladimir Oltean wrote:
> Commit c1d55d50139b ("asm-generic/io.h: Fix sparse warnings on
> big-endian architectures") missed fixing the 64-bit accessors.
> 
> Arnd explains in the attached link why the casts are necessary, even if
> __raw_readq() and __raw_writeq() do not take endian-specific types.
> 
> Link: https://lore.kernel.org/lkml/9105d6fc-880b-4734-857d-e3d30b87ccf6@app.fastmail.com/
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  include/asm-generic/io.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
> index 4c44a29b5e8e..d78c3056c98f 100644
> --- a/include/asm-generic/io.h
> +++ b/include/asm-generic/io.h
> @@ -236,7 +236,7 @@ static inline u64 readq(const volatile void __iomem *addr)
>  
>  	log_read_mmio(64, addr, _THIS_IP_, _RET_IP_);
>  	__io_br();
> -	val = __le64_to_cpu(__raw_readq(addr));
> +	val = __le64_to_cpu((__le64 __force)__raw_readq(addr));
>  	__io_ar(val);
>  	log_post_read_mmio(val, 64, addr, _THIS_IP_, _RET_IP_);
>  	return val;
> @@ -287,7 +287,7 @@ static inline void writeq(u64 value, volatile void __iomem *addr)
>  {
>  	log_write_mmio(value, 64, addr, _THIS_IP_, _RET_IP_);
>  	__io_bw();
> -	__raw_writeq(__cpu_to_le64(value), addr);
> +	__raw_writeq((u64 __force)__cpu_to_le64(value), addr);
>  	__io_aw();
>  	log_post_write_mmio(value, 64, addr, _THIS_IP_, _RET_IP_);
>  }
> -- 
> 2.34.1
>

Did these patches get lost?