Date:   Fri, 10 Mar 2023 10:46:15 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFm?= =?UTF-8?B?YcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH V3] dt-bindings: nvmem: convert base example to use
 "nvmem-layout" node
Message-ID: <20230310104615.3cf5de31@xps-13>
In-Reply-To: <9d8ef6df-c0b4-f578-26c3-b186d43c9660@linaro.org>
References: <20230310075145.3996-1-zajec5@gmail.com>
        <20230310075145.3996-2-zajec5@gmail.com>
        <9d8ef6df-c0b4-f578-26c3-b186d43c9660@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Srinivas,

srinivas.kandagatla@linaro.org wrote on Fri, 10 Mar 2023 09:29:18 +0000:

> On 10/03/2023 07:51, Rafa=C5=82 Mi=C5=82ecki wrote:
> > From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
> >=20
> > With support for "fixed-layout" binding we can use now "nvmem-layout"
> > even for fixed NVMEM cells. Use that in the base example as it should be
> > preferred over placing cells directly in the device node.
> >  =20
> Fixed layouts are the core part of nvmem, am not sure why you want to dep=
recate this. Either we derive the cell information dt or via layouts or som=
e post processing they should still endup as fixed layouts.
> this way the core part is always same irrespective of where the cell info=
 comes from.

Actually I was suspicious as first but we had a very similar case in
mtd:
- People need partitioning so we add partitions in the mtd node
- People need more advanced partitioning and partitioning becomes a
  mess so we containerize everything in a "partitions" subnode.
  It definitely improves the readability and makes the code more
  resilient: outside of the container, it's not a partition, period.

I believe that's what Rafa=C5=82 is trying to anticipate. Just moving the
fixed cells declaration into a container (and we have one already:
nvmem-layout).

Thanks,
Miqu=C3=A8l