Message-ID: <f5b3de20-797c-4ff6-a85b-06c85b4eaa1b@amd.com>
Date:   Fri, 10 Mar 2023 15:28:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC/PATCHSET 0/9] perf record: Implement BPF sample filter (v4)
Content-Language: en-US
To:     Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Song Liu <song@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Leo Yan <leo.yan@linaro.org>,
        James Clark <james.clark@arm.com>, Hao Luo <haoluo@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230307233309.3546160-1-namhyung@kernel.org>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20230307233309.3546160-1-namhyung@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHBUeGRFNzkyejloaXMzN2RILzIwUkplZE9ib0R2NGIyZjQ5Yk5SeEwzODVj?=
 =?utf-8?B?TGR3YjMxRWpzdEY0b3NPY0tkQnlncEtGbjg0RWtqcmZQdW1VenFZL2NMRXgw?=
 =?utf-8?B?Vm5VbWMzNXdtY0xkU2NwTG9TMXlKbGY3UGZvaWhxU3RrZk8zQjVaWkl6UWFn?=
 =?utf-8?B?RzJiVVZzc0JVVW1xK2hhOWJhSVlGSFFHemdnSkJMbmxJUk5NaU02b01MK3E5?=
 =?utf-8?B?bDZhUkR0OXdYN0thY1V3TEozeXdrMCticHdrMmxEWWJjSm0zREhkNmkxMXd3?=
 =?utf-8?B?RGN1OURpWWZVcVN4T0RFOWpOWHpLdUo1bkZ2NDRKd0ZId3BQbUZIcFZFQzFT?=
 =?utf-8?B?dVZUaUk1MDJyYnRBNE8zSjlxb2ZBTEdndXJndExoSlVGamdpTXU3dFU1U0w5?=
 =?utf-8?B?dU10cmljdUxiKzBLMjl0N3BoYk9OVTlWcUVPakJCODRhbkY0aGkxcjB4VFFn?=
 =?utf-8?B?NFlRMnFPTUg4UWNxTmY0Q3IvK0FxelY2dXFHRTl6SEJldjkxNHNjMjBzVWlM?=
 =?utf-8?B?eE1HVEJrUXRRK2dVeFdWZkk5NmpYdmxFR0pMK0REWjVyZDkxSW43RGpWSW1S?=
 =?utf-8?B?WDF6aXVTSDU4UDBndlJNRHJja0lSbGEzVGJhcGxlSlFaRTlTT2o0QXRLaEZp?=
 =?utf-8?B?Zms0d2FKMDVSbmNtQmRQQ3k5N3oxMVFjNkhvcmlJUWRQMXBaclU5WU9qZDlu?=
 =?utf-8?B?b0hzVDRmcFJnK2dEYVlETXF2NHFPczlPQ1ZoYlJYVHpzK3VoNGVvSUhRTTNH?=
 =?utf-8?B?eE96ZXlVekthVEpZajhoU3BDem8yVTFEZDFGckdmOHhnN1BpSDE3QzQrZllt?=
 =?utf-8?B?V0tYcFcvZmpSSGhDbzVYYkhMYmZXR0VCelVOMUJrYmJUMUVpSk1BY1E2Rnha?=
 =?utf-8?B?SzBmb3BqaDJxSTdrNFhlNE5oNEhwWTdVbXcyMEJnbVdxYUdJNUxLNVllaE40?=
 =?utf-8?B?QWgzeGFTdW5yRkYrS3VYTGR3MGordVBrNVJxL0NBZllGYVFFQ3RnZEljZnUy?=
 =?utf-8?B?VXBCd1pKSUN1cDNvU25qSDd3RjMzRFQ4MHQ0Yzl5SkRGaThnamVORWJzSHh3?=
 =?utf-8?B?aXo5TkVDc3JnOEx5OHVYdkdOUC9rUFUxbUxJMUkyZzY3MDlNcUE3SXJkUjVn?=
 =?utf-8?B?NHFyVUNZaHJ6RzZvbzR2VVVnaC9VZ0xkK3djYXR4Vmh5aUltbk15bURkUTQ1?=
 =?utf-8?B?K25KZjRSRDBqQ0FVaHA4YlA5UFBxQWM2cC9PTW9mTTgrNlRNWlFzdlJ0VnRs?=
 =?utf-8?B?clNGWjVjL0Izano3QVpybFExbjZxQnRMbktzMnBGUGU2NTNOb2ROQW1iMmY1?=
 =?utf-8?B?V0pvWTZEeE9wcjFBMzFaSWcxNVVoSldLU01ybUFyMjBEWXJ6d3VKR0g1VGI5?=
 =?utf-8?B?aUJEY1FVVU5idFVaSVBQMzdZSXBmM0VYVzJTdkRWNjFLTW90RXNyaFcvZ3FY?=
 =?utf-8?B?b3lHQVZGTk5ybjZPeVJmUHpNN1BsMVA3M2g2cU5YUTZ0L1JxdXlUNWUvQ3Jm?=
 =?utf-8?B?UnZDWjdlb1JMRmdvVGdWMnBzeWVQcDVNZ2FQUVNnSXo0WmV1am5RZTdFL21i?=
 =?utf-8?B?MGdlTkx6VnRVeHhaT0Nld2tOMXdCekNrR3FqWFFjUkwrOFB4d2ZSMmlHVFNq?=
 =?utf-8?B?TDZ6UU1iL3F3R01ITmVXS1QxSkFXajkvaUVHMHRFcWRNSVpaejA5SUJvUnI3?=
 =?utf-8?B?eUFSby9TT3YwdVdZeG1nR0hoY0pZSjBrbHhFdkFqSmxFekZicVZ5by94Vzlw?=
 =?utf-8?B?TEZmWGMxb2tQTmtaUmpTTzFxVjU2WlF6QW1PR0JPRVE0S3BDRStoM21SWUY5?=
 =?utf-8?B?L2R5K2czUXVaU3crQld6TE5QU2hBNEhBVlFSTWRvUFBwWmM2QmV6UWlyYmFm?=
 =?utf-8?B?ZFQwbFhDUW5ScjBmRjZocmowblBFaDVGVVJIR2pIM29MSU55TlVHL2c0Si9W?=
 =?utf-8?B?UlRPbWtWcnVhc29ZTktoaUF5Zm9tK1VCN2pVWXlPYjN0RnliVFBEWm82dkd2?=
 =?utf-8?B?TklCYUJpTTA1SCtRSURsWlpoc3R4SWp3aFAxNEdoZ3hCbGxCWURFbm9ZQUNr?=
 =?utf-8?B?NFBCSS9hTkRablBiNnFydlhTMXJReWFwQ0FPSElFUHhTSTc4dEFMdTkyNkZF?=
 =?utf-8?Q?BxieJLZPfsiBR5wjnHAOKoxVi?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d312a47-db2e-4637-72e5-08db214df943
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 09:58:18.4951
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4PGrDW9FW29lenz3xVqNjvCOkUwNqgHCo6N3eHEWLUUrY4X6OASitbViGENoKWHSYZBvn95TJbjauI4OSswTVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8092
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> It requires samples satisfy all the filter expressions otherwise it'd
> drop the sample.  IOW filter expressions are connected with logical AND
> operations unless they used "||" explicitly.  So if user has something
> like 'A, B || C, D', then BOTH A and D should be true AND either B or C
> also needs to be true.
> 
> Essentially the BPF filter expression is:
> 
>   <term> <operator> <value> (("," | "||") <term> <operator> <value>)*
> 
> The <term> can be one of:
>   ip, id, tid, pid, cpu, time, addr, period, txn, weight, phys_addr,
>   code_pgsz, data_pgsz, weight1, weight2, weight3, ins_lat, retire_lat,
>   p_stage_cyc, mem_op, mem_lvl, mem_snoop, mem_remote, mem_lock,
>   mem_dtlb, mem_blk, mem_hops
> 
> The <operator> can be one of:
>   ==, !=, >, >=, <, <=, &
> 
> The <value> can be one of:
>   <number> (for any term)
>   na, load, store, pfetch, exec (for mem_op)
>   l1, l2, l3, l4, cxl, io, any_cache, lfb, ram, pmem (for mem_lvl)
>   na, none, hit, miss, hitm, fwd, peer (for mem_snoop)
>   remote (for mem_remote)
>   na, locked (for mem_locked)
>   na, l1_hit, l1_miss, l2_hit, l2_miss, any_hit, any_miss, walk, fault (for mem_dtlb)
>   na, by_data, by_addr (for mem_blk)
>   hops0, hops1, hops2, hops3 (for mem_hops)

I think this and few examples should be added in perf-record man page.

Thanks,
Ravi