MIME-Version: 1.0
References: <20230310101715.69209-1-slark_xiao@163.com> <20230310103126.GA6838@thinkpad>
In-Reply-To: <20230310103126.GA6838@thinkpad>
From:   Fabio Porcedda <fabio.porcedda@gmail.com>
Date:   Fri, 10 Mar 2023 11:33:56 +0100
Message-ID: <CAHkwnC_S_qPOfkoJ-uZ7GNW4J26AXik=33f2=uMfw72yFOFXLg@mail.gmail.com>
Subject: Re: [PATCH] bus: mhi: host: pci_generic: Revert "Add a secondary AT
 port to Telit FN990"
To:     Manivannan Sadhasivam <mani@kernel.org>
Cc:     Slark Xiao <slark_xiao@163.com>, loic.poulain@linaro.org,
        mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Il giorno ven 10 mar 2023 alle ore 11:31 Manivannan Sadhasivam
<mani@kernel.org> ha scritto:
>
> On Fri, Mar 10, 2023 at 06:17:15PM +0800, Slark Xiao wrote:
> > This reverts commit 2d5253a096c6057bbf7caa5520856dcdf7eca8bb.
> > There are 2 commits with commit message "Add a secondary AT
> > port to Telit FN990". But the last one 2d5253a096 was added
>
> Btw, we usually refer the commit SHA by 12 digits. Like, 2d5253a096c6.
> I can fix it up while applying.
>
> > on Foxconn devices. Actually the second AT port of Foxconn
> > devices doesn't work in PCIe mode. And the commit message
> > mismatch with the changes. So we need to remove it.
> >
>
> Sigh... the subject itself was wrong :( thanks for catching.
>
> > Signed-off-by: Slark Xiao <slark_xiao@163.com>
>
> For future Foxconn patches, please help with the review to catch issues l=
ike
> this. Unfortunately, I do not own any Foxconn modems :/
>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Reviewed-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Just to clarify, the original patch change just the Telit FN990:
https://lore.kernel.org/netdev/CAMZdPi8gGrbkKnDR+WLadF92shJbwH-ksQY+dbpgfZ2=
1iAp9ug@mail.gmail.com/

The problem is caused by the fact that it was merged two times and the
second time was merged wrongly.
The correct one is commit 479aa3b0ec2e000ac99dd0661936d9685d6cac64 and
the wrong one is 2d5253a096c6057bbf7caa5520856dcdf7eca8bb.

BR
Fabio

> Thanks,
> Mani
>
> > ---
> >  drivers/bus/mhi/host/pci_generic.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/=
pci_generic.c
> > index 6e13c43a84d1..91d02f84ba21 100644
> > --- a/drivers/bus/mhi/host/pci_generic.c
> > +++ b/drivers/bus/mhi/host/pci_generic.c
> > @@ -343,8 +343,6 @@ static const struct mhi_channel_config mhi_foxconn_=
sdx55_channels[] =3D {
> >       MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> >       MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> >       MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> > -     MHI_CHANNEL_CONFIG_UL(92, "DUN2", 32, 1),
> > -     MHI_CHANNEL_CONFIG_DL(93, "DUN2", 32, 1),
> >       MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> >       MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> >  };
> > --
> > 2.34.1
> >
>
> --
> =E0=AE=AE=E0=AE=A3=E0=AE=BF=E0=AE=B5=E0=AE=A3=E0=AF=8D=E0=AE=A3=E0=AE=A9=
=E0=AF=8D =E0=AE=9A=E0=AE=A4=E0=AE=BE=E0=AE=9A=E0=AE=BF=E0=AE=B5=E0=AE=AE=
=E0=AF=8D


--=20
Fabio Porcedda