Date:   Fri, 10 Mar 2023 11:45:34 +0100
From:   Lorenzo Pieralisi <lpieralisi@kernel.org>
To:     Xi Ruoyao <xry111@xry111.site>
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Xiaowei Song <songxiaowei@huawei.com>, stable@vger.kernel.org
Subject: Re: Ping: [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN
Message-ID: <ZAsKThAQPbGVUig8@lpieralisi>
References: <20230228043423.19335-1-xry111@xry111.site>
 <8996e9ba32cbdc24b828c9a37793b39f17eb33a8.camel@xry111.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8996e9ba32cbdc24b828c9a37793b39f17eb33a8.camel@xry111.site>
Precedence: bulk

On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote:
> Gentle ping.
> 
> On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote:
> > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to
> > select
> > REGMAP_MMIO or vmlinux fails to link with "undefined reference to
> > `__devm_regmap_init_mmio_clk`.
> > 
> > Cc: stable@vger.kernel.org?# at least for 6.1 and 6.2

I merged this (with a rewritten commit log, Fixes tag and
CC stable - please have a look and check how this has to
be written for future submissions):

https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org

This patch is dropped.

Thanks,
Lorenzo

> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> > ---
> > ?drivers/pci/controller/dwc/Kconfig | 1 +
> > ?1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/Kconfig
> > b/drivers/pci/controller/dwc/Kconfig
> > index 434f6a4f4041..d29551261e80 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -307,6 +307,7 @@ config PCIE_KIRIN
> > ????????tristate "HiSilicon Kirin series SoCs PCIe controllers"
> > ????????depends on PCI_MSI
> > ????????select PCIE_DW_HOST
> > +???????select REGMAP_MMIO
> > ????????help
> > ????????? Say Y here if you want PCIe controller support
> > ????????? on HiSilicon Kirin series SoCs.
> 
> -- 
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University