Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbXIOMZW (ORCPT ); Sat, 15 Sep 2007 08:25:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751396AbXIOMZJ (ORCPT ); Sat, 15 Sep 2007 08:25:09 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:37975 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbXIOMZH (ORCPT ); Sat, 15 Sep 2007 08:25:07 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <46EBCEF1.4030702@s5r6.in-berlin.de> Date: Sat, 15 Sep 2007 14:24:17 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070807 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Adrian Bunk CC: Sam Ravnborg , James Bottomley , linux-scsi@vger.kernel.org, Jeff Garzik , Andi Kleen , Folkert van Heusden , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] SCSI: split Kconfig menu into two References: <46E46190.6080607@garzik.org> <20070912224655.GC3563@stusta.de> <46EAA08F.30703@s5r6.in-berlin.de> <20070914151522.GL3563@stusta.de> <46EAAAC1.3050409@s5r6.in-berlin.de> <20070914190033.GA4003@uranus.ravnborg.org> <20070914190609.GN3563@stusta.de> <20070915114055.GP3563@stusta.de> In-Reply-To: <20070915114055.GP3563@stusta.de> X-Enigmail-Version: 0.95.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2530 Lines: 90 Adrian Bunk wrote: > On Fri, Sep 14, 2007 at 10:01:18PM +0200, Stefan Richter wrote: >> drivers/Kconfig | 4 >> drivers/scsi/Kconfig | 1589 ---------------------------------- >> drivers/scsi/Kconfig.lowlevel | 1578 +++++++++++++++++++++++++++++++++ >> 3 files changed, 1588 insertions(+), 1583 deletions(-) > > Nearly right. ;-) > > There are a few architectures not (yet) using drivers/Kconfig. Right, the patch is wrong for those architectures which include drivers/scsi/Kconfig directly, rather than indirectly via drivers/Kconfig. [...] >> # drivers/Kconfig >> >> +source "drivers/scsi/Kconfig" >> + >> menu "Device Drivers" >> >> source "drivers/base/Kconfig" >> @@ -22,7 +24,7 @@ source "drivers/misc/Kconfig" >> >> source "drivers/ide/Kconfig" >> >> -source "drivers/scsi/Kconfig" >> +source "drivers/scsi/Kconfig.lowlevel" >> >> source "drivers/ata/Kconfig" >> ... > > This way the order is wrong: > > There should first be the lowlevel SCSI, SATA, USB etc. drivers, these > drivers should select CONFIG_SCSI, and then the menu offering support > for disk, CD,... The order was inspired by # the protocols etc. "Networking" # the interconnects "Device Drivers"/ "Network device support" So that order is wrong too? However, there is also precedence for the order which you suggest: The partition and filesystems options come after device driver options. [...] >> +menu "Storage (core and SCSI commands)" >> >> config SCSI >> - tristate "SCSI device support" >> + tristate "Storage support (core and SCSI commands)" >> depends on BLOCK >> select SCSI_DMA if HAS_DMA >> ---help--- >> ... > > What is "storage support"? > SATA? > PATA? > USB mass storage? > MMC? > MTD? What is "Networking"? Ethernet? Infiniband? ...? > Whether or not a driver uses the SCSI layer is an implementation detail > (it even differs for the two USB mass storage implementations and the > two PATA implementations in the kernel) the user shouldn't have to know > about. > > I don't see any reason why CONFIG_SCSI should have to stay user-visible > at all after your patch. Vice versa, I don't see any reason for "select SCSI" anywhere after my patch. -- Stefan Richter -=====-=-=== =--= -==== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/