Date:   Fri, 10 Mar 2023 12:16:02 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v3 17/20] nvmem: layouts: sl28vpd: Add new layout driver
Message-ID: <20230310121602.109c58e7@xps-13>
In-Reply-To: <54e7ee75-6035-c2e9-fb8b-fe96adbb571a@linaro.org>
References: <20230308153200.682248-1-miquel.raynal@bootlin.com>
        <20230308153200.682248-18-miquel.raynal@bootlin.com>
        <54e7ee75-6035-c2e9-fb8b-fe96adbb571a@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Srinivas,

srinivas.kandagatla@linaro.org wrote on Fri, 10 Mar 2023 11:03:45 +0000:

> On 08/03/2023 15:31, Miquel Raynal wrote:
> > +
> > +static int __init sl28vpd_init(void)
> > +{
> > +	return nvmem_layout_register(&sl28vpd_layout);
> > +}
> > +
> > +static void __exit sl28vpd_exit(void)
> > +{
> > +	nvmem_layout_unregister(&sl28vpd_layout);
> > +}
> > +
> > +module_init(sl28vpd_init);
> > +module_exit(sl28vpd_exit); =20
> Looking at this pattern in two drivers, we could come up with some helper=
 macro like.
>=20
> #define module_nvmem_layout_driver(__layout_driver) \
>          module_driver(__layout_driver, nvmem_layout_register, \
>                          nvmem_layout_unregister)

Nice idea! I will make a patch; is it okay do it on top?

Thanks,
Miqu=C3=A8l