MIME-Version: 1.0
Date:   Fri, 10 Mar 2023 12:00:20 +0100
From:   =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v3 09/20] nvmem: core: introduce NVMEM layouts
In-Reply-To: <2580b45b-5d66-d716-41f3-4050236e89c2@linaro.org>
References: <20230308153200.682248-1-miquel.raynal@bootlin.com>
 <20230308153200.682248-10-miquel.raynal@bootlin.com>
 <2580b45b-5d66-d716-41f3-4050236e89c2@linaro.org>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <a6762585dbd135a641a9bd2ff9f15697@milecki.pl>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-03-10 11:55, Srinivas Kandagatla wrote:
> On 08/03/2023 15:31, Miquel Raynal wrote:
>> +const void *nvmem_layout_get_match_data(struct nvmem_device *nvmem,
>> +					struct nvmem_layout *layout)
>> +{
>> +	struct device_node __maybe_unused *layout_np;
>> +	const struct of_device_id *match;
>> +
>> +	layout_np = of_nvmem_layout_get_container(nvmem);
>> +	match = of_match_node(layout->of_match_table, layout_np);
>> +
>> +	return match ? match->data : NULL;
>> +}
>> +EXPORT_SYMBOL_GPL(nvmem_layout_get_match_data);
> 
> who is the user of this function, in the current patchset I see none?

This will be required for the U-Boot env layout, see:
[PATCH V3 4/6] nvmem: u-boot-env: convert to layout driver


> On the other hand interpretation of match data is pretty much driver
> specific i see no reason for this to be in core.

Interpretation: yes. It's driver specific.

Getting that struct however belongs to the core. We have all kind of
helpers for getting driver private data. Those helpers live in some core
code of subsystems.