Date:   Fri, 10 Mar 2023 12:28:50 +0100
From:   Francois Romieu <romieu@fr.zoreil.com>
To:     Gencen Gan <u202011061@gmail.com>
Cc:     Chas Williams <3chas3@gmail.com>, Dongliang Mu <dzm91@hust.edu.cn>,
        linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: he: fix potential ioremap leak of membase in he_dev
Message-ID: <20230310112850.GA424646@electric-eye.fr.zoreil.com>
References: <20230310102256.1130846-1-u202011061@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230310102256.1130846-1-u202011061@gmail.com>
Precedence: bulk

Gencen Gan <u202011061@gmail.com> :
> In the function he_start() in drivers/atm/he.c, there
> is no unmapping of he_dev->membase in the branch that
> exits due to an error like reset failure, which may
> cause a memory leak.

Why would he_dev->membase not be unmapped in he_stop() ?

he_stop() is paired with he_start() as soon a he_start() returns
anything different from 0 in he_init_one(). I see no other place
where he_start() is used.

The atm_dev/he_dev pointers also seem correctly set.

-- 
Ueimor