Message-ID: <7fc2206d-ddb0-5817-ac6a-51d41803f691@linaro.org>
Date:   Fri, 10 Mar 2023 11:43:34 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v3 17/20] nvmem: layouts: sl28vpd: Add new layout driver
Content-Language: en-US
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org
References: <20230308153200.682248-1-miquel.raynal@bootlin.com>
 <20230308153200.682248-18-miquel.raynal@bootlin.com>
 <54e7ee75-6035-c2e9-fb8b-fe96adbb571a@linaro.org>
 <20230310121602.109c58e7@xps-13>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20230310121602.109c58e7@xps-13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10/03/2023 11:16, Miquel Raynal wrote:
> Hi Srinivas,
> 
> srinivas.kandagatla@linaro.org wrote on Fri, 10 Mar 2023 11:03:45 +0000:
> 
>> On 08/03/2023 15:31, Miquel Raynal wrote:
>>> +
>>> +static int __init sl28vpd_init(void)
>>> +{
>>> +	return nvmem_layout_register(&sl28vpd_layout);
>>> +}
>>> +
>>> +static void __exit sl28vpd_exit(void)
>>> +{
>>> +	nvmem_layout_unregister(&sl28vpd_layout);
>>> +}
>>> +
>>> +module_init(sl28vpd_init);
>>> +module_exit(sl28vpd_exit);
>> Looking at this pattern in two drivers, we could come up with some helper macro like.
>>
>> #define module_nvmem_layout_driver(__layout_driver) \
>>           module_driver(__layout_driver, nvmem_layout_register, \
>>                           nvmem_layout_unregister)
> 
> Nice idea! I will make a patch; is it okay do it on top?
sounds good

--srini
> 
> Thanks,
> Miquèl