From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Khadija Kamran <kamrankhadijadj@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        paskripkin@gmail.com, gregkh@linuxfoundation.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment
Date:   Fri, 10 Mar 2023 12:52:55 +0100
Message-ID: <10238267.qUNvkh4Gvn@suse>
In-Reply-To: <Y+8p7Hyaf4LhO/Sw@khadija-virtual-machine>
References: <Y+8p7Hyaf4LhO/Sw@khadija-virtual-machine>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On venerd=EC 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
>=20
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>=20

Hi Khadija,

As Greg said this driver is not here any longer. This makes me think that y=
ou=20
forgot at least two things...

1) Please pull and rebase the staging tree every day while working on patch=
es=20
during this period of the Outreachy project. If you had done so, you would=
=20
have noticed that your patch cannot any more be applied.

2) I saw this patch by pure luck because you forgot to Cc the Outreachy lis=
t.=20
Therefore, please don't ever forget to Cc that list. Most mentors don't=20
subscribe the linux-staging list.

Thanks,

=46abio

P.S.: Please use an imperative tone, both in the subject and in the commit=
=20
message. For example this patch could have been written the following way:

staging: axis-fifo: Add "*" to multi-line comment

Add asterisks to each line of a multi-line comment to conform to the Linux=
=20
development guidelines. Warning reported by checkpatch.pl.

Signed-off-by: [...]