Date:   Fri, 10 Mar 2023 15:09:54 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Khadija Kamran <kamrankhadijadj@gmail.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        paskripkin@gmail.com, gregkh@linuxfoundation.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment
Message-ID: <bb4e7ac8-5ddf-46c7-8c5a-08839794c5d0@kili.mountain>
References: <Y+8p7Hyaf4LhO/Sw@khadija-virtual-machine>
 <10238267.qUNvkh4Gvn@suse>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <10238267.qUNvkh4Gvn@suse>
Precedence: bulk

On Fri, Mar 10, 2023 at 12:52:55PM +0100, Fabio M. De Francesco wrote:
> On venerd? 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> > Fixed block comment by adding '*' in each line. The Check message was
> > shown by using checkpatch.pl script.
> > 
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > ---
> >  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
> >  1 file changed, 10 insertions(+), 9 deletions(-)
> > 
> 
> Hi Khadija,
> 
> As Greg said this driver is not here any longer. This makes me think that you 
> forgot at least two things...
> 
> 1) Please pull and rebase the staging tree every day while working on patches 
> during this period of the Outreachy project. If you had done so, you would 
> have noticed that your patch cannot any more be applied.

This patch was sent long before the driver was deleted...  The patch was
fine and would have been applied if the driver hadn't been removed.

regards,
dan carpenter