From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Dan Carpenter <error27@gmail.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Khadija Kamran <kamrankhadijadj@gmail.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        paskripkin@gmail.com, gregkh@linuxfoundation.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment
Date:   Fri, 10 Mar 2023 13:25:50 +0100
Message-ID: <3436236.som1txNFv6@suse>
In-Reply-To: <bb4e7ac8-5ddf-46c7-8c5a-08839794c5d0@kili.mountain>
References: <Y+8p7Hyaf4LhO/Sw@khadija-virtual-machine> <10238267.qUNvkh4Gvn@suse>
 <bb4e7ac8-5ddf-46c7-8c5a-08839794c5d0@kili.mountain>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On venerd=EC 10 marzo 2023 13:09:54 CET Dan Carpenter wrote:
> On Fri, Mar 10, 2023 at 12:52:55PM +0100, Fabio M. De Francesco wrote:
> > On venerd=EC 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> > > Fixed block comment by adding '*' in each line. The Check message was
> > > shown by using checkpatch.pl script.
> > >=20
> > > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > > ---
> > >=20
> > >  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
> > >  1 file changed, 10 insertions(+), 9 deletions(-)
> >=20
> > Hi Khadija,
> >=20
> > As Greg said this driver is not here any longer. This makes me think th=
at
> > you
> > forgot at least two things...
> >=20
> > 1) Please pull and rebase the staging tree every day while working on
> > patches
> > during this period of the Outreachy project. If you had done so, you wo=
uld
> > have noticed that your patch cannot any more be applied.
>=20
> This patch was sent long before the driver was deleted...  The patch was
> fine and would have been applied if the driver hadn't been removed.
>=20
> regards,
> dan carpenter

I'm sorry I did not look at the day of the submission.
I took for granted that this patch had been sent after the contribution per=
iod=20
start date, March 6th 2023.

Thanks Dan for making me notice this mistake.

Regards,

=46abio