Date:   Fri, 10 Mar 2023 14:21:10 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regmap: cache: Do not panic for REGCACHE_NONE regmap
Message-ID: <ZAs81tPqVruM4eAL@sirena.org.uk>
References: <20230310073911.3470892-1-alexander.stein@ew.tq-group.com>
 <ZAsqVf8/C3lHOF8W@sirena.org.uk>
 <2399331.NgBsaNRSFp@steina-w>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0TCfB71qknqSkwp3"
Content-Disposition: inline
In-Reply-To: <2399331.NgBsaNRSFp@steina-w>
Precedence: bulk


--0TCfB71qknqSkwp3
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 10, 2023 at 02:35:13PM +0100, Alexander Stein wrote:
> Am Freitag, 10. M=E4rz 2023, 14:02:13 CET schrieb Mark Brown:

> > Why would we be trying to do a regcache_sync() on a device with
> > no cache?

> Indeed, that makes no sense. That's indicating a bug in a driver, but why=
 do=20
> we need to panic the kernel in this case?

You're trying to change this to silently ignore the call which
isn't going to make anything happy.

> On the other hand the same question applies to other regcache related=20
> functions currently checking for non-cached maps. There is no common=20
> behaviour:

> panic:
> * regcache_sync
> * regcache_sync_region

These are only ever triggered from a client driver, nothing in
regmap will ever sync the regmap without being explicitly asked
to.

> returning -ENOSYS:
> * regcache_read

> returning success (0):
> * regcache_write

> early return (void return value):
> * regcache_exit

These are all called transparently as part of the regmap core
regardless of if there is a cache, users never directly read or
write values to the cache.

--0TCfB71qknqSkwp3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQLPNMACgkQJNaLcl1U
h9AcKgf9HL9YmHGsi3fCUMbzj++jdY38ZNLOx+XJVSlMlyBEz1zYkh6nzokE1Y+1
h+msQY+YaReDKwm3H8V4E9Q+PVbRYql66VyKjlmDQs69+NCAgJMkyajeUCMIX/Ko
UBYhn9kG0/S3x3Tt6pzoClV9pVzIeC03pmMh67pm6t05v/q1ae+lGtdYaag5oAt5
VdB8P1Tvs76dJ2k6X5BuoewsUyLpzioiW3MUMcJZG75Tp2bMRoJPVJZNVIKCKKJ/
F/VR/SQQf9USDRg+uR0hqLFERzEsu7fyZotL6MiAooq0QkafAfvJKS0TOmh8LVTY
P7N5gXlc1x/Qnj/Iv4z5aKBeHnL7jg==
=uH7+
-----END PGP SIGNATURE-----

--0TCfB71qknqSkwp3--