Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 10 Mar 2023 15:23:36 +0100
Message-Id: <CR2RS3YFFQTR.39A2C0SLRBJQY@vincent-arch>
Cc:     "Arnd Bergmann" <arnd@arndb.de>,
        "Russell King" <linux@armlinux.org.uk>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dyndbg: allow including dyndbg.h in decompressor
From:   "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To:     "Arnd Bergmann" <arnd@kernel.org>,
        "Luis Chamberlain" <mcgrof@kernel.org>,
        "Jason Baron" <jbaron@akamai.com>
References: <20230310140133.291594-1-arnd@kernel.org>
In-Reply-To: <20230310140133.291594-1-arnd@kernel.org>
Precedence: bulk

> From: Arnd Bergmann <arnd@arndb.de>
>
> After a change to linux/module.h, dyndbg.h is now included
> indirectly from the decompressor for lz4 support, which in turn
> causes a build failure on 32-bit Arm:
>
> In file included from include/linux/module.h:30,
>                  from arch/arm/boot/compressed/../../../../lib/lz4/lz4_de=
compress.c:39,
>                  from arch/arm/boot/compressed/../../../../lib/decompress=
_unlz4.c:10,
>                  from arch/arm/boot/compressed/decompress.c:59:
> include/linux/dynamic_debug.h: In function 'ddebug_dyndbg_module_param_cb=
':
> include/linux/dynamic_debug.h:307:14: error: implicit declaration of func=
tion 'strcmp' [-Werror=3Dimplicit-function-declaration]
>   307 |         if (!strcmp(param, "dyndbg")) {
>       |              ^~~~~~
> include/linux/dynamic_debug.h:1:1: note: 'strcmp' is defined in header '<=
string.h>'; did you forget to '#include <string.h>'?
>   +++ |+#include <string.h>
>
> The decompressor has its own replacement for the linux/string.h contents,
> so the normal declaration is not visible here. Since the function is
> not actually called, it is sufficient to add a declaration, and this
> is in fact the correct one as it matches the definition in
> arch/arm/boot/compressed/string.c.
>
> Fixes: 7deabd674988 ("dyndbg: use the module notifier callbacks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>