Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF12AC6FD1F for ; Fri, 10 Mar 2023 15:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233621AbjCJPIw (ORCPT ); Fri, 10 Mar 2023 10:08:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233777AbjCJPIS (ORCPT ); Fri, 10 Mar 2023 10:08:18 -0500 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A36EF12CBD5; Fri, 10 Mar 2023 07:01:02 -0800 (PST) Received: by mail-qt1-x835.google.com with SMTP id d7so5867899qtr.12; Fri, 10 Mar 2023 07:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678460394; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Cv0nqeG9ewE2ohDmFuTFqHY0vUZH9hoFb51iUvscY0c=; b=czmwilVn5p14xCmVVmK12l5bW3SJulgEzJIVeTAvcmSZHya1bN7nn1VHMo/qo+ZV0j R1aVo5tbFBhVmWbNyZ6Aa0vwDumsTMpbeI1sL0W6tjTbKsAeUlgDaOomPqB7kzlreRrI lLd3/xgAgYYfBbNxB7N8Fc7bfeHHVlDXPqAPa/EQhn2Jo3xJIKZ1JwZ6pnVmBhl5f1fX iw0uQSqQeGxYe5KEQhgJwffySbWy6tfYqNYCowVe78GEEYL9zEM+wU2CTK31wkNbs9Is Jd7stn7USKoQsKVI4pkewP4M6DbPErGumTajyR7XuktUZ3Y9eAFCrzhPVs6kpcKkyJoK 2aMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678460394; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Cv0nqeG9ewE2ohDmFuTFqHY0vUZH9hoFb51iUvscY0c=; b=ABCny72qg2l/7cBCFiMInPp8AFR2RhsZGRRhQ7+/pIy/Y+o23mjOspH7Dd/obbRrM3 NAsOePGKER1CpaFziMysxlBlT9lF94PzgCPChkf1eQh+vdQXnW2+OZ7xdO9r0gnwz/3L 9/x5JuImducbcORx46rlnleM7k5GX71udEyaXWfMO31cCrHsCyjJ9MP90mEHnlpEBy8P D/qG56UQxuUJdvi1J/0Mac06ftoX+Dcu6z36z+tNwuJ8/ZeO3LZvJH5i8atB3VYIXQgp VvIp7pD0LzVAMUoXFjxnnIxWuwvkpYGlX+VK7BHWMR0TKg9mHm43vqkFd1kqcR1EhpFH mIyA== X-Gm-Message-State: AO0yUKWQFZeIpEQv3ubyUdFVRWyB7bVDVZtRkgNCdcgWgBW2SO45c3g9 H16ST8eadqURhnOn1a8g+LA= X-Google-Smtp-Source: AK7set+f+qUvbUmt/KzHLVUZlrsvvPrMFwM1YJAYDf8D1odORfl6fghTzRM20US5VWKyKujUjePzqQ== X-Received: by 2002:ac8:5794:0:b0:3b9:bc8c:c202 with SMTP id v20-20020ac85794000000b003b9bc8cc202mr4414727qta.13.1678460394748; Fri, 10 Mar 2023 06:59:54 -0800 (PST) Received: from localhost (240.157.150.34.bc.googleusercontent.com. [34.150.157.240]) by smtp.gmail.com with ESMTPSA id d207-20020a3768d8000000b0073df51b5127sm1472389qkc.43.2023.03.10.06.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 06:59:54 -0800 (PST) Date: Fri, 10 Mar 2023 09:59:53 -0500 From: Willem de Bruijn To: =?UTF-8?B?S8O2cnkgTWFpbmNlbnQ=?= , Willem de Bruijn Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-omap@vger.kernel.org, Michael Walle , Maxime Chevallier , Richard Cochran , thomas.petazzoni@bootlin.com, Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Joakim Zhang , Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Minghao Chi , Jie Wang , Oleksij Rempel , Sean Anderson , "Gustavo A. R. Silva" , Wolfram Sang , Alexander Lobakin , Marco Bonelli Message-ID: <640b45e9c765e_1dc964208eb@willemb.c.googlers.com.notmuch> In-Reply-To: <20230310154125.696a3eb3@kmaincent-XPS-13-7390> References: <20230308135936.761794-1-kory.maincent@bootlin.com> <20230308135936.761794-4-kory.maincent@bootlin.com> <6408a9b3c7ae1_13061c2082a@willemb.c.googlers.com.notmuch> <20230310154125.696a3eb3@kmaincent-XPS-13-7390> Subject: Re: [PATCH v3 3/5] net: Let the active time stamping layer be selectable. Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org K=C3=B6ry Maincent wrote: > On Wed, 08 Mar 2023 10:28:51 -0500 > Willem de Bruijn wrote: > = > > > = > > > + enum timestamping_layer selected_timestamping_layer; > > > + = > > = > > can perhaps be a single bit rather than an enum > = > I need at least two bits to be able to list the PTPs available. > Look at the ethtool_list_ptp function of the second patch. In the available bitmap, yes. Since there are only two options, in the selected case, a single bit would suffice.=