MIME-Version: 1.0
References: <20230309031755.38561-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20230309031755.38561-1-jiapeng.chong@linux.alibaba.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Fri, 10 Mar 2023 16:28:03 +0100
Message-ID: <CAMRc=MeKN_RWx6x7nu13Sib80sooT=s7ZuWhg6Cow18cuLwGsA@mail.gmail.com>
Subject: Re: [PATCH] gpio: loongson: Remove unnecessary .owner
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     zhuyinbo@loongson.cn, linus.walleij@linaro.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 9, 2023 at 4:18=E2=80=AFAM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Remove .owner field if calls are used which set it automatically.
>
> ./drivers/gpio/gpio-loongson-64bit.c:225:3-8: No need to set .owner here.=
 The core will do it.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D4450
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpio/gpio-loongson-64bit.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loong=
son-64bit.c
> index 20a68e5e66c1..06213bbfabdd 100644
> --- a/drivers/gpio/gpio-loongson-64bit.c
> +++ b/drivers/gpio/gpio-loongson-64bit.c
> @@ -222,7 +222,6 @@ MODULE_DEVICE_TABLE(acpi, loongson_gpio_acpi_match);
>  static struct platform_driver loongson_gpio_driver =3D {
>         .driver =3D {
>                 .name =3D "loongson-gpio",
> -               .owner =3D THIS_MODULE,
>                 .of_match_table =3D loongson_gpio_of_match,
>                 .acpi_match_table =3D loongson_gpio_acpi_match,
>         },
> --
> 2.20.1.7.g153144c
>

Applied, thanks!

Bart