Message-ID: <0a968926-670a-c383-492d-52c45b09bb18@amd.com>
Date:   Fri, 10 Mar 2023 16:35:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [RFC PATCH V3 00/16] x86/hyperv/sev: Add AMD sev-snp enlightened
 guest support on hyperv
Content-Language: en-US
From:   "Gupta, Pankaj" <pankaj.gupta@amd.com>
To:     Tianyu Lan <ltykernel@gmail.com>, luto@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        seanjc@google.com, pbonzini@redhat.com, jgross@suse.com,
        tiala@microsoft.com, kirill@shutemov.name,
        jiangshan.ljs@antgroup.com, peterz@infradead.org,
        ashish.kalra@amd.com, srutherford@google.com,
        akpm@linux-foundation.org, anshuman.khandual@arm.com,
        pawan.kumar.gupta@linux.intel.com, adrian.hunter@intel.com,
        daniel.sneddon@linux.intel.com, alexander.shishkin@linux.intel.com,
        sandipan.das@amd.com, ray.huang@amd.com, brijesh.singh@amd.com,
        michael.roth@amd.com, thomas.lendacky@amd.com,
        venu.busireddy@oracle.com, sterritt@google.com,
        tony.luck@intel.com, samitolvanen@google.com, fenghua.yu@intel.com
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-hyperv@vger.kernel.org, linux-arch@vger.kernel.org
References: <20230122024607.788454-1-ltykernel@gmail.com>
 <fac62414-06f9-0454-8393-f039aa30571a@amd.com>
 <fe100597-26be-23e4-bfa9-f45aa27b7966@amd.com>
In-Reply-To: <fe100597-26be-23e4-bfa9-f45aa27b7966@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmVmekMrV3VyVUJpQWdTZi9lUGxaTDcwVTZoT1VWN1lwSlNxdldlMDZubmhL?=
 =?utf-8?B?dFNIYWZQeUsvN3BtNFpoZUVnZGVOWDQ1TlJhOGdFRENhRXJ6RVVCc2R3YWVK?=
 =?utf-8?B?S0tIYnM2U2Q5Q1doVFhmRnExbTMvU0hVbEpacVA0azJiQUFGdFJkYzM0UW9I?=
 =?utf-8?B?MVlYM2N2YzM0aVhxUlNtUkJYQnhWNzBLb0NlVnFEQUQwSlRSWkhyYUJ5d0hJ?=
 =?utf-8?B?YTd0MlN4RWxKeVZJRGovSmVnT09vQmhoREc0ekI0ck41U3U0cm4wbzVmWU1T?=
 =?utf-8?B?azZEbjZMaXYzd2oxUzJQV05tOVJRbHJQaldwMUtBVEhxOUVNaUtNcVRIVE1K?=
 =?utf-8?B?YW1Sdy95SlBucFRHSXkveHEzN0twZDVZbzBRTVRzdHY2UkpvWnU4NXNiQ2hM?=
 =?utf-8?B?R1pDdHRBa2tWb0lON3VXQStyUy85MHY1dy9aN0p5a3FQTU51YUEzRVUrS2pB?=
 =?utf-8?B?TXRqYW4vc2UyZFJyUUpIRmZaSmEyVU9tcHdGellLNVZOK0hxMkU4NFhSM0Ni?=
 =?utf-8?B?S1NLSE13K3BTSHozYVdNVVRlRkkvR3ExSzZ4U1BnWXhkbHEyZTRvNFM5b0RQ?=
 =?utf-8?B?UzdjK2VOTE1yRWVRWWdVK0E4U3hnaXd6MGh6ck1Bbjh6UjBNa25DOTVhSVRP?=
 =?utf-8?B?c0FtNzZaNWhwamFHejNXb1R5QnNrNE9zc3NzMkY1SjFwOUVkdERxWHBKcHJa?=
 =?utf-8?B?OVhIa0Rld3o3Y2JVdXZDVVFLSmljbEIrSEhUUzhEQnFGOEduWnNXOVZqdE9E?=
 =?utf-8?B?aVBCZThhaysxeUlZMk1xWnUyczgxYTlveDQ4cW9mdzJMbjk4MWxtMlFHWXZz?=
 =?utf-8?B?YkJKUWwvUlVmY0I1ekZGMnpMVHNqV1VMb1dFRTBVY0ZWY0hLMm02TW9tQjBj?=
 =?utf-8?B?M3Q1b0xIZTlmdTUwd2lKSGZ1VW9zdzhYSmVLT2JlSkZRRktJQytEUm5ldnVU?=
 =?utf-8?B?ZDZwMW1ZcS9URFh3S2kza0lVNnExcTQ3aERkbEJldG1oNGdJQ3hOdkREQ3ZQ?=
 =?utf-8?B?WDU5NzhMNDhhOFZlOHNBT3RUYnFOWjhKSXptQWhmQnl3VW5VSXNmcnFZenRL?=
 =?utf-8?B?Ym1oR2p1Q2xReUlvOGFhVVhkYTRpUmRuUDIrYUQ3MVliTkFOamFIdVRiUDJH?=
 =?utf-8?B?bVMxbmZNd1M4STIvRkRjMkx6T1Rja2VOSEVNcEdMaEM5RHl1V0xpSnpsZ05x?=
 =?utf-8?B?MkRQUkZNTTZ6SkhCTmV2M1RQUmM5QzJsdFNLRTAvMjNpSlhsTHBSVHY4ak5r?=
 =?utf-8?B?VkM1VWJ3MDM0Y3dFOENHYmtucnNpc3hYb0N2L01iMmtGTGtXUTFKU3FQMi80?=
 =?utf-8?B?OCtYVUROTmwvVjNra05RQ1dTVWl1UDBNcHZrbmhlRFgzWnQwcWpNT01EcThI?=
 =?utf-8?B?L0ZVa3VicDY3RFRlQVBmbUVEeWtPQXpxR3gxS1Nyb3p3VHdiY1lSZ2V6ZnhH?=
 =?utf-8?B?VnQzZkJ0eFEwZ3V2V2NLeXNEWXNuMjJmOGRZL1JGWSttY3ZqQ2ZFeUt0N0M4?=
 =?utf-8?B?RGNxZ2txSmx5V25XMCs1Sko0N0NLaXUyRHRoTmNoem1Uc2J0d2ZmV1hldFU5?=
 =?utf-8?B?eXZ0NXlRdWQ5czMwRmdLQk1wZ3ZqNEc3c3VqYkF4RHo3Z2RDUHIzYTdNTStO?=
 =?utf-8?B?WUVuQUlyK1A3ek5pMEphQUh0TGg0cDd3SThCWEhUQXFIdDlJWUd5ZnNGOU04?=
 =?utf-8?B?YUdlZ0RoQndlMXowT2ZvSmRhT1l1UFZBTFVXQW5wekhtTGUvSG94cy9saC96?=
 =?utf-8?B?R0dMb04vN1ZLMDQwb09SZ09KSDEwK0ZaR1REQmlSbnc3czBXektlaG43Mk9Q?=
 =?utf-8?B?c2Q4Ym5MU2orN1VtUHpOS2xZUE5Vem80RUtYcC92TTA2Vi9Pd3l2RDJ0ZElY?=
 =?utf-8?B?NHRiUVFZZVkxWks5UGlFTHZwVys3NEZIVGxQdnhRZ0NwRnJJRG9jektTeUs3?=
 =?utf-8?B?RXNKSzVSK2tmYWdSVjYyVERHZFdodmdhQVlEMWJhV1VodVNrWkZLUEVpcEJU?=
 =?utf-8?B?M2pXcXBHem8zSHBWeE5xSUV6QThaTEkrL0VMWWpTNjl4RXVGRmpKeFlSK055?=
 =?utf-8?B?U0pzWlplWE03NlkwUnVrZlpmOG93MlJHdlQ3dklWVlpwMEJMKzk2UHN6VkxE?=
 =?utf-8?Q?K5LkSwBg87ZmYZzvDjmtFP1lk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f777cf7-18ee-46e3-06d2-08db217d203d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 15:35:50.1055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dolp/V6OhhHu1nXtySIFXauklTrRkAnJjCeOITE8FvNR3V0FBnxYIlS4EsQN3Wn5NzuGGvMlaAMxnuBM8+w2gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5867
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Tianyu,

While testing the guest patches on KVM host, My guest kernel is stuck
at early bootup. As it did not seem a hang but sort of loop where 
interrupts are getting processed from "pv_native_irq_enable" path 
repeatedly and prevent boot process to make progress IIUC. Did you face 
any such scenario in your testing?

It seems to me "native_irq_enable" enable interrupts and 
"check_hv_pending_irq_enable" starts handling the interrupts (after 
disabling irqs). But "check_hv_pending_irq_enable=>do_exc_hv" can again 
call "pv_native_irq_enable" in interrupt handling path and execute the 
same loop?

Also pasting below the stack dump [1].

Thanks,
Pankaj

[1]
[   20.530786] Call Trace:^M
[   20.531099]  <IRQ>^M
[   20.531360]  dump_stack_lvl+0x4d/0x67^M
[   20.531820]  dump_stack+0x14/0x1a^M
[   20.532235]  do_exc_hv.cold+0x11/0xec^M
[   20.532792]  check_hv_pending_irq_enable+0x64/0x80^M
[   20.533390]  pv_native_irq_enable+0xe/0x20^M   ====> here
[   20.533902]  __do_softirq+0x89/0x2f3^M
[   20.534352]  __irq_exit_rcu+0x9f/0x110^M
[   20.534825]  irq_exit_rcu+0x12/0x20^M
[   20.535267]  common_interrupt+0xca/0xf0^M
[   20.535745]  </IRQ>^M
[   20.536014]  <TASK>^M
[   20.536286]  do_exc_hv.cold+0xda/0xec^M
[   20.536826]  check_hv_pending_irq_enable+0x64/0x80^M
[   20.537429]  pv_native_irq_enable+0xe/0x20^M    ====> here
[   20.537942]  _raw_spin_unlock_irqrestore+0x21/0x50^M
[   20.538539]  __setup_irq+0x3be/0x740^M
[   20.538990]  request_threaded_irq+0x116/0x180^M
[   20.539533]  hpet_time_init+0x35/0x56^M
[   20.539994]  x86_late_time_init+0x1f/0x3d^M
[   20.540556]  start_kernel+0x8af/0x970^M
[   20.541033]  x86_64_start_reservations+0x28/0x2e^M
[   20.541607]  x86_64_start_kernel+0x96/0xa0^M
[   20.542126]  secondary_startup_64_no_verify+0xe5/0xeb^M
[   20.542757]  </TASK>^M