Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71758C6FA99 for ; Fri, 10 Mar 2023 15:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234345AbjCJPre (ORCPT ); Fri, 10 Mar 2023 10:47:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234332AbjCJPrB (ORCPT ); Fri, 10 Mar 2023 10:47:01 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE400968FE; Fri, 10 Mar 2023 07:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4sSbpNcprPb8eBe1dmHD1XiLaW1EBIYi1S3oZ1ljkXQ=; b=B1e8PPb8dMa33jNS53TpZqi4ua dwfXOMoyIeIY7wAffPe06ZR3P3WLR/nnrg0J+r+mx5Ylyb85YkWf7uBzDUjdtap1OhK8GffJV1sCG 7xVckGY6STeC0X5fMSl8e1WcE3987lRDbgEPDrRLUZtMyo/RDQoobdTCt0DJNFJjPj/w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1paec6-006zJM-JG; Fri, 10 Mar 2023 16:24:58 +0100 Date: Fri, 10 Mar 2023 16:24:58 +0100 From: Andrew Lunn To: =?iso-8859-1?Q?K=F6ry?= Maincent Cc: Michael Walle , Horatiu Vultur , Vladimir Oltean , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-omap@vger.kernel.org, Maxime Chevallier , Richard Cochran , thomas.petazzoni@bootlin.com, Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Minghao Chi , Jie Wang , Oleksij Rempel , Sean Anderson , "Gustavo A. R. Silva" , Wolfram Sang , Alexander Lobakin , Marco Bonelli Subject: Re: [PATCH v3 3/5] net: Let the active time stamping layer be selectable. Message-ID: References: <20230308135936.761794-1-kory.maincent@bootlin.com> <20230308135936.761794-4-kory.maincent@bootlin.com> <20230308135936.761794-4-kory.maincent@bootlin.com> <20230308230321.liw3v255okrhxg6s@skbuf> <20230310114852.3cef643d@kmaincent-XPS-13-7390> <20230310113533.l7flaoli7y3bmlnr@skbuf> <20230310131529.6bahmi4obryy5dsx@soft-dev3-1> <0d2304a9bc276a0d321629108cf8febd@walle.cc> <20230310150436.40ed168d@kmaincent-XPS-13-7390> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310150436.40ed168d@kmaincent-XPS-13-7390> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Adding this whitelist will add some PHY driver specific name in the phy API > core. > Will it be accepted? Is it not better to add a "legacy_default_timestamping" > boolean in the phy_device struct and set it for these 5 PHY drivers? > Then move on the default behavior to MAC default timestamping on the otehr > cases. In the end, it is much the same thing. But if we really want this to be legacy, not used by new drivers, putting it into the core will make it harder for new drivers to set this bit and not get noticed during review. Andrew