Date:   Fri, 10 Mar 2023 12:03:20 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>, will@kernel.org,
        eric.auger@redhat.com, kevin.tian@intel.com,
        baolu.lu@linux.intel.com, joro@8bytes.org,
        shameerali.kolothum.thodi@huawei.com,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, yi.l.liu@intel.com
Subject: Re: [PATCH v1 02/14] iommufd: Add nesting related data structures
 for ARM SMMUv3
Message-ID: <ZAtUyMGIGsl64vM0@nvidia.com>
References: <cover.1678348754.git.nicolinc@nvidia.com>
 <364cfbe5b228ab178093db2de13fa3accf7a6120.1678348754.git.nicolinc@nvidia.com>
 <20230309134217.GA1673607@myrica>
 <ZAnx0lUkw02cVTi+@nvidia.com>
 <20230309182659.GA1710571@myrica>
 <ZApJGwPjHhlDwTDV@nvidia.com>
 <82f5b94b-01fe-5c99-608c-f7d124247b7c@arm.com>
 <ZAtL0Dx0QRbXOTfZ@nvidia.com>
 <029bb2f5-78d5-a3f2-1ae7-97fc7147611d@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <029bb2f5-78d5-a3f2-1ae7-97fc7147611d@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TYip7CK20yHaW3LPCykSpDnoJdk/bFgvDxJcbZ0ouTSZEmV8Cl8stQk4xUR6?=
 =?us-ascii?Q?pkqqa+4dkJeWSh58Pr6ADdVxreBhpLFC+Xze7bnhN5MAgaUF5gRjqkJGsekl?=
 =?us-ascii?Q?Bjy5eWGwPljujNN9FXU3GUpzFknrabJ9sjCe1xOqqGAIMhtltjB+6MrLaWWA?=
 =?us-ascii?Q?3Ot3W+EpCUHVqAGne6kzIfUCNZ6/1i/kt/d4V+GgQe1k17i1BM+xJ9F+UGqZ?=
 =?us-ascii?Q?FGeq5czZmArGQD+G8FaoYuhXMDT3P68aTdwTOCjf7hllVqg+cdXRw6MQewN+?=
 =?us-ascii?Q?5XYp+u99PY36qWD41kYeLbH9E+bS52KdWGljdX2L+Jttl3imR1SRcos/FQYx?=
 =?us-ascii?Q?gQlOzj+bdUJKum45tMI254xHi1Yd8PAG8259hzARvchAqvMhlWpcJ0xgNiHt?=
 =?us-ascii?Q?tTPGxa8/gZ5L7PZb9fd+Aomt995YxZzSC3mCTiakkiyEF5Hot2TOGPq80PZz?=
 =?us-ascii?Q?HSuZYNOtpJV+j1BnoKM16DjClwEKPgE/99pCeuBSqBr8uAg8MSFAK+QShZad?=
 =?us-ascii?Q?m9cqsMiupFe+y1SwAq9XmzUmBnaSO4PIE/FDwkTCAcR6KOoHmY8OK+ucaCz/?=
 =?us-ascii?Q?L4YPF0VGUIuRFQ+Z3UXRfiHLQBIFPWmu0fvdmddY0dIzQ1qHgIZ+pUkILYd3?=
 =?us-ascii?Q?LeQqIGgethLWf4u23IA9EWm5z8kvToPLsfNMCv3U0wGNAtuPcJcG/LnPZDJ7?=
 =?us-ascii?Q?OZ4XpJR2RWjk/X0X7OJUCwAyx9R47lj5Ql0FoKdu8qk9vbFT3cWZI2TOIHQr?=
 =?us-ascii?Q?HAE6V4O381rCS+X6H9DNn8V3XYlRqlyf7K6JYYms1JCPazboy2Nao3TnTV9W?=
 =?us-ascii?Q?xBN5C6uhzXhKaOgLTc4tOiy0wxLPMnahEblZFw5StVgcppkvq0kakMDw3XdS?=
 =?us-ascii?Q?Vy9nafsbyIhtElNtpEp/5wYJnaU6aVBfgokQrO1s8LvmOxPfFZi3oFEUT+Ek?=
 =?us-ascii?Q?RHHqcEYXDrKIydWVn3Um/NfhmFaxYLqZrekzuCpC5wZJS8Bz9HfoF7zunDBv?=
 =?us-ascii?Q?gDhktaaXLDz0BlOGIdNIlkIgDBNNRWixwwmEPs70ZfVrL+s/iiNhHV0bDn2G?=
 =?us-ascii?Q?+kyueRLlZ0kc9PgFX2q7tYndJgJF4QhgrcmNG7PbpmdnOXwmnmV6Ru0yTHce?=
 =?us-ascii?Q?rWuLFmf0Bzzw7T2qPm6bqY7xKVe2KxSEo/8W6VefamQNOQ+OektnfiyDId7i?=
 =?us-ascii?Q?Sz9yFXosxT1+4sTMoKVhxqxSgK2CjqUzztxC4vE5PZyEBkyohzsmH3M75J3v?=
 =?us-ascii?Q?XH1HU/suGI8PiihmkJlErOpBDpRa0nxh036FBH5vfV4j/j29zxD8yYvomaPu?=
 =?us-ascii?Q?sha5vEstQk+LmQQ3tbfie7fgbxDod4Rd5+KNTE84MZxF/LyMpIV4ylJXWU6A?=
 =?us-ascii?Q?eRWB4UUZKhjwhjo+v4tzQG78S50t8CFSG34N/2FpzNVvTxRyFR8d4Tz7hL6R?=
 =?us-ascii?Q?CSeqjIuVHVSS/9BWVM41AVnVm5OCNTGJPYSF6DLulrRr5mAw4EfoCPCbpI23?=
 =?us-ascii?Q?up96VpjeCLDjCVDJNJSwBQ4uJHSettXInKqVM4wlA1spKsO07pRav/uiyaEl?=
 =?us-ascii?Q?liqivCBZW+wpn+NjvD7jbgug/vC7Q3RPJBcMfh51?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf01bc1c-671f-4ba8-f8d7-08db2180f9be
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 16:03:23.3879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A07i/jdYGlcYlBybTN5bNeDtteBtUIKfvvIKWPHCbgBKvqgYKOKHk8FRqGzqJ1Jm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8047
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 03:57:27PM +0000, Robin Murphy wrote:

> about the nitty-gritty of all the IOMMU-specific moving parts around it. For
> guests that want to get into more advanced stuff like managing their own
> PASID tables, pushing them towards "native" nesting probably does make more
> sense.

IMHO with the simplified virtio model I would say the guest should
not have its own PASID table.

hyper trap to install a PASID and let the hypervisor driver handle
this abstractly. If abstractly is the whole point and benifit then
virtio should lean into that.

This also means virtio protocol doesn't do PASID invalidation. It
invalidates an ASID and the hypervisor takes care of whatever it is
connected to. Very simple and general for the VM.

Adding a S1 iommu_domain op for invalidate address range is perfectly
fine and the virtio kernel hypervisor driver can call it generically.

The primary reason to have guest-owned PASID tables is CC stuff, which
definitely won't be part of virtio-iommu.

Jason