From:   Aditya Garg <gargaditya08@live.com>
To:     Jiri Kosina <jikos@kernel.org>
CC:     Orlando Chamberlain <orlandoch.dev@gmail.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Pavel Machek <pavel@ucw.cz>, Aun-Ali Zaidi <admin@kodeit.net>,
        Kerem Karabay <kekrby@gmail.com>,
        Andy Shevchenko <andy@infradead.org>,
        =?iso-8859-1?Q?Thomas_Wei=DFschuh?= <thomas@t-8ch.de>
Subject: Re: [PATCH v5 0/2] Apple Magic Keyboard Backlight
Thread-Topic: [PATCH v5 0/2] Apple Magic Keyboard Backlight
Thread-Index: AQHZRSHQtk/6TmX0P0KgTUJwSEQZ/a70MSkAgAAb1a8=
Date:   Fri, 10 Mar 2023 16:16:11 +0000
Message-ID: <MA0P287MB021727E7ED58C8C74F879CE4B8BA9@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM>
References: <20230220115203.76154-1-orlandoch.dev@gmail.com>
 <nycvar.YFH.7.76.2303101535440.1142@cbobk.fhfr.pm>
In-Reply-To: <nycvar.YFH.7.76.2303101535440.1142@cbobk.fhfr.pm>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [Wyomo9HO5vpJDSL+c+fy4adhx+/r9mLF]
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MA0P287MB0217:EE_|PN0P287MB0427:EE_
x-ms-office365-filtering-correlation-id: c593cdd9-dba8-4141-90b3-08db2182c3cd
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: d2l4slyfgnccVVGxqFN9lwy5zqYR9juw08D12j2dljlJZgly7xU/tuiccsYvN6cYVIea8rvatXQRamWzCbEN5RlIpjFiYePtO2r3fK+IHeUI3FRjhpdWA4iie+F4kz5vW0zrDKxnQcjWXcERq7CRd9bkO38Cvk/GjoyazAbBsB8XjiHOUltJMf8CZLFy7jeXPib2bV0rFd3rqGm4F1U2FTTNkrcdo6GxG/ETnuf7N+nUFPMx0GEuN/EQXx+WS6xs7YJPa3Tt8o3nLkBNvnuF4pyI/S743MHCg2FVGOfx7v9RvFrXIWDqTbLFjcExw6fczBYYY4vStdkrWRzIHR4ABWLhomltu0C1/XfOLjVQ9UJyNlkIyKoZhf3j5e88WiP78mQor3BEjZKtjHlMaUsjZ4jPVfuAn6/WO3i7LOAKkCGhp2IqbI/5ZJDFH6rG0zEL6/HNI7B5IJu1E6JxdjmhYPsR8x9uKuMc2xmgoMkc1tdj/GLtHxxhzQqhjA7fuR4I8rurke3TIlYer/HN1R7Fk3rQpqV0XIWNiiALR00n76luKXRwKOUkYwib+3bGABrnqevLhQpms+8hWt0gzy3IF1poZGd6EtioDDnESTSOq3ej9wlj5vXlCcbBQS5tOecv9flrSA6mniXJgjqw6PFxpg==
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?GbzlB4TnSbdn7tOof1aSOvFPNOC+jlxn64aoNklsui08xPyPRJ8o1nva89?=
 =?iso-8859-1?Q?P1HOmIqWxcPb045hK/l1LKZRRpgGni2oTvKvyj03VuUaVxsvt4uVM1eoU+?=
 =?iso-8859-1?Q?M+5y9Sa0IuCKf9twz/r3i8Wi/TODoKr9tv6G2RVjRb0iENjkLEdCItDqoj?=
 =?iso-8859-1?Q?K07lLpPSdJsnDAhxKxCD56+9YO4KtnEytUjrjVrI5j7wsmmc7iqPBJcafB?=
 =?iso-8859-1?Q?aJTz/4kcPjWRBqQRFtH8GAgHhvf0Bs3yWNn1N5IpMp+tR5iKcZ9PnyP7ih?=
 =?iso-8859-1?Q?au6U7iGG7iCNR9F+nZyDN0li49KOucp23e6ma1ZMQje+oCUcn4zGvgV0vB?=
 =?iso-8859-1?Q?7bBmbYyHM8EIJx05QUq/lHmRRzRgCvEAHVWq54yRVAAYQ8i8A0Z9tdlqYI?=
 =?iso-8859-1?Q?BbuFv5PEzqXgx20vJjlhj01UZlJW4ZvlM8W1FN6aSDmhWuAZWHta+dVDKo?=
 =?iso-8859-1?Q?xqGNrKnhSkHNHJ66cLM/CpPfPaLRod/EKSQtBo1CxKLcFxVXTodruhxWFH?=
 =?iso-8859-1?Q?VhmUnKrWyi23orby1z8joJkJ9QhL4Hd+MSj+Ri5nXCzSOdui2EaQ/hUvoe?=
 =?iso-8859-1?Q?LdR0Tj0ppfnvI9xf5plg7htgCF4bIoqgDjYQmVfPj43hlzVi2CuYSNnbbj?=
 =?iso-8859-1?Q?rqMEg3q7N9z1IfbLfCCB3Pb9vhq/35+EpD50LhL3pBWs4xVqoR//OTAT+2?=
 =?iso-8859-1?Q?9KuMa1ofgGKq6US4Ab8UxyL/uRnEQ+8DWmBK58yJm4gVjQeCfKatXnXlI6?=
 =?iso-8859-1?Q?HM4NivOdcdHXWsnVC7vnaFHedA2lcjc3BzfBAtDmhEttsxAyyxZT0bVpTC?=
 =?iso-8859-1?Q?WzOrBfjtuywjEifalMebAbeAclj62Vr8xdi0mynRQ9qW9z1eo9mMFRMZpI?=
 =?iso-8859-1?Q?OUUXuuQhDdsZgA8ATNxPAHIvW3uDKBXi8Ybpc9SQ6fw0xf+pwSgeiXvSuB?=
 =?iso-8859-1?Q?CMvUx6b7IJd6wcvM6+kIH8M9lv1T2f9V/RCPEcyIGtc7BaUFaxiIWsC/Xy?=
 =?iso-8859-1?Q?8RFzTOBkoDOpnysv15EqZBP73lYiGVUk+92aKO5P8HHSrxJ3uIU11iYd6D?=
 =?iso-8859-1?Q?WqVgAFzZhRtB8+af4kUO82R/B0osDhDp+FXHYVn0a6ibqQtMwudLzP5Pe6?=
 =?iso-8859-1?Q?sqyv3+B5+Jbw2UdFt6TmdtTS1O3A+hBbEc6hHH/ekibbTeKLb46y6pzBV7?=
 =?iso-8859-1?Q?u6heQ4CBd3hNTMATGPYHRURKNdkp+TMzeUR8rh74/CBVYHcpuF9MJFpmwa?=
 =?iso-8859-1?Q?qwxqdXC0tnCUnpyK01UjeHWDqxq69iFo0HNPqQMOZ+jmAzG3KIsyNZQ/rn?=
 =?iso-8859-1?Q?bnHCQ3Fwam7UyKgd33BZ+R7JOg=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-bafef.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB0217.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: c593cdd9-dba8-4141-90b3-08db2182c3cd
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2023 16:16:11.6926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0P287MB0427
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Hi,
>=20
> thanks for creating the support for backlight.
>=20
> Is there any reason why not to fold all this into existing hid-apple? I=20
> don't think we need separate driver for the backlist, separated from the=
=20
> rest of hid-apple support.
>=20
> Thanks,
>=20
> --=20
> Jiri Kosina
> SUSE Labs
>=20

As far as I know, hid-apple manages the keyboards and trackpads on Macs.

The magic backlight is managed by the touchbar on T2 Macs, so if you wanna =
integrate the driver in some other one, then it should be the to-be-upstrea=
med touchbar driver.

But when we did that, the MacBook Air 2020, the model which has magic backl=
ight, but no touchbar faced issues. lsusb interestingly shows presence of t=
ouch bar backlight even on this model, but backlight is registered at the 0=
th interface on Air, and 1st interface on the Pros. So, the co-author, Kere=
m Karabay suggested using a separate driver.

Although, the authors may give more detailed reason for the same.=