Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Fri, 10 Mar 2023 08:42:56 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     void0red <void0red@gmail.com>
Cc:     jdelvare@suse.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org, mezin.alexander@gmail.com
Subject: Re: [PATCH v2 1/2] hwmon: g762: add a check of devm_add_action in
 g762_of_clock_enable
Message-ID: <4f4b71ed-2c9c-4e87-aceb-1d2f098e0408@roeck-us.net>
References: <42cdd5e4-c9da-b31a-0ffd-76846757645c@roeck-us.net>
 <20230227030913.893004-1-void0red@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230227030913.893004-1-void0red@gmail.com>
Precedence: bulk

On Mon, Feb 27, 2023 at 11:09:12AM +0800, void0red wrote:
> From: Kang Chen <void0red@gmail.com>
> 
> devm_add_action may fails, check it and do the cleanup.
> 
> Signed-off-by: Kang Chen <void0red@gmail.com>

Applied.

Thanks,
Guenter

> ---
> v2 -> v1: split the patch
> 
>  drivers/hwmon/g762.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/g762.c b/drivers/hwmon/g762.c
> index 64a0599b2..e2c3c34f0 100644
> --- a/drivers/hwmon/g762.c
> +++ b/drivers/hwmon/g762.c
> @@ -620,7 +620,12 @@ static int g762_of_clock_enable(struct i2c_client *client)
>  	data = i2c_get_clientdata(client);
>  	data->clk = clk;
>  
> -	devm_add_action(&client->dev, g762_of_clock_disable, data);
> +	ret = devm_add_action(&client->dev, g762_of_clock_disable, data);
> +	if (ret) {
> +		dev_err(&client->dev, "failed to add disable clock action\n");
> +		goto clk_unprep;
> +	}
> +
>  	return 0;
>  
>   clk_unprep: